)]}'
{"id":"openocd~master~I557f0d90b7ce6f9d81aa409b6400fc9c83d16008","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000005":{"account":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"last_update":"2021-11-18 21:13:19.000000000","reason":"Change was submitted"},"1001839":{"account":{"_account_id":1001839,"name":"Antonio Borneo","email":"antonio.borneo@st.com"},"last_update":"2021-11-18 21:13:19.000000000","reason":"Change was submitted"},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2021-11-08 19:42:56.000000000","reason":"Tomas Vanek replied on the change"}},"hashtags":[],"change_id":"I557f0d90b7ce6f9d81aa409b6400fc9c83d16008","subject":"cortex_m: Restore fast register reads if no polling is needed","status":"MERGED","created":"2021-11-08 17:32:04.000000000","updated":"2021-11-18 21:13:19.000000000","submitted":"2021-11-18 21:13:19.000000000","submitter":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6678","meta_rev_id":"0aaa749b34b8b493c18b567546834fc5e8de3411","_number":6678,"owner":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-11-18 21:13:19.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-11-18 21:13:19.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-11-18 21:13:19.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1001839,"name":"Antonio Borneo","email":"antonio.borneo@st.com"}],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"_account_id":1001839,"name":"Antonio Borneo","email":"antonio.borneo@st.com"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-11-08 17:48:06.000000000","updated_by":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"reviewer":{"_account_id":1001839,"name":"Antonio Borneo","email":"antonio.borneo@st.com"},"state":"REVIEWER"},{"updated":"2021-11-08 17:48:06.000000000","updated_by":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"},{"updated":"2021-11-08 17:52:04.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-11-08 22:19:19.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"503a27399361ced2539d7ec83a76b96e6ffe3316","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"real_author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"date":"2021-11-08 17:32:04.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"614a00f180652dbbeffb38190dc1f191805abe2b","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-11-08 17:52:04.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15464/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14682/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"074a94ce3e36ab524ea360e1b6b4fd535f3d6903","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-11-08 19:42:56.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"d818854f3fb596fd6b67d5427e1ceba2a0943420","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-11-08 22:19:19.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"89146e2a6224652a1aeff01ee9b5ee4b8eafd159","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-11-11 21:18:08.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"0aaa749b34b8b493c18b567546834fc5e8de3411","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-11-18 21:13:19.000000000","message":"Change has been successfully cherry-picked as caa16981364d747c1c71edaf156e8a4faa83b02b","accounts_in_message":[],"_revision_number":2}],"current_revision":"caa16981364d747c1c71edaf156e8a4faa83b02b","revisions":{"a900b400348a5f5839a9b7657a02ff663d806316":{"kind":"REWORK","_number":1,"created":"2021-11-08 17:32:04.000000000","uploader":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"ref":"refs/changes/78/6678/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/78/6678/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/78/6678/1 \u0026\u0026 git checkout -b change-6678 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/78/6678/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/78/6678/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/78/6678/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/78/6678/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/78/6678/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"8234a01c4014bcbfb5d171645797b167bef4567f","subject":"target/cortex_m: faster reading of all CPU registers"}],"author":{"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","date":"2021-11-08 17:09:56.000000000","tz":60},"committer":{"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","date":"2021-11-08 17:09:56.000000000","tz":60},"subject":"cortex_m: Restore fast register reads if no polling is needed","message":"cortex_m: Restore fast register reads if no polling is needed\n\nIf the target is in a state where S_REGRDY polling is necessary (slow\nclock, low power state...?), OpenOCD will continue to use the slow\npath even if the condition is temporary and the target at a later\npoint would be capable of fast reads again.\n\nRevert to fast reads if a full register dump can be made without need\nfor polling any of the registers; presumably it will succeed the next\ntime too.\n\nChange-Id: I557f0d90b7ce6f9d81aa409b6400fc9c83d16008\nSigned-off-by: Andreas Fritiofson \u003candreas.fritiofson@gmail.com\u003e\n"}},"caa16981364d747c1c71edaf156e8a4faa83b02b":{"kind":"REWORK","_number":2,"created":"2021-11-18 21:13:19.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/78/6678/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/78/6678/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/78/6678/2 \u0026\u0026 git checkout -b change-6678 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/78/6678/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/78/6678/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/78/6678/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/78/6678/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/78/6678/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"88f429ead019fd6df96ec15f0d897385f3cef0d0","subject":"target/cortex_m: faster reading of all CPU registers"}],"author":{"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","date":"2021-11-08 17:09:56.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2021-11-18 21:13:19.000000000","tz":0},"subject":"cortex_m: Restore fast register reads if no polling is needed","message":"cortex_m: Restore fast register reads if no polling is needed\n\nIf the target is in a state where S_REGRDY polling is necessary (slow\nclock, low power state...?), OpenOCD will continue to use the slow\npath even if the condition is temporary and the target at a later\npoint would be capable of fast reads again.\n\nRevert to fast reads if a full register dump can be made without need\nfor polling any of the registers; presumably it will succeed the next\ntime too.\n\nChange-Id: I557f0d90b7ce6f9d81aa409b6400fc9c83d16008\nSigned-off-by: Andreas Fritiofson \u003candreas.fritiofson@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6678\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}