)]}'
{"id":"openocd~master~I3b1a143589fe6defafb8f95820aa682acc9646e7","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1001937":{"account":{"_account_id":1001937,"name":"Paul Sherman","username":"psherman42"},"last_update":"2021-12-03 21:58:55.000000000","reason":"Change was submitted"},"1001242":{"account":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"last_update":"2021-11-24 18:23:07.000000000","reason":"Tim Newsome replied on the change"},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2021-11-18 19:37:25.000000000","reason":"Tomas Vanek replied on the change"},"1001646":{"account":{"_account_id":1001646,"name":"Tim Newsome","email":"tim@casualhacker.net"},"last_update":"2021-11-25 12:51:24.000000000","reason":"Tomas Vanek replied on the change"},"1001900":{"account":{"_account_id":1001900,"name":"Katsuhiro Suzuki","email":"katsuhiro@katsuster.net","username":"katsuster"},"last_update":"2021-11-10 09:57:05.000000000","reason":"Katsuhiro Suzuki replied on the change"}},"hashtags":[],"change_id":"I3b1a143589fe6defafb8f95820aa682acc9646e7","subject":"flash/nor/fespi: algorithm, large address, errors","status":"MERGED","created":"2021-11-08 17:37:24.000000000","updated":"2021-12-03 21:58:55.000000000","submitted":"2021-12-03 21:58:55.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":24,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6679","meta_rev_id":"4eff3e56f695eba6a6acda607cd96700232ba724","_number":6679,"owner":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-12-03 21:58:55.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"value":0,"_account_id":1001900,"name":"Katsuhiro Suzuki","email":"katsuhiro@katsuster.net","username":"katsuster"}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-12-03 21:58:55.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"value":0,"_account_id":1001900,"name":"Katsuhiro Suzuki","email":"katsuhiro@katsuster.net","username":"katsuster"}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1001646,"name":"Tim Newsome","email":"tim@casualhacker.net"}],"reviewers":{"CC":[{"_account_id":1001937,"name":"Paul Sherman","username":"psherman42"}],"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"_account_id":1001646,"name":"Tim Newsome","email":"tim@casualhacker.net"},{"_account_id":1001900,"name":"Katsuhiro Suzuki","email":"katsuhiro@katsuster.net","username":"katsuster"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-11-08 18:04:03.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-11-09 21:38:34.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"},{"updated":"2021-11-09 21:38:34.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1001900,"name":"Katsuhiro Suzuki","email":"katsuhiro@katsuster.net","username":"katsuster"},"state":"REVIEWER"},{"updated":"2021-11-23 03:42:06.000000000","updated_by":{"_account_id":1001937,"name":"Paul Sherman","username":"psherman42"},"reviewer":{"_account_id":1001937,"name":"Paul Sherman","username":"psherman42"},"state":"CC"},{"updated":"2021-11-23 03:42:06.000000000","updated_by":{"_account_id":1001937,"name":"Paul Sherman","username":"psherman42"},"reviewer":{"_account_id":1001646,"name":"Tim Newsome","email":"tim@casualhacker.net"},"state":"REVIEWER"},{"updated":"2021-12-03 21:58:55.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"d313a3167d361d17e106ad69d3fce59147da9cca","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"real_author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"date":"2021-11-08 17:37:24.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d88c383b1d5753a623032c4321630832eca937e1","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-11-08 18:04:03.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15465/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14683/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"8654502849cd7de0988fc046801cf66c4c301949","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-11-09 21:38:34.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"c967bedc3935dea13aebccf43398e9a3dab7bba1","author":{"_account_id":1001900,"name":"Katsuhiro Suzuki","email":"katsuhiro@katsuster.net","username":"katsuster"},"real_author":{"_account_id":1001900,"name":"Katsuhiro Suzuki","email":"katsuhiro@katsuster.net","username":"katsuster"},"date":"2021-11-10 09:57:05.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"6103829691ae41862b2fd26a6271ce724a904834","author":{"_account_id":1001900,"name":"Katsuhiro Suzuki","email":"katsuhiro@katsuster.net","username":"katsuster"},"real_author":{"_account_id":1001900,"name":"Katsuhiro Suzuki","email":"katsuhiro@katsuster.net","username":"katsuster"},"date":"2021-11-11 10:37:18.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"b0caebd5cd79ca863bd9fe320730a0a77beeacb1","author":{"_account_id":1001900,"name":"Katsuhiro Suzuki","email":"katsuhiro@katsuster.net","username":"katsuster"},"real_author":{"_account_id":1001900,"name":"Katsuhiro Suzuki","email":"katsuhiro@katsuster.net","username":"katsuster"},"date":"2021-11-11 10:48:19.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"e206d51faa93a5b3b305f9ad52dea78f811f41eb","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-11-11 10:56:16.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"d492c7465e2933878f9a1e3343bc061b8149e326","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-11-18 03:02:33.000000000","message":"Patch Set 1: -Code-Review\n\n(7 comments)","accounts_in_message":[],"_revision_number":1},{"id":"1e629ae4d74ac1d96bab25c9c9d2d4b693837094","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"real_author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"date":"2021-11-18 19:17:06.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"dbe68aef1eedc6b6a0add739e06aae8755edad56","author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"real_author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"date":"2021-11-18 19:17:26.000000000","message":"Patch Set 1:\n\n(7 comments)","accounts_in_message":[],"_revision_number":1},{"id":"9fa20b2138c1ca0907c2e9bbc3c09066262a0372","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-11-18 19:31:56.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15569/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14786/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"935f4c09a3f22f74ea75b0a23f7d83aa98c974d7","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-11-18 19:37:25.000000000","message":"Patch Set 2: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"10b220d7ff789e155fe2aae0baf91bd64268fb84","author":{"_account_id":1001937,"name":"Paul Sherman","username":"psherman42"},"real_author":{"_account_id":1001937,"name":"Paul Sherman","username":"psherman42"},"date":"2021-11-23 03:42:06.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"8c0e337056e9cfe5ab858f984945127ab38a1ded","author":{"_account_id":1001937,"name":"Paul Sherman","username":"psherman42"},"real_author":{"_account_id":1001937,"name":"Paul Sherman","username":"psherman42"},"date":"2021-11-23 03:44:40.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"65d374e45b3698cc2f5a29ecab2cb2c6c0ea9288","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-11-23 07:13:20.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"89f7dcf26d09fa84803fb68faadc7c22f159a593","author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"real_author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"date":"2021-11-24 18:23:07.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"d9b8f3a0692ef40a8886b96f111ccd592b1b7af0","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-11-25 12:51:24.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"4eff3e56f695eba6a6acda607cd96700232ba724","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-12-03 21:58:55.000000000","message":"Change has been successfully cherry-picked as 35f284fe7c51d29768156cfec172152d2539d98a","accounts_in_message":[],"_revision_number":3}],"current_revision":"35f284fe7c51d29768156cfec172152d2539d98a","revisions":{"30fff5089a1f00ce5e9d6f290032432f6aabe8cc":{"kind":"REWORK","_number":1,"created":"2021-11-08 17:37:24.000000000","uploader":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"ref":"refs/changes/79/6679/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/79/6679/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/79/6679/1 \u0026\u0026 git checkout -b change-6679 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/79/6679/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/79/6679/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/79/6679/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/79/6679/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/79/6679/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b2ab2241f20fd3da11c92f8edde4639ab8ce996f","subject":"jimtcl: revert temporary workaround for memory leak in jimtcl 0.80"}],"author":{"name":"Tim Newsome","email":"tim@sifive.com","date":"2021-11-08 17:26:51.000000000","tz":-480},"committer":{"name":"Tim Newsome","email":"tim@sifive.com","date":"2021-11-08 17:37:13.000000000","tz":-480},"subject":"flash/nor/fespi: algorithm, large address, errors","message":"flash/nor/fespi: algorithm, large address, errors\n\n* Move more smarts into the target algorithm code, and rewrite that in C\n  so it\u0027s easier to understand/maintain.\n* Support \u003e24-bit addresses.\n* Check for errors.\n\nChange-Id: I3b1a143589fe6defafb8f95820aa682acc9646e7\nSigned-off-by: Tim Newsome \u003ctim@sifive.com\u003e\n"}},"4193ae2349492a554cf81e6d936db2e155964118":{"kind":"REWORK","_number":2,"created":"2021-11-18 19:17:06.000000000","uploader":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"ref":"refs/changes/79/6679/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/79/6679/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/79/6679/2 \u0026\u0026 git checkout -b change-6679 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/79/6679/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/79/6679/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/79/6679/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/79/6679/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/79/6679/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b2ab2241f20fd3da11c92f8edde4639ab8ce996f","subject":"jimtcl: revert temporary workaround for memory leak in jimtcl 0.80"}],"author":{"name":"Tim Newsome","email":"tim@sifive.com","date":"2021-11-08 17:26:51.000000000","tz":-480},"committer":{"name":"Tim Newsome","email":"tim@sifive.com","date":"2021-11-18 19:16:50.000000000","tz":-480},"subject":"flash/nor/fespi: algorithm, large address, errors","message":"flash/nor/fespi: algorithm, large address, errors\n\n* Move more smarts into the target algorithm code, and rewrite that in C\n  so it\u0027s easier to understand/maintain.\n* Support \u003e24-bit addresses.\n* Check for errors.\n\nChange-Id: I3b1a143589fe6defafb8f95820aa682acc9646e7\nSigned-off-by: Tim Newsome \u003ctim@sifive.com\u003e\n"}},"35f284fe7c51d29768156cfec172152d2539d98a":{"kind":"REWORK","_number":3,"created":"2021-12-03 21:58:55.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/79/6679/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/79/6679/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/79/6679/3 \u0026\u0026 git checkout -b change-6679 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/79/6679/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/79/6679/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/79/6679/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/79/6679/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/79/6679/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"15110b2b5bf3459d038e6142d151c3856760e387","subject":"doc/openocd.texi: Document usage command"}],"author":{"name":"Tim Newsome","email":"tim@sifive.com","date":"2021-11-08 17:26:51.000000000","tz":-480},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-12-03 21:58:55.000000000","tz":0},"subject":"flash/nor/fespi: algorithm, large address, errors","message":"flash/nor/fespi: algorithm, large address, errors\n\n* Move more smarts into the target algorithm code, and rewrite that in C\n  so it\u0027s easier to understand/maintain.\n* Support \u003e24-bit addresses.\n* Check for errors.\n\nChange-Id: I3b1a143589fe6defafb8f95820aa682acc9646e7\nSigned-off-by: Tim Newsome \u003ctim@sifive.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6679\nTested-by: jenkins\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}