)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"change_message_id":"cde63bca7185ffb1ee0019f57337dad15fe78a99","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Tomas Vanek \u003cvanekt@fbl.cz\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-11-09 19:37:10 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"doc: prevent writing \"topic:\" to commit message"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"First time contributors surprisingly often write \"topic:\""},{"line_number":10,"context_line":"instead of \"the main part or subsystem the patch touches\" as requested"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"d62a7721_74befdbb","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":3},"updated":"2021-11-12 12:52:11.000000000","message":"You are stronger than me. I could not have resisted putting \"topic\" here. Or even better, \"Specify touched area\"!","commit_id":"68b761c3df2a0f3256ea97934cd07da1ff9f750f"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"11431a428bdfa5d4cb72ba8ea2d293b800cff739","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ed983629_42b8d7b2","updated":"2021-11-09 23:36:55.000000000","message":"I was surprised to see so many commit messages starting with \"topic:\", but never though could come from HACKING. Well spotted!\nInstead of so many examples, I would suggest user to check with \"git log \u003cfilename\u003e\" how latest commits for that file were titled.","commit_id":"68b761c3df2a0f3256ea97934cd07da1ff9f750f"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"7ac4d65a2985879f27ad32b2923cb998dc43fccb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"eff65f64_e4a1039a","updated":"2021-11-09 19:19:19.000000000","message":"The change contains \u0027Signed-off-by: ...\u0027 as a context from the untouched HACKING part.\nThis upsets checkpatch. Can we override it?","commit_id":"68b761c3df2a0f3256ea97934cd07da1ff9f750f"},{"author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"change_message_id":"cde63bca7185ffb1ee0019f57337dad15fe78a99","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"58085fe1_39607aac","updated":"2021-11-12 12:52:11.000000000","message":"This hopefully improves things, although I wouldn\u0027t bet on it.","commit_id":"68b761c3df2a0f3256ea97934cd07da1ff9f750f"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"f429dee758b7fb6580dff01cf19c6595bffb7755","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"32999dbf_afb7a6a0","in_reply_to":"58085fe1_39607aac","updated":"2021-12-06 12:57:55.000000000","message":"\u003e This hopefully improves things, although I wouldn\u0027t bet on it.\n\n\"For every idiot-proof system devised, a new, improved idiot will arise to overcome it.\"\nAt least we\u0027ve done our best.","commit_id":"68b761c3df2a0f3256ea97934cd07da1ff9f750f"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"982a52fd96de39783fff5e5eb46acc5043599bd3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9b0c6a61_1d223287","in_reply_to":"8970b155_27d8f302","updated":"2021-11-10 14:57:14.000000000","message":"ok!","commit_id":"68b761c3df2a0f3256ea97934cd07da1ff9f750f"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"f7b33ad724fb55debd1023757e7465adbb26a3a4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8970b155_27d8f302","in_reply_to":"ed983629_42b8d7b2","updated":"2021-11-10 13:35:56.000000000","message":"HACKING already contains hint to see git log for examples. \"topic:\"-writers do not read the text, just skim the page for something to copy. That\u0027s why I see a good chance in providing examples.","commit_id":"68b761c3df2a0f3256ea97934cd07da1ff9f750f"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"61ac172c1239720478999030fd8e62b3553dfec1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"433d8921_14801da3","updated":"2022-05-10 13:50:03.000000000","message":"Topic strikes again.\nWhy this patch has no review score?","commit_id":"2bdce553a51589872574e7aa9531543112a24949"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"cf4cc07b79139ad6e61fd777c119babf2848ec35","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2a38c66f_82ab8d59","updated":"2022-05-17 13:35:06.000000000","message":"Send out a minimal fix\n\nPaul,\ncan you please drop the -1 caused by checkpatch that doesn\u0027t like the string \"Signed-off-by:\" inside the text?","commit_id":"03c8824579e95ce19f6d89e3a8121b523215f599"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"87489c2c6be73ac047910b309dfb6d23e5cdad05","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9b716f8e_5efd8d80","updated":"2022-05-17 14:08:02.000000000","message":"Tanks for quotation marks, Antonio","commit_id":"03c8824579e95ce19f6d89e3a8121b523215f599"}],"HACKING":[{"author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"change_message_id":"715316ae080272dbd3ab875ea9b352533b4737be","unresolved":false,"context_lines":[{"line_number":172,"context_line":"   \\note use \"git add .\" before commit to add new files."},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"   Commit message template, notice the short first line."},{"line_number":175,"context_line":"   The field \u003cem\u003e\u0027Specify touched area\u0027\u003c/em\u003e"},{"line_number":176,"context_line":"   should identify the main part or subsystem the patch touches."},{"line_number":177,"context_line":"@code"},{"line_number":178,"context_line":"Specify touched area: Short comment"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"048abe50_8762a4a3","line":175,"updated":"2021-11-09 19:51:50.000000000","message":"I wonder if \u003cem\u003e HTML tag is the best way here for a file which is processed by Doxygen I guess?","commit_id":"68b761c3df2a0f3256ea97934cd07da1ff9f750f"},{"author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"change_message_id":"715316ae080272dbd3ab875ea9b352533b4737be","unresolved":false,"context_lines":[{"line_number":175,"context_line":"   The field \u003cem\u003e\u0027Specify touched area\u0027\u003c/em\u003e"},{"line_number":176,"context_line":"   should identify the main part or subsystem the patch touches."},{"line_number":177,"context_line":"@code"},{"line_number":178,"context_line":"Specify touched area: Short comment"},{"line_number":179,"context_line":"\u003cblank line\u003e"},{"line_number":180,"context_line":"Longer comments over several lines, explaining (where applicable) the"},{"line_number":181,"context_line":"reason for the patch and the general idea the solution is based on,"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"0a27a63c_cd7aa579","line":178,"updated":"2021-11-09 19:51:50.000000000","message":"This suggests that the comment (and the area) should start with upper case which is not customary","commit_id":"68b761c3df2a0f3256ea97934cd07da1ff9f750f"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"c36a93f005fa768a0a95f81a9d18c01c83fd2fbc","unresolved":true,"context_lines":[{"line_number":175,"context_line":"   The field \u003cem\u003e\u0027Specify touched area\u0027\u003c/em\u003e"},{"line_number":176,"context_line":"   should identify the main part or subsystem the patch touches."},{"line_number":177,"context_line":"@code"},{"line_number":178,"context_line":"Specify touched area: Short comment"},{"line_number":179,"context_line":"\u003cblank line\u003e"},{"line_number":180,"context_line":"Longer comments over several lines, explaining (where applicable) the"},{"line_number":181,"context_line":"reason for the patch and the general idea the solution is based on,"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"476beecd_45daa63c","line":178,"in_reply_to":"0a27a63c_cd7aa579","updated":"2021-11-09 21:31:36.000000000","message":"Good point. Short comment was upper case originally. git log shows mostly lower case so I\u0027ll change both field to lcase, ok?","commit_id":"68b761c3df2a0f3256ea97934cd07da1ff9f750f"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"f429dee758b7fb6580dff01cf19c6595bffb7755","unresolved":false,"context_lines":[{"line_number":175,"context_line":"   The field \u003cem\u003e\u0027Specify touched area\u0027\u003c/em\u003e"},{"line_number":176,"context_line":"   should identify the main part or subsystem the patch touches."},{"line_number":177,"context_line":"@code"},{"line_number":178,"context_line":"Specify touched area: Short comment"},{"line_number":179,"context_line":"\u003cblank line\u003e"},{"line_number":180,"context_line":"Longer comments over several lines, explaining (where applicable) the"},{"line_number":181,"context_line":"reason for the patch and the general idea the solution is based on,"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"8d61d73b_be6bd8fc","line":178,"in_reply_to":"476beecd_45daa63c","updated":"2021-12-06 12:57:55.000000000","message":"Done","commit_id":"68b761c3df2a0f3256ea97934cd07da1ff9f750f"},{"author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"change_message_id":"715316ae080272dbd3ab875ea9b352533b4737be","unresolved":false,"context_lines":[{"line_number":195,"context_line":"Add new flash driver for internal flash of ..."},{"line_number":196,"context_line":"@endcode"},{"line_number":197,"context_line":"@code"},{"line_number":198,"context_line":"target: fix segmentation fault in cmd \u0027mdq\u0027"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"mdq command failed reproducibly under following conditions: ..."},{"line_number":201,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"aa5a98f2_f9e4f591","line":198,"updated":"2021-11-09 19:51:50.000000000","message":"I would choose some specific target, e.g. cortex-m: for illustration purposes","commit_id":"68b761c3df2a0f3256ea97934cd07da1ff9f750f"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"f429dee758b7fb6580dff01cf19c6595bffb7755","unresolved":false,"context_lines":[{"line_number":195,"context_line":"Add new flash driver for internal flash of ..."},{"line_number":196,"context_line":"@endcode"},{"line_number":197,"context_line":"@code"},{"line_number":198,"context_line":"target: fix segmentation fault in cmd \u0027mdq\u0027"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"mdq command failed reproducibly under following conditions: ..."},{"line_number":201,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"2f345779_4967dd5a","line":198,"in_reply_to":"52c2e7ed_0f6468d2","updated":"2021-12-06 12:57:55.000000000","message":"Done","commit_id":"68b761c3df2a0f3256ea97934cd07da1ff9f750f"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"c36a93f005fa768a0a95f81a9d18c01c83fd2fbc","unresolved":true,"context_lines":[{"line_number":195,"context_line":"Add new flash driver for internal flash of ..."},{"line_number":196,"context_line":"@endcode"},{"line_number":197,"context_line":"@code"},{"line_number":198,"context_line":"target: fix segmentation fault in cmd \u0027mdq\u0027"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"mdq command failed reproducibly under following conditions: ..."},{"line_number":201,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"52c2e7ed_0f6468d2","line":198,"in_reply_to":"aa5a98f2_f9e4f591","updated":"2021-11-09 21:31:36.000000000","message":"TBH I hope a new contributor won\u0027t touch target or target/cortex_m code.\nI tried to illustrate how a fix could look like with Fixes: and Reported-by: fields.\nIf you insist I can fabricate a new hypothetical error from cortex_m code.","commit_id":"68b761c3df2a0f3256ea97934cd07da1ff9f750f"},{"author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"change_message_id":"398e2dd3df4d5ef98faaf5a027db62404612ee6b","unresolved":false,"context_lines":[{"line_number":196,"context_line":"@endcode"},{"line_number":197,"context_line":"@code"},{"line_number":198,"context_line":"target: fix segmentation fault in cmd \u0027mdq\u0027"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"mdq command failed reproducibly under following conditions: ..."},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"Reported-by: John Reporter \u003crep9876@gmail.com\u003e"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"5650482b_d42116f9","line":199,"updated":"2021-11-09 21:50:57.000000000","message":"I do not insist, just had a thought \"target\" might be misunderstood in the reverse way to how people were understanding \"topic:\" :)","commit_id":"68b761c3df2a0f3256ea97934cd07da1ff9f750f"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"c36a93f005fa768a0a95f81a9d18c01c83fd2fbc","unresolved":true,"context_lines":[{"line_number":201,"context_line":""},{"line_number":202,"context_line":"Reported-by: John Reporter \u003crep9876@gmail.com\u003e"},{"line_number":203,"context_line":"Fixes: 123456789abc (target: the commit where the problem started)"},{"line_number":204,"context_line":"Closes-Bug: https://sourceforge.net/p/openocd/tickets/999/"},{"line_number":205,"context_line":"@endcode"},{"line_number":206,"context_line":"@code"},{"line_number":207,"context_line":"doc: fix typos"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"92de4e04_50da9165","line":204,"range":{"start_line":204,"start_character":0,"end_line":204,"end_character":10},"updated":"2021-11-09 21:31:36.000000000","message":"Closes-Bug: has never been used in our git. I found it somewhere in net.\nSince now Fixed: was alternately used for both commit and ticket.\nI\u0027ve also seen Ticket: field in old git commits.\nWhat do you think?","commit_id":"68b761c3df2a0f3256ea97934cd07da1ff9f750f"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"f429dee758b7fb6580dff01cf19c6595bffb7755","unresolved":false,"context_lines":[{"line_number":201,"context_line":""},{"line_number":202,"context_line":"Reported-by: John Reporter \u003crep9876@gmail.com\u003e"},{"line_number":203,"context_line":"Fixes: 123456789abc (target: the commit where the problem started)"},{"line_number":204,"context_line":"Closes-Bug: https://sourceforge.net/p/openocd/tickets/999/"},{"line_number":205,"context_line":"@endcode"},{"line_number":206,"context_line":"@code"},{"line_number":207,"context_line":"doc: fix typos"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"89484e7b_891ee184","line":204,"range":{"start_line":204,"start_character":0,"end_line":204,"end_character":10},"in_reply_to":"31746470_2c487a95","updated":"2021-12-06 12:57:55.000000000","message":"The example changed to BugLink:","commit_id":"68b761c3df2a0f3256ea97934cd07da1ff9f750f"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"f7b33ad724fb55debd1023757e7465adbb26a3a4","unresolved":true,"context_lines":[{"line_number":201,"context_line":""},{"line_number":202,"context_line":"Reported-by: John Reporter \u003crep9876@gmail.com\u003e"},{"line_number":203,"context_line":"Fixes: 123456789abc (target: the commit where the problem started)"},{"line_number":204,"context_line":"Closes-Bug: https://sourceforge.net/p/openocd/tickets/999/"},{"line_number":205,"context_line":"@endcode"},{"line_number":206,"context_line":"@code"},{"line_number":207,"context_line":"doc: fix typos"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"ada2b8b9_0204a4c7","line":204,"range":{"start_line":204,"start_character":0,"end_line":204,"end_character":10},"in_reply_to":"6d42987d_e32ea1f4","updated":"2021-11-10 13:35:56.000000000","message":"\u003e Linux development doesn\u0027t use a bug tracker. \"Fixes:\" is use for both a commit version or a URL to an email stored somewhere.\n\nUnfortunately linux kernel git log shows big inconsistency in linking bugs. If you grep bugzilla, you get\n Link: (65-times)\n BugLink: (45)\n Bug: (18)\n Bugzilla: (14)\nand only one Fixes: in the last 30000 commits.\n\n\u003e With OpenOCD we use the SF tickets. I use Fixes: to report the ticket\u0027s URL too.\n\nI know, I browsed git log. Two years ago you used Ticket:\nAnd somebody used Closes: only once.\n\nI would prefer not to overload Fixes: meaning and use it only for commit ref (as most of kernel devs do).\nBoth universal Link and specific BugLink seems me good. Which one we\u0027ll choose?","commit_id":"68b761c3df2a0f3256ea97934cd07da1ff9f750f"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"11431a428bdfa5d4cb72ba8ea2d293b800cff739","unresolved":true,"context_lines":[{"line_number":201,"context_line":""},{"line_number":202,"context_line":"Reported-by: John Reporter \u003crep9876@gmail.com\u003e"},{"line_number":203,"context_line":"Fixes: 123456789abc (target: the commit where the problem started)"},{"line_number":204,"context_line":"Closes-Bug: https://sourceforge.net/p/openocd/tickets/999/"},{"line_number":205,"context_line":"@endcode"},{"line_number":206,"context_line":"@code"},{"line_number":207,"context_line":"doc: fix typos"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"6d42987d_e32ea1f4","line":204,"range":{"start_line":204,"start_character":0,"end_line":204,"end_character":10},"in_reply_to":"92de4e04_50da9165","updated":"2021-11-09 23:36:55.000000000","message":"Linux development doesn\u0027t use a bug tracker. \"Fixes:\" is use for both a commit version or a URL to an email stored somewhere.\nWith OpenOCD we use the SF tickets. I use Fixes: to report the ticket\u0027s URL too.","commit_id":"68b761c3df2a0f3256ea97934cd07da1ff9f750f"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"982a52fd96de39783fff5e5eb46acc5043599bd3","unresolved":true,"context_lines":[{"line_number":201,"context_line":""},{"line_number":202,"context_line":"Reported-by: John Reporter \u003crep9876@gmail.com\u003e"},{"line_number":203,"context_line":"Fixes: 123456789abc (target: the commit where the problem started)"},{"line_number":204,"context_line":"Closes-Bug: https://sourceforge.net/p/openocd/tickets/999/"},{"line_number":205,"context_line":"@endcode"},{"line_number":206,"context_line":"@code"},{"line_number":207,"context_line":"doc: fix typos"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"31746470_2c487a95","line":204,"range":{"start_line":204,"start_character":0,"end_line":204,"end_character":10},"in_reply_to":"ada2b8b9_0204a4c7","updated":"2021-11-10 14:57:14.000000000","message":"The new checkpatch allows any field in the header.\nThe length of the line is limited at 75 chars, with the exception of Fixes:, Link:, Signed-off-by:, Co-developed-by:, Acked-by:, Tested-by:, Reviewed-by:, Reported-by:, Suggested-by:, To:, Cc:\nCheckpatch includes the text \"BugLink:\" but this is not listed in kernel documentation. Maybe can be used as generic link to a bug, including a ticket.","commit_id":"68b761c3df2a0f3256ea97934cd07da1ff9f750f"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"cf4cc07b79139ad6e61fd777c119babf2848ec35","unresolved":false,"context_lines":[{"line_number":201,"context_line":"Test for NULL pointer and return error ..."},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"Reported-by: John Reporter \u003crep9876@gmail.com\u003e"},{"line_number":204,"context_line":"Fixes: 123456789abc (\"target: the commit where the problem started\")"},{"line_number":205,"context_line":"BugLink: https://sourceforge.net/p/openocd/tickets/999/"},{"line_number":206,"context_line":"@endcode"},{"line_number":207,"context_line":"@code{.unparsed}"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"479a10ef_f7139163","line":204,"updated":"2022-05-17 13:35:06.000000000","message":"I have put the commit message string within (\"...\") as this would be required by the new checkpatch","commit_id":"03c8824579e95ce19f6d89e3a8121b523215f599"}]}