)]}'
{"id":"openocd~master~I91fa5910670161b62a76fc834b6394c5a6c05395","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2021-11-15 12:32:08.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I91fa5910670161b62a76fc834b6394c5a6c05395","subject":"target/arm_dap: fix memory leak in error path of dap_create()","status":"MERGED","created":"2021-11-10 11:50:11.000000000","updated":"2021-11-20 14:44:38.000000000","submitted":"2021-11-20 14:44:38.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6685","meta_rev_id":"2951ef6ce1320ba997914a3552d662a2bae8b5a6","_number":6685,"owner":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-11-20 14:44:38.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-11-20 14:44:38.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-11-20 14:44:38.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-11-10 12:05:19.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-11-10 15:14:16.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"2d55c4ddd41e65423d049b133dc82e9d4bdd5376","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-11-10 11:50:11.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1b3bd5e97eb729140d203615e1791558881029c7","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-11-10 12:05:19.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15499/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14717/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"b6ee2c682ba74917b2c16288129871a85a9db7be","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-11-10 15:14:16.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"28291ce730ea6e1a6a48fe264333521ddaf8b4a6","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-11-12 11:20:24.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"5cd1eaa08c1bc1d0622376bbd82cca9f9e6fce22","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-11-12 12:39:11.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15525/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14742/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"effb0907990c1f33cf50f5c22ee0ef44f8888775","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-11-12 16:41:31.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"ab24da5d5e10904868a76571c68efa67c2e95619","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-11-15 09:34:46.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.","accounts_in_message":[],"_revision_number":3},{"id":"a013d9fe4195f69edbe3e106b85642afca250d61","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-11-15 09:52:23.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15533/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14751/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"0fce4d04866b37cb8ee6981be591eba7bc4ed255","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-11-15 11:00:41.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"b635372e4412ededb5373f40c15b8e31ffe05f0d","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-11-15 12:32:08.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"2951ef6ce1320ba997914a3552d662a2bae8b5a6","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-11-20 14:44:38.000000000","message":"Change has been successfully cherry-picked as 3eef83e4bd2b112b98d73f8b0947af93c193e0ef","accounts_in_message":[],"_revision_number":4}],"current_revision":"3eef83e4bd2b112b98d73f8b0947af93c193e0ef","revisions":{"6f16f3934918c874633e10da4a4f6ba866982ecd":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2021-11-12 11:20:24.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/85/6685/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/85/6685/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/85/6685/2 \u0026\u0026 git checkout -b change-6685 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/85/6685/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/85/6685/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/85/6685/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/85/6685/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/85/6685/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"428cfd4ec0d34979e8fbbe7d4dc749ea9df1aada","subject":"target/arm_dap: check SWD DAP configuration"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2021-11-10 11:46:42.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2021-11-12 11:19:22.000000000","tz":60},"subject":"target/arm_dap: fix memory leak in error path of dap_create()","message":"target/arm_dap: fix memory leak in error path of dap_create()\n\nChange-Id: I91fa5910670161b62a76fc834b6394c5a6c05395\nSuggested-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"57c679165db31d952ce029202fcf8891c9ae2c4c":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2021-11-15 09:34:46.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/85/6685/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/85/6685/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/85/6685/3 \u0026\u0026 git checkout -b change-6685 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/85/6685/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/85/6685/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/85/6685/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/85/6685/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/85/6685/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a498a3deaaec7ee87d73cf753bdddefaf4779666","subject":"jtagspi: fix build on MacOS"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2021-11-10 11:46:42.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2021-11-15 05:26:08.000000000","tz":60},"subject":"target/arm_dap: fix memory leak in error path of dap_create()","message":"target/arm_dap: fix memory leak in error path of dap_create()\n\nChange-Id: I91fa5910670161b62a76fc834b6394c5a6c05395\nSuggested-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"2938118bca527e7fa2ce1c93039298942b47d943":{"kind":"REWORK","_number":1,"created":"2021-11-10 11:50:11.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/85/6685/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/85/6685/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/85/6685/1 \u0026\u0026 git checkout -b change-6685 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/85/6685/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/85/6685/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/85/6685/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/85/6685/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/85/6685/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"58b4c2b63e5f2290d45c26ab6fb0b10c38796aa4","subject":"target/arm_dap: check SWD DAP configuration"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2021-11-10 11:46:42.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2021-11-10 11:46:42.000000000","tz":60},"subject":"target/arm_dap: fix memory leak in error path of dap_create()","message":"target/arm_dap: fix memory leak in error path of dap_create()\n\nChange-Id: I91fa5910670161b62a76fc834b6394c5a6c05395\nSuggested-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"3eef83e4bd2b112b98d73f8b0947af93c193e0ef":{"kind":"REWORK","_number":4,"created":"2021-11-20 14:44:38.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/85/6685/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/85/6685/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/85/6685/4 \u0026\u0026 git checkout -b change-6685 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/85/6685/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/85/6685/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/85/6685/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/85/6685/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/85/6685/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"08dac883a14aab398922a4e61d55204d7cef644f","subject":"jtag/hla_layout: add #include \u003ctarget/arm_tpiu_swo.h\u003e"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2021-11-10 11:46:42.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-11-20 14:44:38.000000000","tz":0},"subject":"target/arm_dap: fix memory leak in error path of dap_create()","message":"target/arm_dap: fix memory leak in error path of dap_create()\n\nChange-Id: I91fa5910670161b62a76fc834b6394c5a6c05395\nSuggested-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6685\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}