)]}'
{"id":"openocd~master~Ibd1f125475386e5653340fedf706903a0ee15897","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2021-12-03 23:13:07.000000000","reason":"removed on reply"},"1000005":{"account":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"last_update":"2021-11-12 14:09:02.000000000","reason":"removed on reply"},"1001726":{"account":{"_account_id":1001726,"name":"Kevin Burke","email":"kevinb@os.amperecomputing.com","username":"kburke-ampere"},"last_update":"2021-12-11 17:32:10.000000000","reason":"Change was submitted"},"1001661":{"account":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"last_update":"2021-12-11 17:32:10.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ibd1f125475386e5653340fedf706903a0ee15897","subject":"cortex_m: remove last references to debugport_init()","status":"MERGED","created":"2021-11-11 22:59:35.000000000","updated":"2021-12-11 17:32:10.000000000","submitted":"2021-12-11 17:32:10.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6694","meta_rev_id":"b58ce5ff5baf2e22d941ff1132977ea1651bd98e","_number":6694,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-12-11 17:32:10.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-12-11 17:32:10.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1001726,"name":"Kevin Burke","email":"kevinb@os.amperecomputing.com","username":"kburke-ampere"},{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"}],"reviewers":{"REVIEWER":[{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},{"_account_id":1001726,"name":"Kevin Burke","email":"kevinb@os.amperecomputing.com","username":"kburke-ampere"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-11-11 22:59:35.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1001726,"name":"Kevin Burke","email":"kevinb@os.amperecomputing.com","username":"kburke-ampere"},"state":"REVIEWER"},{"updated":"2021-11-11 22:59:35.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"state":"REVIEWER"},{"updated":"2021-11-11 23:08:20.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"state":"REVIEWER"},{"updated":"2021-11-12 01:08:00.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-11-12 06:35:47.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"}],"messages":[{"id":"4e13e46b0587627b3f64304dd48b4973f57ed195","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-11-11 22:59:35.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e23d85a486c12f383429a232807b9d783a9909f5","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-11-11 23:08:20.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"67962bfa548d70575efbf797bed28b396ed99f70","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-11-12 01:08:00.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15513/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14731/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"ccc261663a10e1594bdb9fa7e2cd84101365415b","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-11-12 06:35:47.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"5ed41777e8165684983af6d9119f9903696e33a1","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-11-12 13:45:00.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"176a8a05f983540f3a8eb67ab48a3c9fdf57b1bf","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-11-12 14:01:26.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15527/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14745/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"d7ffe8cedfc5c619833d21af284c5247abffeb0b","author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"real_author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"date":"2021-11-12 14:09:02.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"6065398b8402bb98877a80895ce0e8e0a9daa325","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-12-03 23:05:55.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"973dc256cd4db4d2fdd8da97b5b3553c10f72b36","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-12-03 23:13:07.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"9b521b6487185c2b808804312fe593c9edc74acc","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-12-04 01:31:28.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15681/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14898/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"b58ce5ff5baf2e22d941ff1132977ea1651bd98e","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-12-11 17:32:10.000000000","message":"Change has been successfully cherry-picked as 8a448573fb2804a9abe3e0922648dbbf99224aa9","accounts_in_message":[],"_revision_number":4}],"current_revision":"8a448573fb2804a9abe3e0922648dbbf99224aa9","revisions":{"8a448573fb2804a9abe3e0922648dbbf99224aa9":{"kind":"NO_CODE_CHANGE","_number":4,"created":"2021-12-11 17:32:10.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/94/6694/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/94/6694/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/94/6694/4 \u0026\u0026 git checkout -b change-6694 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/94/6694/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/94/6694/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/94/6694/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/94/6694/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/94/6694/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b1de11616099fe97f3534fa0f268c10dfd6ecf2b","subject":"gdb_server: added and improved several debug prints"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-11-11 22:11:03.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-12-11 17:32:10.000000000","tz":0},"subject":"cortex_m: remove last references to debugport_init()","message":"cortex_m: remove last references to debugport_init()\n\nThe function debugport_init() has never existed in OpenOCD code,\nbut few comments erroneously references it in place of the\nexisting function ahbap_debugport_init().\n\nCommit 00dbc185ee56 (\"arm_adi_v5: Split ahbap_debugport_init\")\nsplits the function ahbap_debugport_init() in dap_dp_init() and\nmem_ap_init(), but did not removed all the incorrect comments\nabout debugport_init(). Few of such comments has been removed in\nlater patches.\n\nRemove the last comment that references debugport_init().\n\nChange-Id: Ibd1f125475386e5653340fedf706903a0ee15897\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6694\nTested-by: jenkins\n"}},"cca703228077b7d96b2c53ffab113782bd4f720c":{"kind":"REWORK","_number":1,"created":"2021-11-11 22:59:35.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/94/6694/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/94/6694/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/94/6694/1 \u0026\u0026 git checkout -b change-6694 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/94/6694/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/94/6694/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/94/6694/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/94/6694/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/94/6694/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"218934db088f4f8c93e719e2de35777b3a4ded01","subject":"ftdi: add support to switch to/from dormant state"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-11-11 22:11:03.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-11-11 22:55:26.000000000","tz":60},"subject":"openocd: remove last references to debugport_init()","message":"openocd: remove last references to debugport_init()\n\nThe function debugport_init() has never existed in OpenOCD code,\nbut few comments erroneously references it in place of the\nexisting function ahbap_debugport_init().\n\nCommit 00dbc185ee56 (\"arm_adi_v5: Split ahbap_debugport_init\")\nsplits the function ahbap_debugport_init() in dap_dp_init() and\nmem_ap_init(), but did not removed all the incorrect comments\nabout debugport_init(). Few of such comments has been removed in\nlater patches.\n\nRemove the last two comments that reference debugport_init().\n\nChange-Id: Ibd1f125475386e5653340fedf706903a0ee15897\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"e1f651779c63fd3bb19f8aab4a747908f0dfaf09":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2021-11-12 13:45:00.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/94/6694/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/94/6694/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/94/6694/2 \u0026\u0026 git checkout -b change-6694 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/94/6694/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/94/6694/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/94/6694/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/94/6694/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/94/6694/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"e2548d9b8a107344e88d7f4b590a099c4e66f7d5","subject":"ftdi: add support to switch to/from dormant state"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-11-11 22:11:03.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-11-12 11:04:18.000000000","tz":60},"subject":"openocd: remove last references to debugport_init()","message":"openocd: remove last references to debugport_init()\n\nThe function debugport_init() has never existed in OpenOCD code,\nbut few comments erroneously references it in place of the\nexisting function ahbap_debugport_init().\n\nCommit 00dbc185ee56 (\"arm_adi_v5: Split ahbap_debugport_init\")\nsplits the function ahbap_debugport_init() in dap_dp_init() and\nmem_ap_init(), but did not removed all the incorrect comments\nabout debugport_init(). Few of such comments has been removed in\nlater patches.\n\nRemove the last two comments that reference debugport_init().\n\nChange-Id: Ibd1f125475386e5653340fedf706903a0ee15897\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"beb96205f3d9efc22218ffa3195bc2a79bfb93d5":{"kind":"REWORK","_number":3,"created":"2021-12-03 23:05:55.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/94/6694/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/94/6694/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/94/6694/3 \u0026\u0026 git checkout -b change-6694 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/94/6694/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/94/6694/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/94/6694/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/94/6694/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/94/6694/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b1de11616099fe97f3534fa0f268c10dfd6ecf2b","subject":"gdb_server: added and improved several debug prints"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-11-11 22:11:03.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-12-03 22:59:50.000000000","tz":60},"subject":"cortex_m: remove last references to debugport_init()","message":"cortex_m: remove last references to debugport_init()\n\nThe function debugport_init() has never existed in OpenOCD code,\nbut few comments erroneously references it in place of the\nexisting function ahbap_debugport_init().\n\nCommit 00dbc185ee56 (\"arm_adi_v5: Split ahbap_debugport_init\")\nsplits the function ahbap_debugport_init() in dap_dp_init() and\nmem_ap_init(), but did not removed all the incorrect comments\nabout debugport_init(). Few of such comments has been removed in\nlater patches.\n\nRemove the last comment that references debugport_init().\n\nChange-Id: Ibd1f125475386e5653340fedf706903a0ee15897\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}