)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"2bbfcc41084eb55c518aa789342d35996b5852c1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d4ef8804_155faa1f","updated":"2021-11-12 13:27:33.000000000","message":"Thanks for the review","commit_id":"db1e841092bfdc1104e6924ec1633110c28ec78f"},{"author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"change_message_id":"63cdf57be9b511cb6e9d686175a63f329883ebdf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4f40c35a_73cde026","updated":"2021-11-12 14:07:29.000000000","message":"Looks good, haven\u0027t tested on any targets","commit_id":"ef3a3da205d538ff0551de098e1bf055b4da2197"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"ad657839a382b856306d39312112f762d4fc0b21","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"bd0670b7_0a6cfae3","updated":"2021-11-13 11:31:32.000000000","message":"cannot be merged now, due to silly dependence from the other in adiv6 series.\nPlus will conflict with swd multidrop.\nLet\u0027s wait a little...","commit_id":"ef3a3da205d538ff0551de098e1bf055b4da2197"}],"src/target/adi_v5_swd.c":[{"author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"change_message_id":"c2baf81aa11813ecae50763463650e5e770a00f0","unresolved":true,"context_lines":[{"line_number":121,"context_line":""},{"line_number":122,"context_line":"\tint64_t timeout \u003d timeval_ms() + 500;"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"\tdap-\u003ejtag_to_swd_through_dormant \u003d false;"},{"line_number":125,"context_line":"\tdo {"},{"line_number":126,"context_line":"\t\tif (dap-\u003ejtag_to_swd_through_dormant) {"},{"line_number":127,"context_line":"\t\t\tswd-\u003eswitch_seq(JTAG_TO_DORMANT);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"d2e95948_a6c15f61","line":124,"updated":"2021-11-12 13:12:22.000000000","message":"Any need to flip back to false for the first attempt? The last to succeed will probably work again for the same target. (IIRC swd_connect may still be called multiple times and not only on the very first comm with the target?)","commit_id":"db1e841092bfdc1104e6924ec1633110c28ec78f"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"2bbfcc41084eb55c518aa789342d35996b5852c1","unresolved":false,"context_lines":[{"line_number":121,"context_line":""},{"line_number":122,"context_line":"\tint64_t timeout \u003d timeval_ms() + 500;"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"\tdap-\u003ejtag_to_swd_through_dormant \u003d false;"},{"line_number":125,"context_line":"\tdo {"},{"line_number":126,"context_line":"\t\tif (dap-\u003ejtag_to_swd_through_dormant) {"},{"line_number":127,"context_line":"\t\t\tswd-\u003eswitch_seq(JTAG_TO_DORMANT);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"2734795a_7cf94075","line":124,"in_reply_to":"d2e95948_a6c15f61","updated":"2021-11-12 13:27:33.000000000","message":"You are right, this is called in case of reconnect. Will fix it","commit_id":"db1e841092bfdc1104e6924ec1633110c28ec78f"},{"author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"change_message_id":"c2baf81aa11813ecae50763463650e5e770a00f0","unresolved":true,"context_lines":[{"line_number":386,"context_line":"{"},{"line_number":387,"context_line":"\tconst struct swd_driver *swd \u003d adiv5_dap_swd_driver(dap);"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"\tif (dap-\u003ejtag_to_swd_through_dormant) {"},{"line_number":390,"context_line":"\t\tswd-\u003eswitch_seq(SWD_TO_DORMANT);"},{"line_number":391,"context_line":"\t\tswd-\u003eswitch_seq(DORMANT_TO_JTAG);"},{"line_number":392,"context_line":"\t} else {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"8246ec51_21b4e081","line":389,"updated":"2021-11-12 13:12:22.000000000","message":"Looks suspicious to check this condition when the switch is in the opposite direction. Maybe call the flag by a more generic name, switch_through_dormant perhaps?","commit_id":"db1e841092bfdc1104e6924ec1633110c28ec78f"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"2bbfcc41084eb55c518aa789342d35996b5852c1","unresolved":false,"context_lines":[{"line_number":386,"context_line":"{"},{"line_number":387,"context_line":"\tconst struct swd_driver *swd \u003d adiv5_dap_swd_driver(dap);"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"\tif (dap-\u003ejtag_to_swd_through_dormant) {"},{"line_number":390,"context_line":"\t\tswd-\u003eswitch_seq(SWD_TO_DORMANT);"},{"line_number":391,"context_line":"\t\tswd-\u003eswitch_seq(DORMANT_TO_JTAG);"},{"line_number":392,"context_line":"\t} else {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"6aa73fdf_12b591e2","line":389,"in_reply_to":"8246ec51_21b4e081","updated":"2021-11-12 13:27:33.000000000","message":"Ack","commit_id":"db1e841092bfdc1104e6924ec1633110c28ec78f"}]}