)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"6af539a381a5db6505b77715a82faf0948c3550d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7511d672_8aa2cd8a","updated":"2021-11-12 11:30:48.000000000","message":"This is the rest what is not in https://review.openocd.org/c/openocd/+/6693","commit_id":"23e5d70629519aba6ddc6b185ca7a39f537c4fdb"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"594a2233987f46c2a27a93c288170485b34acea6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"010d4e10_e1e3e78c","updated":"2021-11-12 17:29:00.000000000","message":"Will ","commit_id":"23e5d70629519aba6ddc6b185ca7a39f537c4fdb"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"05f029b95a356ae49eff7a3649649e31f9867b44","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5d58d5b6_2beb38d5","updated":"2021-11-12 16:46:51.000000000","message":"minor issues","commit_id":"23e5d70629519aba6ddc6b185ca7a39f537c4fdb"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"50058eb5d41f3ee173f095b23714302b56844733","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e590c174_1c6ed382","updated":"2021-11-12 21:02:30.000000000","message":"I think that this kind of fix would be required in ","commit_id":"9987d4b6b041739b83a6ec53ea0f53444bb28d4b"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"eaae77359e6762aac5c611a4fe6415172cb89b68","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d4176f4e_c2d9d7b4","updated":"2021-11-15 09:41:20.000000000","message":"Rebase under the core multidrop patches","commit_id":"ac326fed2359cfac8359585b99713d57307e7df3"}],"src/jtag/drivers/ftdi.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"05f029b95a356ae49eff7a3649649e31f9867b44","unresolved":true,"context_lines":[{"line_number":1121,"context_line":"\tfor (size_t i \u003d 0; i \u003c swd_cmd_queue_length; i++) {"},{"line_number":1122,"context_line":"\t\tint ack \u003d buf_get_u32(swd_cmd_queue[i].trn_ack_data_parity_trn, 1, 3);"},{"line_number":1123,"context_line":""},{"line_number":1124,"context_line":"\t\tuint8_t base_cmd \u003d swd_cmd_queue[i].cmd \u0026 (SWD_CMD_APNDP|SWD_CMD_RNW|SWD_CMD_A32);"},{"line_number":1125,"context_line":"\t\t/* Devices do not reply to DP_TARGETSEL write cmd, ignore received ack */"},{"line_number":1126,"context_line":"\t\tbool ignore_ack \u003d base_cmd \u003d\u003d swd_cmd(false, false, DP_TARGETSEL);"},{"line_number":1127,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"47742583_678a30b6","line":1124,"updated":"2021-11-12 16:46:51.000000000","message":"add space around the \u0027|\u0027 operator","commit_id":"23e5d70629519aba6ddc6b185ca7a39f537c4fdb"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"594a2233987f46c2a27a93c288170485b34acea6","unresolved":false,"context_lines":[{"line_number":1121,"context_line":"\tfor (size_t i \u003d 0; i \u003c swd_cmd_queue_length; i++) {"},{"line_number":1122,"context_line":"\t\tint ack \u003d buf_get_u32(swd_cmd_queue[i].trn_ack_data_parity_trn, 1, 3);"},{"line_number":1123,"context_line":""},{"line_number":1124,"context_line":"\t\tuint8_t base_cmd \u003d swd_cmd_queue[i].cmd \u0026 (SWD_CMD_APNDP|SWD_CMD_RNW|SWD_CMD_A32);"},{"line_number":1125,"context_line":"\t\t/* Devices do not reply to DP_TARGETSEL write cmd, ignore received ack */"},{"line_number":1126,"context_line":"\t\tbool ignore_ack \u003d base_cmd \u003d\u003d swd_cmd(false, false, DP_TARGETSEL);"},{"line_number":1127,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"a113ca05_22d8e76a","line":1124,"in_reply_to":"47742583_678a30b6","updated":"2021-11-12 17:29:00.000000000","message":"Ack.\nYou see the new checkpatch needs more priority.","commit_id":"23e5d70629519aba6ddc6b185ca7a39f537c4fdb"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"05f029b95a356ae49eff7a3649649e31f9867b44","unresolved":true,"context_lines":[{"line_number":1123,"context_line":""},{"line_number":1124,"context_line":"\t\tuint8_t base_cmd \u003d swd_cmd_queue[i].cmd \u0026 (SWD_CMD_APNDP|SWD_CMD_RNW|SWD_CMD_A32);"},{"line_number":1125,"context_line":"\t\t/* Devices do not reply to DP_TARGETSEL write cmd, ignore received ack */"},{"line_number":1126,"context_line":"\t\tbool ignore_ack \u003d base_cmd \u003d\u003d swd_cmd(false, false, DP_TARGETSEL);"},{"line_number":1127,"context_line":""},{"line_number":1128,"context_line":"\t\tLOG_DEBUG_IO(\"%s%s %s %s reg %X \u003d %08\"PRIx32,"},{"line_number":1129,"context_line":"\t\t\t\tignore_ack ? \"ack ignored \" : \"\","}],"source_content_type":"text/x-csrc","patch_set":1,"id":"72803070_39cfd1c2","line":1126,"updated":"2021-11-12 16:46:51.000000000","message":"to avoid it could get confused wit a multiple assignment, use parenthesis\nbool ignore_ack \u003d (... \u003d\u003d ...);","commit_id":"23e5d70629519aba6ddc6b185ca7a39f537c4fdb"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"594a2233987f46c2a27a93c288170485b34acea6","unresolved":false,"context_lines":[{"line_number":1123,"context_line":""},{"line_number":1124,"context_line":"\t\tuint8_t base_cmd \u003d swd_cmd_queue[i].cmd \u0026 (SWD_CMD_APNDP|SWD_CMD_RNW|SWD_CMD_A32);"},{"line_number":1125,"context_line":"\t\t/* Devices do not reply to DP_TARGETSEL write cmd, ignore received ack */"},{"line_number":1126,"context_line":"\t\tbool ignore_ack \u003d base_cmd \u003d\u003d swd_cmd(false, false, DP_TARGETSEL);"},{"line_number":1127,"context_line":""},{"line_number":1128,"context_line":"\t\tLOG_DEBUG_IO(\"%s%s %s %s reg %X \u003d %08\"PRIx32,"},{"line_number":1129,"context_line":"\t\t\t\tignore_ack ? \"ack ignored \" : \"\","}],"source_content_type":"text/x-csrc","patch_set":1,"id":"f7aae884_fd4433c5","line":1126,"in_reply_to":"72803070_39cfd1c2","updated":"2021-11-12 17:29:00.000000000","message":"Ack.\nIs is from the new checkpatch or from you personally?","commit_id":"23e5d70629519aba6ddc6b185ca7a39f537c4fdb"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"50058eb5d41f3ee173f095b23714302b56844733","unresolved":false,"context_lines":[{"line_number":1123,"context_line":""},{"line_number":1124,"context_line":"\t\tuint8_t base_cmd \u003d swd_cmd_queue[i].cmd \u0026 (SWD_CMD_APNDP|SWD_CMD_RNW|SWD_CMD_A32);"},{"line_number":1125,"context_line":"\t\t/* Devices do not reply to DP_TARGETSEL write cmd, ignore received ack */"},{"line_number":1126,"context_line":"\t\tbool ignore_ack \u003d base_cmd \u003d\u003d swd_cmd(false, false, DP_TARGETSEL);"},{"line_number":1127,"context_line":""},{"line_number":1128,"context_line":"\t\tLOG_DEBUG_IO(\"%s%s %s %s reg %X \u003d %08\"PRIx32,"},{"line_number":1129,"context_line":"\t\t\t\tignore_ack ? \"ack ignored \" : \"\","}],"source_content_type":"text/x-csrc","patch_set":1,"id":"1a05413a_ba44e4dc","line":1126,"in_reply_to":"f7aae884_fd4433c5","updated":"2021-11-12 21:02:30.000000000","message":"personal check\nI run manually the new checkpatch only on big or suspicious patches.","commit_id":"23e5d70629519aba6ddc6b185ca7a39f537c4fdb"}]}