)]}'
{"id":"openocd~master~I04fd77cde3244de250743d8c8bfb93ed26379385","project":"openocd","branch":"master","topic":"swd multidrop","attention_set":{},"removed_from_attention_set":{"1001632":{"account":{"_account_id":1001632,"name":"Graham Sanderson","email":"graham.sanderson@gmail.com","username":"graham.sanderson"},"last_update":"2021-11-20 14:45:06.000000000","reason":"Change was submitted"},"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2021-11-12 21:02:30.000000000","reason":"Antonio Borneo replied on the change"},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2021-11-15 12:32:25.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I04fd77cde3244de250743d8c8bfb93ed26379385","subject":"drivers/ftdi: add support for SWD multidrop","status":"MERGED","created":"2021-11-12 11:20:24.000000000","updated":"2021-11-20 14:45:06.000000000","submitted":"2021-11-20 14:45:06.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":10,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6698-swd multidrop","meta_rev_id":"60a1d0451c53fab010e0552db67202dcd4f2bdbd","_number":6698,"owner":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-11-20 14:45:06.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-11-20 14:45:06.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-11-20 14:45:06.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1001632,"name":"Graham Sanderson","email":"graham.sanderson@gmail.com","username":"graham.sanderson"}],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"_account_id":1001632,"name":"Graham Sanderson","email":"graham.sanderson@gmail.com","username":"graham.sanderson"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-11-12 11:30:48.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"},{"updated":"2021-11-12 11:30:48.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1001632,"name":"Graham Sanderson","email":"graham.sanderson@gmail.com","username":"graham.sanderson"},"state":"REVIEWER"},{"updated":"2021-11-12 13:01:55.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"2510bdebc756534c843579ba9cbfc1652eb4a97d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-11-12 11:20:24.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7d9b5765f2e6543d05d3070b08b9445d830027ae","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-11-12 11:29:34.000000000","message":"Topic set to swd multidrop","accounts_in_message":[],"_revision_number":1},{"id":"6af539a381a5db6505b77715a82faf0948c3550d","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-11-12 11:30:48.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"0d95d83fe3ba2146e5af2c39344882cdf2b75789","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-11-12 13:01:55.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15526/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14744/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"05f029b95a356ae49eff7a3649649e31f9867b44","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-11-12 16:46:51.000000000","message":"Patch Set 1:\n\n(3 comments)","accounts_in_message":[],"_revision_number":1},{"id":"594a2233987f46c2a27a93c288170485b34acea6","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-11-12 17:29:00.000000000","message":"Patch Set 1:\n\n(3 comments)","accounts_in_message":[],"_revision_number":1},{"id":"13fa3b0b3e64bf322fbee8967ed299258da67e9d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-11-12 20:10:10.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"44ec9b131137a42995448d1c1c50fda551c40db7","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-11-12 20:29:57.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15529/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14747/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"50058eb5d41f3ee173f095b23714302b56844733","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-11-12 21:02:30.000000000","message":"Patch Set 2: Code-Review+1\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"fe24841e63f753aa11d5b7cfd13e5e823ea6127a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-11-15 09:34:46.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"eaae77359e6762aac5c611a4fe6415172cb89b68","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-11-15 09:41:20.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"b63b522082b6bdce1f16ad0b27da97306f188017","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-11-15 10:08:14.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15534/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14752/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"72fc506ec05d40b48950eb5dd9af7d25e5724c16","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-11-15 11:01:11.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"c28f9d6d191b42fede758b398cb43b267fe3ff3f","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-11-15 12:32:25.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"60a1d0451c53fab010e0552db67202dcd4f2bdbd","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-11-20 14:45:06.000000000","message":"Change has been successfully cherry-picked as d569b9bd68c9ffb4ee464eb5a40cf2839663965b","accounts_in_message":[],"_revision_number":4}],"current_revision":"d569b9bd68c9ffb4ee464eb5a40cf2839663965b","revisions":{"d569b9bd68c9ffb4ee464eb5a40cf2839663965b":{"kind":"REWORK","_number":4,"created":"2021-11-20 14:45:06.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/98/6698/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/98/6698/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/98/6698/4 \u0026\u0026 git checkout -b change-6698 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/98/6698/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/98/6698/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/98/6698/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/98/6698/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/98/6698/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"872682345af6e26af145c76d5a4373b16d815b7e","subject":"drivers/swd: add support for SWD multidrop"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2021-11-12 13:14:32.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-11-20 14:45:06.000000000","tz":0},"subject":"drivers/ftdi: add support for SWD multidrop","message":"drivers/ftdi: add support for SWD multidrop\n\nIgnore ack received after DP_TARGETSEL write to prevent false error.\n\nInspired by Graham Sanderson\u0027s http://review.openocd.org/4935\n\nChange-Id: I04fd77cde3244de250743d8c8bfb93ed26379385\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6698\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"23e5d70629519aba6ddc6b185ca7a39f537c4fdb":{"kind":"REWORK","_number":1,"created":"2021-11-12 11:20:24.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/98/6698/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/98/6698/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/98/6698/1 \u0026\u0026 git checkout -b change-6698 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/98/6698/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/98/6698/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/98/6698/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/98/6698/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/98/6698/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"6f16f3934918c874633e10da4a4f6ba866982ecd","subject":"target/arm_dap: fix memory leak in error path of dap_create()"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2021-11-12 08:49:01.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2021-11-12 11:19:22.000000000","tz":60},"subject":"drivers/ftdi: add support for SWD multidrop","message":"drivers/ftdi: add support for SWD multidrop\n\nAccording to ARM IHI0031C+ chapter 2.3.11 \"TARGETSEL, Target Selection register\"\nmultidrop capable DPv2 must not drive SWDIO line during the response phase of a write\nto TARGETSEL register.\n\nIgnore ack received after DP_TARGETSEL write to prevent false error.\n\nInspired by Graham Sanderson\u0027s http://openocd.zylin.com/4935\n\nChange-Id: I04fd77cde3244de250743d8c8bfb93ed26379385\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"ac326fed2359cfac8359585b99713d57307e7df3":{"kind":"REWORK","_number":3,"created":"2021-11-15 09:34:46.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/98/6698/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/98/6698/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/98/6698/3 \u0026\u0026 git checkout -b change-6698 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/98/6698/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/98/6698/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/98/6698/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/98/6698/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/98/6698/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"bf2500317a734efd27f10a87717f44bb16edaf90","subject":"drivers/swd: add support for SWD multidrop"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2021-11-12 13:14:32.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2021-11-15 05:48:13.000000000","tz":60},"subject":"drivers/ftdi: add support for SWD multidrop","message":"drivers/ftdi: add support for SWD multidrop\n\nIgnore ack received after DP_TARGETSEL write to prevent false error.\n\nInspired by Graham Sanderson\u0027s http://review.openocd.org/4935\n\nChange-Id: I04fd77cde3244de250743d8c8bfb93ed26379385\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"9987d4b6b041739b83a6ec53ea0f53444bb28d4b":{"kind":"REWORK","_number":2,"created":"2021-11-12 20:10:10.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/98/6698/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/98/6698/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/98/6698/2 \u0026\u0026 git checkout -b change-6698 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/98/6698/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/98/6698/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/98/6698/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/98/6698/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/98/6698/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"44b2b27e3daf0fc0283ec6161880e6ffae87a7f8","subject":"drivers/swd: add support for SWD multidrop"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2021-11-12 13:14:32.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2021-11-12 18:21:22.000000000","tz":60},"subject":"drivers/ftdi: add support for SWD multidrop","message":"drivers/ftdi: add support for SWD multidrop\n\nIgnore ack received after DP_TARGETSEL write to prevent false error.\n\nInspired by Graham Sanderson\u0027s http://openocd.zylin.com/4935\n\nChange-Id: I04fd77cde3244de250743d8c8bfb93ed26379385\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}