)]}'
{"id":"openocd~master~Ie5f9edb22e066a933a534bf2b29e7e1d3087dad1","project":"openocd","branch":"master","topic":"swd multidrop","attention_set":{},"removed_from_attention_set":{"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2021-11-15 12:32:17.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"Ie5f9edb22e066a933a534bf2b29e7e1d3087dad1","subject":"drivers/swd: add support for SWD multidrop","status":"MERGED","created":"2021-11-12 20:10:10.000000000","updated":"2021-11-20 14:44:54.000000000","submitted":"2021-11-20 14:44:54.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6699-swd multidrop","meta_rev_id":"fef0b708689992e39edf4be137e398fdf67f48e2","_number":6699,"owner":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-11-20 14:44:54.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-11-20 14:44:54.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-11-20 14:44:54.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-11-12 20:41:56.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-11-12 21:02:52.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"f2204e3a486ab3e9cff0e800d2bff8374ca39eef","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-11-12 20:10:10.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2595cab7e7c6c202df207cc3ccaf245cc13424f8","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-11-12 20:21:17.000000000","message":"Topic set to swd multidrop","accounts_in_message":[],"_revision_number":1},{"id":"2f9b7086409a38ea07c18738ae5664a6ac1a7ddb","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-11-12 20:41:56.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15530/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14748/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"84348a8bb0f6b05c60327a474f4bcd2a6c37a6e7","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-11-12 21:02:52.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"6bf3d8002d71f0e6c4714075db61042ee761ac5f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-11-15 09:34:46.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"742af7d9119f926d277966dbf63e2e599f162dd5","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-11-15 09:38:15.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"fb70845c311abf5078850cd85c3ed78d067b9037","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-11-15 11:00:57.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"b5c282af961a4ad247dcdc36dec5d1ef8b370583","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-11-15 11:24:48.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15535/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14757/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"ea0205a1068cc0f890f082a74d9a38bb4ceaf947","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-11-15 12:32:17.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"fef0b708689992e39edf4be137e398fdf67f48e2","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-11-20 14:44:54.000000000","message":"Change has been successfully cherry-picked as 872682345af6e26af145c76d5a4373b16d815b7e","accounts_in_message":[],"_revision_number":3}],"current_revision":"872682345af6e26af145c76d5a4373b16d815b7e","revisions":{"872682345af6e26af145c76d5a4373b16d815b7e":{"kind":"REWORK","_number":3,"created":"2021-11-20 14:44:54.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/99/6699/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/99/6699/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/99/6699/3 \u0026\u0026 git checkout -b change-6699 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/99/6699/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/99/6699/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/99/6699/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/99/6699/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/99/6699/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3eef83e4bd2b112b98d73f8b0947af93c193e0ef","subject":"target/arm_dap: fix memory leak in error path of dap_create()"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2021-11-12 08:49:01.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-11-20 14:44:54.000000000","tz":0},"subject":"drivers/swd: add support for SWD multidrop","message":"drivers/swd: add support for SWD multidrop\n\nAccording to ARM IHI0031C+ chapter 2.3.11 \"TARGETSEL, Target Selection register\"\nmultidrop capable DPv2 must not drive SWDIO line during the response phase\nof a write to TARGETSEL register.\n\nIntroduce helper functions swd_cmd_returns_ack() and swd_ack_to_error_code()\nto centralize these tests from all drivers to one place.\n\nIntroduce distinct error codes for SWD protocol.\n\nPartly inspired by Graham Sanderson\u0027s http://review.openocd.org/4935\n\nChange-Id: Ie5f9edb22e066a933a534bf2b29e7e1d3087dad1\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6699\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nTested-by: jenkins\n"}},"bf2500317a734efd27f10a87717f44bb16edaf90":{"kind":"REWORK","_number":2,"created":"2021-11-15 09:34:46.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/99/6699/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/99/6699/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/99/6699/2 \u0026\u0026 git checkout -b change-6699 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/99/6699/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/99/6699/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/99/6699/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/99/6699/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/99/6699/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"57c679165db31d952ce029202fcf8891c9ae2c4c","subject":"target/arm_dap: fix memory leak in error path of dap_create()"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2021-11-12 08:49:01.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2021-11-15 05:46:59.000000000","tz":60},"subject":"drivers/swd: add support for SWD multidrop","message":"drivers/swd: add support for SWD multidrop\n\nAccording to ARM IHI0031C+ chapter 2.3.11 \"TARGETSEL, Target Selection register\"\nmultidrop capable DPv2 must not drive SWDIO line during the response phase\nof a write to TARGETSEL register.\n\nIntroduce helper functions swd_cmd_returns_ack() and swd_ack_to_error_code()\nto centralize these tests from all drivers to one place.\n\nIntroduce distinct error codes for SWD protocol.\n\nPartly inspired by Graham Sanderson\u0027s http://review.openocd.org/4935\n\nChange-Id: Ie5f9edb22e066a933a534bf2b29e7e1d3087dad1\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"44b2b27e3daf0fc0283ec6161880e6ffae87a7f8":{"kind":"REWORK","_number":1,"created":"2021-11-12 20:10:10.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/99/6699/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/99/6699/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/99/6699/1 \u0026\u0026 git checkout -b change-6699 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/99/6699/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/99/6699/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/99/6699/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/99/6699/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/99/6699/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"6f16f3934918c874633e10da4a4f6ba866982ecd","subject":"target/arm_dap: fix memory leak in error path of dap_create()"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2021-11-12 08:49:01.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2021-11-12 18:17:28.000000000","tz":60},"subject":"drivers/swd: add support for SWD multidrop","message":"drivers/swd: add support for SWD multidrop\n\nAccording to ARM IHI0031C+ chapter 2.3.11 \"TARGETSEL, Target Selection register\"\nmultidrop capable DPv2 must not drive SWDIO line during the response phase\nof a write to TARGETSEL register.\n\nIntroduce helper functions swd_cmd_returns_ack() and swd_ack_to_error_code()\nto centralize these tests from all drivers to one place.\n\nIntroduce distinct error codes for SWD protocol.\n\nPartly inspired by Graham Sanderson\u0027s http://openocd.zylin.com/4935\n\nChange-Id: Ie5f9edb22e066a933a534bf2b29e7e1d3087dad1\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}