)]}'
{"id":"openocd~master~I5ff1f658f221af78d8bbec8416a7a0fc64ba2550","project":"openocd","branch":"master","topic":"swd multidrop","attention_set":{},"removed_from_attention_set":{"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2021-11-15 12:32:30.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I5ff1f658f221af78d8bbec8416a7a0fc64ba2550","subject":"drivers/bitbang: add support for SWD multidrop","status":"MERGED","created":"2021-11-12 20:10:10.000000000","updated":"2021-11-20 14:45:18.000000000","submitted":"2021-11-20 14:45:18.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6700-swd multidrop","meta_rev_id":"8af9f457ff8ea3461fd7961ca0da4eec7f212d3d","_number":6700,"owner":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-11-20 14:45:18.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-11-20 14:45:18.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-11-20 14:45:18.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-11-12 20:19:37.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2021-11-12 20:52:37.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-11-12 21:08:50.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"42772b1942446c867a8a75af7c675ed6565e07d3","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-11-12 20:10:10.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2a123e55b45faf2a297ca9943c53eef8e8c27a00","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-11-12 20:19:12.000000000","message":"Patch Set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"3ac362d041d59a39d0d3ed4d1752b1078961262a","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-11-12 20:19:37.000000000","message":"Patch Set 1:\n\nNo Builds Executed","accounts_in_message":[],"_revision_number":1},{"id":"bb88c6d89f7ea3d5d73ade198f348ca310b3bd56","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-11-12 20:21:30.000000000","message":"Topic set to swd multidrop","accounts_in_message":[],"_revision_number":2},{"id":"784667c4dd71373633230815142e53c7114047b2","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-11-12 20:23:59.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"9349dc0022ff597f3081c09db9e8ed147d8e343a","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-11-12 20:52:37.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15531/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14749/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"e51aa769913d63073bb64879e91b815b7b52085b","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-11-12 21:08:50.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"b1b0126c18bdd04f5c4ff0a98b24dfc096c9798b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-11-15 09:34:46.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"a57ec4657ea6f5807d120b3ffb43db2137d1c898","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-11-15 09:41:33.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"88ff25adc80e902e6c053bc807e63d4d2693c311","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-11-15 10:23:28.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15536/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14753/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"e10cff54367e3efe949f48cc853252c3286f4d82","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-11-15 11:01:21.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"bbdeba3b5cb5ebd3aa851f833a70e29bf786381f","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-11-15 12:32:30.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"8af9f457ff8ea3461fd7961ca0da4eec7f212d3d","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-11-20 14:45:18.000000000","message":"Change has been successfully cherry-picked as 9dd39a33e6dbd9d95b5bcfde4b41c498841a27a1","accounts_in_message":[],"_revision_number":4}],"current_revision":"9dd39a33e6dbd9d95b5bcfde4b41c498841a27a1","revisions":{"9dd39a33e6dbd9d95b5bcfde4b41c498841a27a1":{"kind":"REWORK","_number":4,"created":"2021-11-20 14:45:18.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/00/6700/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/00/6700/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/00/6700/4 \u0026\u0026 git checkout -b change-6700 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/00/6700/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/00/6700/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/00/6700/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/00/6700/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/00/6700/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d569b9bd68c9ffb4ee464eb5a40cf2839663965b","subject":"drivers/ftdi: add support for SWD multidrop"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2021-11-12 14:28:30.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-11-20 14:45:18.000000000","tz":0},"subject":"drivers/bitbang: add support for SWD multidrop","message":"drivers/bitbang: add support for SWD multidrop\n\nIgnore ack received after DP_TARGETSEL write to prevent false error.\n\nThis change also fixes a bug:\nReceived ACK FAULT or JUNK value were incorrectly stored to queued_retval\nand later used as bitbang_swd_run_queue() error return.\n\nUse LOG_ERROR for parity mismatch.\n\nChange-Id: I5ff1f658f221af78d8bbec8416a7a0fc64ba2550\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6700\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"5a247edf638d86ac62f239c9f9983c0944ea1ad0":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2021-11-12 20:19:12.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/00/6700/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/00/6700/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/00/6700/2 \u0026\u0026 git checkout -b change-6700 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/00/6700/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/00/6700/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/00/6700/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/00/6700/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/00/6700/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9987d4b6b041739b83a6ec53ea0f53444bb28d4b","subject":"drivers/ftdi: add support for SWD multidrop"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2021-11-12 14:28:30.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2021-11-12 20:19:12.000000000","tz":0},"subject":"drivers/bitbang: add support for SWD multidrop","message":"drivers/bitbang: add support for SWD multidrop\n\nIgnore ack received after DP_TARGETSEL write to prevent false error.\n\nThis change also fixes a bug:\nReceived ACK FAULT or JUNK value was incorrectly stored to queued_retval\nand later used as bitbang_swd_run_queue() error return.\n\nUse LOG_ERROR for parity mismatch.\n\nChange-Id: I5ff1f658f221af78d8bbec8416a7a0fc64ba2550\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"},"description":"Edit commit message"},"a7924b9a4051a78daeeedd773bb8b19c4f363edf":{"kind":"REWORK","_number":3,"created":"2021-11-15 09:34:46.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/00/6700/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/00/6700/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/00/6700/3 \u0026\u0026 git checkout -b change-6700 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/00/6700/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/00/6700/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/00/6700/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/00/6700/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/00/6700/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ac326fed2359cfac8359585b99713d57307e7df3","subject":"drivers/ftdi: add support for SWD multidrop"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2021-11-12 14:28:30.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2021-11-15 05:48:44.000000000","tz":60},"subject":"drivers/bitbang: add support for SWD multidrop","message":"drivers/bitbang: add support for SWD multidrop\n\nIgnore ack received after DP_TARGETSEL write to prevent false error.\n\nThis change also fixes a bug:\nReceived ACK FAULT or JUNK value were incorrectly stored to queued_retval\nand later used as bitbang_swd_run_queue() error return.\n\nUse LOG_ERROR for parity mismatch.\n\nChange-Id: I5ff1f658f221af78d8bbec8416a7a0fc64ba2550\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"e152c925c6e2ee0d84fd079760ac40a7bc52475d":{"kind":"REWORK","_number":1,"created":"2021-11-12 20:10:10.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/00/6700/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/00/6700/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/00/6700/1 \u0026\u0026 git checkout -b change-6700 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/00/6700/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/00/6700/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/00/6700/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/00/6700/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/00/6700/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9987d4b6b041739b83a6ec53ea0f53444bb28d4b","subject":"drivers/ftdi: add support for SWD multidrop"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2021-11-12 14:28:30.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2021-11-12 19:03:43.000000000","tz":60},"subject":"drivers/bitbang: add support for SWD multidrop","message":"drivers/bitbang: add support for SWD multidrop\n\nIgnore ack received after DP_TARGETSEL write to prevent false error.\n\nThis change also fixes a bug:\nReceived ACK FAULT or JUNK value were incorrectly stored to queued_retval\nand later used as bitbang_swd_run_queue() error return.\n\nUse LOG_ERROR for parity mismatch.\n\nChange-Id: I5ff1f658f221af78d8bbec8416a7a0fc64ba2550\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}