)]}'
{"id":"openocd~master~Ia86eadb4e960ce54e8581630d01af75720d2318d","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1001013":{"account":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"last_update":"2021-11-19 09:14:27.000000000","reason":"Matthias Welwarsky replied on the change"},"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2021-11-19 09:06:14.000000000","reason":"Antonio Borneo replied on the change"},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2021-11-20 14:45:54.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ia86eadb4e960ce54e8581630d01af75720d2318d","subject":"target/arm_dap: clean up dap_configure code","status":"MERGED","created":"2021-11-15 15:30:30.000000000","updated":"2021-11-20 14:45:54.000000000","submitted":"2021-11-20 14:45:54.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6702","meta_rev_id":"940f22ca0065d54a71e165327656f83081b1b417","_number":6702,"owner":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-11-20 14:45:54.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-11-20 14:45:54.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-11-20 14:45:54.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-11-15 15:32:49.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"state":"REVIEWER"},{"updated":"2021-11-15 17:46:08.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-11-19 06:39:14.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"9f046570b42db478bac3c1245d106ddd050a91a8","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-11-15 15:30:30.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"77b63bbf4e31af6efc1dcb42ab8f1b0e9eeff721","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-11-15 17:46:08.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15544/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14762/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"ce0da2c43a6da452b96c2f34571f034eea5cb2be","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-11-19 09:06:14.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"96817d10e7e97b4550aa51f9356682ee6cde3ee7","author":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"real_author":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"},"date":"2021-11-19 09:14:27.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"940f22ca0065d54a71e165327656f83081b1b417","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-11-20 14:45:54.000000000","message":"Change has been successfully cherry-picked as bb78fa10c77411bbdf665c17eac954b7741f2040","accounts_in_message":[],"_revision_number":2}],"current_revision":"bb78fa10c77411bbdf665c17eac954b7741f2040","revisions":{"bb78fa10c77411bbdf665c17eac954b7741f2040":{"kind":"REWORK","_number":2,"created":"2021-11-20 14:45:54.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/02/6702/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/02/6702/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/02/6702/2 \u0026\u0026 git checkout -b change-6702 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/02/6702/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/02/6702/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/02/6702/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/02/6702/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/02/6702/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"81afe6e3fdb1253659d7d5a1be9f4f444c2c18d5","subject":"target/adi_v5_swd: introduce swd_queue_dp_read/write_inner()"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2021-11-15 14:32:39.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-11-20 14:45:54.000000000","tz":0},"subject":"target/arm_dap: clean up dap_configure code","message":"target/arm_dap: clean up dap_configure code\n\ndap_configure() contained first time init related tasks, as the call to\ndap_init_instance() and the check for configured tap.\n\nMove all first time init related stuff to dap_create() to make dap_configure()\nusable in eventual stand-alone \u0027dap configure\u0027 command.\n\nChange-Id: Ia86eadb4e960ce54e8581630d01af75720d2318d\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6702\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-by: Matthias Welwarsky \u003cmatthias@welwarsky.de\u003e\n"}},"089cc06294713c2cc2486eeb7befca31af931639":{"kind":"REWORK","_number":1,"created":"2021-11-15 15:30:30.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/02/6702/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/02/6702/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/02/6702/1 \u0026\u0026 git checkout -b change-6702 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/02/6702/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/02/6702/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/02/6702/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/02/6702/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/02/6702/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3335517b309fd099531bd2b3ec11b540e65bcec1","subject":"target/adi_v5_swd: introduce swd_queue_dp_read/write_inner()"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2021-11-15 14:32:39.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2021-11-15 14:40:16.000000000","tz":60},"subject":"target/arm_dap: clean up dap_configure code","message":"target/arm_dap: clean up dap_configure code\n\ndap_configure() contained first time init related tasks, as the call to\ndap_init_instance() and the check for configured tap.\n\nMove all first time init related stuff to dap_create() to make dap_configure()\nusable in eventual stand-alone \u0027dap configure\u0027 command.\n\nChange-Id: Ia86eadb4e960ce54e8581630d01af75720d2318d\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1001013,"name":"Matthias Welwarsky","email":"matthias@welwarsky.de","username":"thinkfat"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}