)]}'
{"id":"openocd~master~I4b3418a46f147392a4f965db6c34c6ab1f50926b","project":"openocd","branch":"master","topic":"keepalive","attention_set":{"1001667":{"account":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"last_update":"2021-11-16 00:51:51.000000000","reason":"Reviewer was added"},"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2025-05-17 17:52:00.000000000","reason":"A robot voted negatively on a label"},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2021-11-19 11:10:27.000000000","reason":"Antonio Borneo replied on the change"}},"removed_from_attention_set":{},"hashtags":[],"change_id":"I4b3418a46f147392a4f965db6c34c6ab1f50926b","subject":"server: accept connections during keep-alive","status":"NEW","created":"2021-11-16 00:51:51.000000000","updated":"2025-05-17 17:52:00.000000000","submit_type":"CHERRY_PICK","submittable":false,"total_comment_count":15,"unresolved_comment_count":3,"has_review_started":true,"meta_rev_id":"30676bdef4cf1c2968c4f622a9b84a2f0db30d7b","_number":6703,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"rejected":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:jenkins-gerrit-trigger","value":-1,"date":"2025-05-17 17:52:00.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0,"blocking":true},"Code-Review":{"recommended":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},{"tag":"autogenerated:gerrit:newPatchSet","value":1,"date":"2022-02-26 15:59:59.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","value":1,"default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-11-16 00:51:51.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"},{"updated":"2021-11-16 00:51:51.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"state":"REVIEWER"},{"updated":"2021-11-16 01:10:55.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"1d6ef3bf7b8ae4356188ae892119a5253a9475e5","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-11-16 00:51:51.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"0c83c4d2d2bbebe07fe0048f83c2008ac648b95b","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-11-16 01:10:55.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15545/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14763/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"ce1f564efa86e5468b7b63d983ca0c03782cb9d8","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-11-18 13:37:32.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"472984b850e6df8a98185c4521e3094e0cffa044","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-11-18 14:03:36.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"fe06d6c643c90bf7f89bef9ca42072e23ba1d94d","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-11-18 15:25:25.000000000","message":"Patch Set 1:\n\n(3 comments)","accounts_in_message":[],"_revision_number":1},{"id":"14e04b90845a5734e0ff46045b7be8518e6a493a","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-11-18 15:28:21.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"575cc4789fa68eb73faa566a8b6e227fb07e0a62","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-11-18 16:12:13.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"1c36c3cfca2e140d9a2e09a0645a0dae4314dc85","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-11-18 16:37:16.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"648b18947f9f671d34a91e1ec0acc5d938e30f72","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-11-18 22:18:27.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"d3616680500b17aa5ff0c11469c9ab73d46840ba","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-11-18 22:44:03.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"53c140e2fb041d813fa8227377a05452896e6c79","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-11-18 22:48:12.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"998319d295141a64485798083ec9cfb4aeab0f5c","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-11-18 23:38:59.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15576/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14793/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"4179fbee4b35a6e44ad5ce0630905efed8460d12","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-11-19 09:55:01.000000000","message":"Patch Set 2:\n\n(3 comments)","accounts_in_message":[],"_revision_number":2},{"id":"7fbaaff2b42dcea9c1a1b702adf0b13fa40144fb","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-11-19 11:10:27.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"1ad57d2de928586155e275e948ca0251fb6c9114","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-12-09 17:14:53.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"b6fe80bd1aec817f992938cd78dda72c9f527c80","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-12-09 17:22:41.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"5a2ea250c7e283a0e0d193e2db9e2447905eb631","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-12-09 21:42:54.000000000","message":"Uploaded patch set 4: New patch set was added with same tree, parent, and commit message as Patch Set 3.","accounts_in_message":[],"_revision_number":4},{"id":"0f6949566439694e8eff68b679cf20b95e14abac","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-12-09 22:54:24.000000000","message":"Patch Set 4: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15695/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14912/ : SUCCESS","accounts_in_message":[],"_revision_number":4},{"id":"26982e89a220001e15e2c7cea8ba23cc377524b2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-02-03 22:39:35.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"595dd8ef0a356a4d5d1e76e65eb7f9061f8b98c6","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-02-04 00:20:34.000000000","message":"Patch Set 5: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15831/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/15043/ : SUCCESS","accounts_in_message":[],"_revision_number":5},{"id":"34c4781ee01373c8d76079abef60237d76b12bee","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-02-26 15:59:59.000000000","message":"Uploaded patch set 6: Code-Review+1: Patch Set 5 was rebased.","accounts_in_message":[],"_revision_number":6},{"id":"30676bdef4cf1c2968c4f622a9b84a2f0db30d7b","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2025-05-17 17:52:00.000000000","message":"Patch Set 6: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit-build/20287/ : FAILURE\n\nhttps://build.openocd.org/job/openocd-gerrit/21146/ : SUCCESS","accounts_in_message":[],"_revision_number":6}],"current_revision":"0f0d53d2dd67028bbe2e79c74d3e39e777073911","revisions":{"cefe1a0a638e7005d5be26655b2f310f44efe268":{"kind":"REWORK","_number":2,"created":"2021-11-18 22:44:03.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/03/6703/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/03/6703/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/03/6703/2 \u0026\u0026 git checkout -b change-6703 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/03/6703/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/03/6703/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/03/6703/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/03/6703/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/03/6703/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a498a3deaaec7ee87d73cf753bdddefaf4779666","subject":"jtagspi: fix build on MacOS"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-11-16 00:44:07.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-11-18 22:43:09.000000000","tz":60},"subject":"[WIP] server: accept connections during keep_alive","message":"[WIP] server: accept connections during keep_alive\n\nGDB requires OpenOCD to reply to the first command within a delay\nof 6 seconds (3x remotetimeout). This is not always possible due\nto OpenOCD simple scheduler.\n\nReuse the keep_alive() mechanism to sense an incoming connection,\naccept it and, in case of GDB, send keep-alive packets to prevent\nGDB to timeout.\n\nIt doesn\u0027t work with LLDB, yet.\n\nChange-Id: I4b3418a46f147392a4f965db6c34c6ab1f50926b\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"05dffed0211381167f60a454a28614e9f6af50e7":{"kind":"REWORK","_number":3,"created":"2021-12-09 17:14:53.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/03/6703/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/03/6703/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/03/6703/3 \u0026\u0026 git checkout -b change-6703 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/03/6703/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/03/6703/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/03/6703/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/03/6703/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/03/6703/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"fe62c937162a2bf53904e8d58667cf071b5169af","subject":"openocd: add keep_alive during command sleep"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-11-16 00:44:07.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-12-09 16:57:14.000000000","tz":60},"subject":"[WIP] server: accept connections during keep_alive","message":"[WIP] server: accept connections during keep_alive\n\nGDB requires OpenOCD to reply to the first command within a delay\nof 6 seconds (3x remotetimeout). This is not always possible due\nto OpenOCD simple scheduler.\n\nReuse the keep_alive() mechanism to sense an incoming connection,\naccept it and, in case of GDB, send keep-alive packets to prevent\nGDB to timeout.\n\nIt doesn\u0027t work with LLDB, yet.\n\nChange-Id: I4b3418a46f147392a4f965db6c34c6ab1f50926b\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"5cf99c6678d4f5c0affc8dca1fc012af5ed442b4":{"kind":"REWORK","_number":1,"created":"2021-11-16 00:51:51.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/03/6703/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/03/6703/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/03/6703/1 \u0026\u0026 git checkout -b change-6703 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/03/6703/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/03/6703/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/03/6703/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/03/6703/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/03/6703/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a498a3deaaec7ee87d73cf753bdddefaf4779666","subject":"jtagspi: fix build on MacOS"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-11-16 00:44:07.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-11-16 00:44:07.000000000","tz":60},"subject":"[WIP] server: accept connections during keep_alive","message":"[WIP] server: accept connections during keep_alive\n\nGDB requires OpenOCD to reply to the first command within a delay\nof 6 seconds (3x remotetimeout). This is not always possible due\nto OpenOCD simple scheduler.\n\nReuse the keep_alive() mechanism to sense an incoming connection,\naccept it and, in case of GDB, send keep-alive packets to prevent\nGDB to timeout.\n\nIt doesn\u0027t work with LLDB, yet.\n\nChange-Id: I4b3418a46f147392a4f965db6c34c6ab1f50926b\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"0f0d53d2dd67028bbe2e79c74d3e39e777073911":{"kind":"TRIVIAL_REBASE","_number":6,"created":"2022-02-26 15:59:59.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/03/6703/6","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/03/6703/6","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/03/6703/6 \u0026\u0026 git checkout -b change-6703 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/03/6703/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/03/6703/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/03/6703/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/03/6703/6","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/03/6703/6 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"dfbf2eb60b756f66a665e42d1f796a5006395838","subject":"gdb_server: don\u0027t send unrequested ACK at connection"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-02-03 17:27:11.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-02-26 15:50:03.000000000","tz":60},"subject":"server: accept connections during keep-alive","message":"server: accept connections during keep-alive\n\nGDB timeouts if OpenOCD does not accept the incoming connection\nwithin ~20 seconds.\nAfter the connection is accepted, GDB starts the handshake and\nrequires OpenOCD to reply to the first GDB-remote command within a\ndelay of 6 seconds (3x remotetimeout).\n\nDue to the simple scheduler in OpenOCD, it\u0027s not always possible\nto accept the connection on time.\nThe current implementation is unable to send a valid keep-alive\nmessage during the initial handshake.\n\nReuse the keep-alive mechanism to accept the incoming connections.\nExtend the keep-alive to send dedicated packets (actually just\njunk bytes) during the initial handshake.\n\nIt doesn\u0027t work with LLDB 13.0.0, yet. A fix for LLDB is on-going,\nwhile a workaround for OpenOCD will be added in next commit.\n\nChange-Id: I4b3418a46f147392a4f965db6c34c6ab1f50926b\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"458ed9b338013dea52058d6bde7fa68e019b3429":{"kind":"NO_CHANGE","_number":4,"created":"2021-12-09 21:42:54.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/03/6703/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/03/6703/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/03/6703/4 \u0026\u0026 git checkout -b change-6703 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/03/6703/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/03/6703/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/03/6703/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/03/6703/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/03/6703/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2ded39c0240983cd0b03f073f22da88789687934","subject":"gdb_server: fix a comment in gdb_new_connection()"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-11-16 00:44:07.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-12-09 21:42:22.000000000","tz":60},"subject":"[WIP] server: accept connections during keep_alive","message":"[WIP] server: accept connections during keep_alive\n\nGDB requires OpenOCD to reply to the first command within a delay\nof 6 seconds (3x remotetimeout). This is not always possible due\nto OpenOCD simple scheduler.\n\nReuse the keep_alive() mechanism to sense an incoming connection,\naccept it and, in case of GDB, send keep-alive packets to prevent\nGDB to timeout.\n\nIt doesn\u0027t work with LLDB, yet.\n\nChange-Id: I4b3418a46f147392a4f965db6c34c6ab1f50926b\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"1b10dfa6c82b3c2884323be46428ed986ca3ec9a":{"kind":"REWORK","_number":5,"created":"2022-02-03 22:39:35.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/03/6703/5","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/03/6703/5","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/03/6703/5 \u0026\u0026 git checkout -b change-6703 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/03/6703/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/03/6703/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/03/6703/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/03/6703/5","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/03/6703/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"797517ea9247fae6044a32fa33f86e3fffb0126c","subject":"gdb_server: don\u0027t send unrequested ACK at connection"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-02-03 17:27:11.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-02-03 22:37:32.000000000","tz":60},"subject":"server: accept connections during keep-alive","message":"server: accept connections during keep-alive\n\nGDB timeouts if OpenOCD does not accept the incoming connection\nwithin ~20 seconds.\nAfter the connection is accepted, GDB starts the handshake and\nrequires OpenOCD to reply to the first GDB-remote command within a\ndelay of 6 seconds (3x remotetimeout).\n\nDue to the simple scheduler in OpenOCD, it\u0027s not always possible\nto accept the connection on time.\nThe current implementation is unable to send a valid keep-alive\nmessage during the initial handshake.\n\nReuse the keep-alive mechanism to accept the incoming connections.\nExtend the keep-alive to send dedicated packets (actually just\njunk bytes) during the initial handshake.\n\nIt doesn\u0027t work with LLDB 13.0.0, yet. A fix for LLDB is on-going,\nwhile a workaround for OpenOCD will be added in next commit.\n\nChange-Id: I4b3418a46f147392a4f965db6c34c6ab1f50926b\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"NOT_READY","labels":[{"label":"Verified","status":"REJECT","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"NEED"}]}],"submit_requirements":[{"name":"Verified","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"]}},{"name":"Code-Review","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"]}}]}