)]}'
{"id":"openocd~master~I386ae15cf052b1490461ed8f7eea5b4403d466f7","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2022-04-13 16:50:21.000000000","reason":"Change was submitted"},"1000863":{"account":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"last_update":"2022-04-04 12:12:41.000000000","reason":"Tarek BOCHKATI replied on the change"}},"hashtags":[],"change_id":"I386ae15cf052b1490461ed8f7eea5b4403d466f7","subject":"flash/nor/stm32f1x: allow write fallback for flash options","status":"MERGED","created":"2021-11-17 16:48:25.000000000","updated":"2022-04-13 16:50:21.000000000","submitted":"2022-04-13 16:50:21.000000000","submitter":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6706","meta_rev_id":"1d388b2c81a234a1f0ad56555576160d0e9e8593","_number":6706,"owner":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-04-13 16:50:21.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-04-13 16:50:21.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-04-13 16:50:21.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"}],"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-11-17 17:08:44.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-02-25 20:32:46.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"state":"REVIEWER"},{"updated":"2022-04-11 18:08:16.000000000","updated_by":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"reviewer":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"state":"CC"}],"messages":[{"id":"a23f25de2535adf9c7f33bd88df511147ed8cd2b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-11-17 16:48:25.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8243c4851efc9bc5e377aad6610495e8e3b46fd3","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-11-17 17:08:44.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15551/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14767/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"2b53ecfa5cb9e076767b691cc5fb766557818905","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-11-17 18:42:53.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"39b232855d209ffa6ba8f93e2f04c3e4400fe11e","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-11-17 19:03:15.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15559/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14776/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"f0b9ab4d5e57d1c320bc83bf736a35d0377b475a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-11-25 18:32:33.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.","accounts_in_message":[],"_revision_number":3},{"id":"e2cc854b191e349d950ea8c937d2a5fd24b75520","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-11-25 19:05:41.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15656/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14873/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"b1cd614eff1d1a7c175eaeb61d94c12e4f475f35","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2022-04-04 12:12:41.000000000","message":"Patch Set 3: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"2fd9712819bc1a3e6eacd15074aaa3fed3654ae1","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-04-05 20:59:59.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"1994722fd24dad8d3546ba6d5ae7e344d3b2d93e","author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"real_author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"date":"2022-04-11 18:08:16.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"1d388b2c81a234a1f0ad56555576160d0e9e8593","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-04-13 16:50:21.000000000","message":"Change has been successfully cherry-picked as dd532e87c038ecd988b8bf83d6b1cf4515d5d2c9","accounts_in_message":[],"_revision_number":4}],"current_revision":"dd532e87c038ecd988b8bf83d6b1cf4515d5d2c9","revisions":{"354ba7686cef5f2115a65fd584004fa4281e2979":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2021-11-25 18:32:33.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/06/6706/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/06/6706/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/06/6706/3 \u0026\u0026 git checkout -b change-6706 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/06/6706/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/06/6706/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/06/6706/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/06/6706/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/06/6706/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"647d202e188411a4ac0e713378399ea18646381f","subject":"flash/stm32f1x,f2x: fix endianess in slow fallback flash write"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2021-11-16 16:51:09.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2021-11-25 16:34:34.000000000","tz":60},"subject":"flash/nor/stm32f1x: allow write fallback for flash options","message":"flash/nor/stm32f1x: allow write fallback for flash options\n\nMostly refactoring.\n\nRename original stm32x_write_block() to stm32x_write_block_async()\nas it uses target async algo.\n\nIntroduce new stm32x_write_block() and move slow, host controlled\nfallback flash write there.\n\nThe change allows stm32x_write_options() to use slow flash write fallback.\n\nWhile on it rename variables where halfword count is stored.\n\nChange-Id: I386ae15cf052b1490461ed8f7eea5b4403d466f7\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"1d434daa2c16278748b5754cd5e9af8b46c80f8c":{"kind":"REWORK","_number":2,"created":"2021-11-17 18:42:53.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/06/6706/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/06/6706/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/06/6706/2 \u0026\u0026 git checkout -b change-6706 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/06/6706/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/06/6706/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/06/6706/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/06/6706/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/06/6706/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"0b081a327bbcf37a3411e6a8fabf6eb7dc6287b1","subject":"flash/stm32f1x,f2x: fix endianess in slow fallback flash write"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2021-11-16 16:51:09.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2021-11-17 18:42:10.000000000","tz":60},"subject":"flash/nor/stm32f1x: allow write fallback for flash options","message":"flash/nor/stm32f1x: allow write fallback for flash options\n\nMostly refactoring.\n\nRename original stm32x_write_block() to stm32x_write_block_async()\nas it uses target async algo.\n\nIntroduce new stm32x_write_block() and move slow, host controlled\nfallback flash write there.\n\nThe change allows stm32x_write_options() to use slow flash write fallback.\n\nWhile on it rename variables where halfword count is stored.\n\nChange-Id: I386ae15cf052b1490461ed8f7eea5b4403d466f7\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"45421bfd47b9df873af4d157837b21c0e2aef57c":{"kind":"REWORK","_number":1,"created":"2021-11-17 16:48:25.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/06/6706/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/06/6706/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/06/6706/1 \u0026\u0026 git checkout -b change-6706 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/06/6706/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/06/6706/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/06/6706/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/06/6706/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/06/6706/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"38090c10fc4530de69988df4951842d0af6ea994","subject":"flash/stm32f1x,f2x: fix endianess in slow fallback flash write"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2021-11-16 16:51:09.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2021-11-17 06:56:40.000000000","tz":60},"subject":"flash/nor/stm32f1x: allow write fallback for flash options","message":"flash/nor/stm32f1x: allow write fallback for flash options\n\nMostly refactoring.\n\nRename original stm32x_write_block() to stm32x_write_block_async()\nas it uses target async algo.\n\nIntroduce new stm32x_write_block() and move slow, host controlled\nfallback flash write there.\n\nThe change allows stm32x_write_options() to use slow flash write fallback.\n\nWhile on it rename variables where halfword count is stored.\n\nChange-Id: I386ae15cf052b1490461ed8f7eea5b4403d466f7\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"dd532e87c038ecd988b8bf83d6b1cf4515d5d2c9":{"kind":"REWORK","_number":4,"created":"2022-04-13 16:50:21.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/06/6706/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/06/6706/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/06/6706/4 \u0026\u0026 git checkout -b change-6706 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/06/6706/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/06/6706/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/06/6706/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/06/6706/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/06/6706/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7c6d379cf4434c69a977af4f417fe1ab1f3f9178","subject":"tcl/board: Add NXP FRDM-K64F"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2021-11-16 16:51:09.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-04-13 16:50:21.000000000","tz":0},"subject":"flash/nor/stm32f1x: allow write fallback for flash options","message":"flash/nor/stm32f1x: allow write fallback for flash options\n\nMostly refactoring.\n\nRename original stm32x_write_block() to stm32x_write_block_async()\nas it uses target async algo.\n\nIntroduce new stm32x_write_block() and move slow, host controlled\nfallback flash write there.\n\nThe change allows stm32x_write_options() to use slow flash write fallback.\n\nWhile on it rename variables where halfword count is stored.\n\nChange-Id: I386ae15cf052b1490461ed8f7eea5b4403d466f7\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6706\nTested-by: jenkins\nReviewed-by: Tarek BOCHKATI \u003ctarek.bouchkati@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}