)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"32b659daa882ec1d53cf21cc67a81f274bdb25c1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"909477a2_674bbf2d","updated":"2022-04-11 18:08:51.000000000","message":"This works with flash in GD32VF103CBT6 on Longan Nano board.","commit_id":"7e08b8191a26f8baebf53ab29d1474d9aac6927e"},{"author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"change_message_id":"2772ce6f22ec2c988aae5c35dc772de156add8f0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a0bcd803_aa8f94a7","updated":"2022-04-04 12:20:42.000000000","message":"visually LGTM !","commit_id":"7e08b8191a26f8baebf53ab29d1474d9aac6927e"}],"src/flash/nor/stm32f1x.c":[{"author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"change_message_id":"2772ce6f22ec2c988aae5c35dc772de156add8f0","unresolved":true,"context_lines":[{"line_number":152,"context_line":"\tstm32x_info-\u003euser_bank_size \u003d bank-\u003esize;"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"\t/* The flash write must be aligned to a halfword boundary */"},{"line_number":155,"context_line":"\tbank-\u003ewrite_start_alignment \u003d bank-\u003ewrite_end_alignment \u003d 2;"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"\treturn ERROR_OK;"},{"line_number":158,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"eb105d74_0cbcc6be","line":155,"range":{"start_line":155,"start_character":1,"end_line":155,"end_character":61},"updated":"2022-04-04 12:20:42.000000000","message":"this looks good to me.\n\nbut recently I have received a review from Antonio telling me to avoid this\nQuote:\n  no, please don\u0027t use double assignment as it can be mistaken as \"a \u003d (b \u003d\u003d c);\"\n\nIDK if there is a rule related to this or not ...","commit_id":"7e08b8191a26f8baebf53ab29d1474d9aac6927e"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"3490c549cc0ae17bbc11a35aa1377fd96b3da5f9","unresolved":true,"context_lines":[{"line_number":152,"context_line":"\tstm32x_info-\u003euser_bank_size \u003d bank-\u003esize;"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"\t/* The flash write must be aligned to a halfword boundary */"},{"line_number":155,"context_line":"\tbank-\u003ewrite_start_alignment \u003d bank-\u003ewrite_end_alignment \u003d 2;"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"\treturn ERROR_OK;"},{"line_number":158,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"67aa2411_04005482","line":155,"range":{"start_line":155,"start_character":1,"end_line":155,"end_character":61},"in_reply_to":"eb105d74_0cbcc6be","updated":"2022-04-05 16:24:35.000000000","message":"I agree that we should not use multiple assignment.\nHere is exceptionally used to emphasize that both variables must be set to the same value. The same pattern is also used in other 5 flash drivers and similarly for bank-\u003edefault_padded_value and bank-\u003eerased_value in other 7 drivers.\nWe can address this issue in a new patch by introducing inline setters in src/flash/nor/core.h as so far no flash driver needs different write_start_alignment and write_end_alignment (and default_padded_value is always same as erased_value)","commit_id":"7e08b8191a26f8baebf53ab29d1474d9aac6927e"}]}