)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"5bf0209d831ebfea6a1196e6dbf9369eeb40dacb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3a31f193_4e934806","updated":"2021-11-18 10:03:48.000000000","message":"minor typo plus some other code that could be adapted","commit_id":"8db1cee95d419ad3344c3021626d48e2c6250a00"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"9faceac414beaec7416d6a7c2cb367d8da5f1f3f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"acb7fc00_064eab93","in_reply_to":"3a31f193_4e934806","updated":"2021-11-18 21:05:18.000000000","message":"Tim was lighting fast in fixing #6679 so I rebased on top of it and removed last 2 ifs","commit_id":"8db1cee95d419ad3344c3021626d48e2c6250a00"}],"src/flash/nor/fespi.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"5bf0209d831ebfea6a1196e6dbf9369eeb40dacb","unresolved":true,"context_lines":[{"line_number":840,"context_line":"\tif (algorithm_wa) {"},{"line_number":841,"context_line":"\t\ttarget_free_working_area(target, data_wa);"},{"line_number":842,"context_line":"\t\ttarget_free_working_area(target, algorithm_wa);"},{"line_number":843,"context_line":"\t}"},{"line_number":844,"context_line":""},{"line_number":845,"context_line":"\tas_delete(as);"},{"line_number":846,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"498543b0_0bde312e","line":843,"updated":"2021-11-18 10:03:48.000000000","message":"quickly checking this code, looks like the \"if\" can be removed too.\nI don\u0027t see relationship that makes data_wa non-NULL when algorithm_wa is non-NULL, so the \"if\" was even miss-placed","commit_id":"8db1cee95d419ad3344c3021626d48e2c6250a00"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"53ff368fceef0ba0d18673b35580f071a4d09744","unresolved":false,"context_lines":[{"line_number":840,"context_line":"\tif (algorithm_wa) {"},{"line_number":841,"context_line":"\t\ttarget_free_working_area(target, data_wa);"},{"line_number":842,"context_line":"\t\ttarget_free_working_area(target, algorithm_wa);"},{"line_number":843,"context_line":"\t}"},{"line_number":844,"context_line":""},{"line_number":845,"context_line":"\tas_delete(as);"},{"line_number":846,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"6e81899e_0d3a0ecf","line":843,"in_reply_to":"498543b0_0bde312e","updated":"2021-11-18 12:57:00.000000000","message":"Agreed. I\u0027m reviewing\n6679: flash/nor/fespi: algorithm, large address, errors | https://review.openocd.org/c/openocd/+/6679\nand this was the fist place where I noticed the problem.\nSo to avoid conflict I intentionally left out all Tim\u0027s sources - we may address it in #6679 or later.","commit_id":"8db1cee95d419ad3344c3021626d48e2c6250a00"}],"src/flash/nor/sh_qspi.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"5bf0209d831ebfea6a1196e6dbf9369eeb40dacb","unresolved":true,"context_lines":[{"line_number":706,"context_line":"\ttarget_free_working_area(target, info-\u003esource);"},{"line_number":707,"context_line":"\ttarget_free_working_area(target, info-\u003eio_algorithm);"},{"line_number":708,"context_line":""},{"line_number":709,"context_line":"\t/* FIXME: Workink areas are allocated during flash probe"},{"line_number":710,"context_line":"\t * and eventual target_free_all_working_areas() called in case"},{"line_number":711,"context_line":"\t * of target reset or run is not handled at all."},{"line_number":712,"context_line":"\t */"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"371061a6_dc400fe4","line":709,"updated":"2021-11-18 10:03:48.000000000","message":"typo s/workink/working/","commit_id":"8db1cee95d419ad3344c3021626d48e2c6250a00"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"53ff368fceef0ba0d18673b35580f071a4d09744","unresolved":false,"context_lines":[{"line_number":706,"context_line":"\ttarget_free_working_area(target, info-\u003esource);"},{"line_number":707,"context_line":"\ttarget_free_working_area(target, info-\u003eio_algorithm);"},{"line_number":708,"context_line":""},{"line_number":709,"context_line":"\t/* FIXME: Workink areas are allocated during flash probe"},{"line_number":710,"context_line":"\t * and eventual target_free_all_working_areas() called in case"},{"line_number":711,"context_line":"\t * of target reset or run is not handled at all."},{"line_number":712,"context_line":"\t */"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"1597bc78_9eae91d0","line":709,"in_reply_to":"371061a6_dc400fe4","updated":"2021-11-18 12:57:00.000000000","message":"Done","commit_id":"8db1cee95d419ad3344c3021626d48e2c6250a00"}],"src/target/riscv/riscv-013.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"5bf0209d831ebfea6a1196e6dbf9369eeb40dacb","unresolved":true,"context_lines":[{"line_number":1200,"context_line":"\t\tscratch_mem_t *scratch)"},{"line_number":1201,"context_line":"{"},{"line_number":1202,"context_line":"\tif (scratch-\u003earea)"},{"line_number":1203,"context_line":"\t\treturn target_free_working_area(target, scratch-\u003earea);"},{"line_number":1204,"context_line":""},{"line_number":1205,"context_line":"\treturn ERROR_OK;"},{"line_number":1206,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"e9f3a9aa_c21651a0","line":1203,"updated":"2021-11-18 10:03:48.000000000","message":"can this enter in the same patch?","commit_id":"8db1cee95d419ad3344c3021626d48e2c6250a00"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"53ff368fceef0ba0d18673b35580f071a4d09744","unresolved":true,"context_lines":[{"line_number":1200,"context_line":"\t\tscratch_mem_t *scratch)"},{"line_number":1201,"context_line":"{"},{"line_number":1202,"context_line":"\tif (scratch-\u003earea)"},{"line_number":1203,"context_line":"\t\treturn target_free_working_area(target, scratch-\u003earea);"},{"line_number":1204,"context_line":""},{"line_number":1205,"context_line":"\treturn ERROR_OK;"},{"line_number":1206,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"8f74b337_bb7d36e3","line":1203,"in_reply_to":"e9f3a9aa_c21651a0","updated":"2021-11-18 12:57:00.000000000","message":"I know about it. Probably yes, as not related to the pending #6679","commit_id":"8db1cee95d419ad3344c3021626d48e2c6250a00"}]}