)]}'
{"id":"openocd~master~I7c692ab04a9933398ba5bc614723ad0bdecb87b3","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2021-11-18 23:22:49.000000000","reason":"Antonio Borneo replied on the change"},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2021-11-29 09:57:55.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I7c692ab04a9933398ba5bc614723ad0bdecb87b3","subject":"target,flash: allow target_free_working_area on NULL area pointer","status":"MERGED","created":"2021-11-18 08:43:25.000000000","updated":"2021-12-03 21:59:20.000000000","submitted":"2021-12-03 21:59:20.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":8,"unresolved_comment_count":1,"has_review_started":true,"submission_id":"6712","meta_rev_id":"c7b7303423dbdb451bbefbe11dde7ccc99298ba7","_number":6712,"owner":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-12-03 21:59:20.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-12-03 21:59:20.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-12-03 21:59:20.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-11-18 09:25:16.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-11-18 10:03:48.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"ff34accd7d6983dbae2c054193da72fe99fd4a5f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-11-18 08:43:25.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ec2bc2ad68bc0bd3a34eb7aed581266d7679387b","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-11-18 09:25:16.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15567/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14784/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"5bf0209d831ebfea6a1196e6dbf9369eeb40dacb","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-11-18 10:03:48.000000000","message":"Patch Set 1: Code-Review-1\n\n(4 comments)","accounts_in_message":[],"_revision_number":1},{"id":"53ff368fceef0ba0d18673b35580f071a4d09744","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-11-18 12:57:00.000000000","message":"Patch Set 1:\n\n(3 comments)","accounts_in_message":[],"_revision_number":1},{"id":"b3c11ccbd74b0edd2ea5757e6c3244c186e9953e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-11-18 12:57:06.000000000","message":"Patch Set 2: Published edit on patch set 1.","accounts_in_message":[],"_revision_number":2},{"id":"d73d1a92bc189e63159522e19a083c23ec42bee4","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-11-18 13:15:56.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15568/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14785/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"9c622b5a0c3a5b53afe7d3690a57f765757a4582","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-11-18 21:00:20.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"9faceac414beaec7416d6a7c2cb367d8da5f1f3f","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-11-18 21:05:18.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"df8258d06ac3f24ab64151572d43e4ce2a730dc1","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-11-18 22:37:44.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15575/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14792/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"163cb318bf69cbceb98b99f9fddc51835a80b7ad","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-11-18 23:22:49.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"37a33f3aad92b574619254dad62b83c78bd2f803","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-11-29 09:57:55.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"c7b7303423dbdb451bbefbe11dde7ccc99298ba7","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-12-03 21:59:20.000000000","message":"Change has been successfully cherry-picked as f735faa9319af324b94e4257444419c8dfec6592","accounts_in_message":[],"_revision_number":4}],"current_revision":"f735faa9319af324b94e4257444419c8dfec6592","revisions":{"8db1cee95d419ad3344c3021626d48e2c6250a00":{"kind":"REWORK","_number":1,"created":"2021-11-18 08:43:25.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/12/6712/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/12/6712/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/12/6712/1 \u0026\u0026 git checkout -b change-6712 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/12/6712/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/12/6712/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/12/6712/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/12/6712/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/12/6712/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"aa8a79809ef9e6b97d45da60508d902da0e3270e","subject":"flash/nor/at91samd: Add SAMR35J18B support"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2021-11-18 08:37:23.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2021-11-18 08:37:23.000000000","tz":60},"subject":"target,flash: allow target_free_working_area on NULL area pointer","message":"target,flash: allow target_free_working_area on NULL area pointer\n\nStandard C library free() allows NULL pointer as a parameter.\n\nChange target_free_working_area() to conform this convention.\n\nRemove NULL pointer tests before target_free_working_area() calls.\n\nWhile on it add missing setting pointer to NULL after target_free_working_area().\n\nChange-Id: I7c692ab04a9933398ba5bc614723ad0bdecb87b3\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"cf26b3a8bdd46145b4a8227b068bdd9cebbeec33":{"kind":"REWORK","_number":3,"created":"2021-11-18 21:00:20.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/12/6712/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/12/6712/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/12/6712/3 \u0026\u0026 git checkout -b change-6712 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/12/6712/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/12/6712/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/12/6712/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/12/6712/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/12/6712/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4193ae2349492a554cf81e6d936db2e155964118","subject":"flash/nor/fespi: algorithm, large address, errors"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2021-11-18 08:37:23.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2021-11-18 20:59:14.000000000","tz":60},"subject":"target,flash: allow target_free_working_area on NULL area pointer","message":"target,flash: allow target_free_working_area on NULL area pointer\n\nStandard C library free() allows NULL pointer as a parameter.\n\nChange target_free_working_area() to conform this convention.\n\nRemove NULL pointer tests before target_free_working_area() calls.\n\nWhile on it add missing setting pointer to NULL after target_free_working_area().\n\nChange-Id: I7c692ab04a9933398ba5bc614723ad0bdecb87b3\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"f7010599293306184aa1b5edaec680599cc52fd0":{"kind":"REWORK","_number":2,"created":"2021-11-18 12:57:06.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/12/6712/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/12/6712/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/12/6712/2 \u0026\u0026 git checkout -b change-6712 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/12/6712/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/12/6712/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/12/6712/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/12/6712/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/12/6712/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"aa8a79809ef9e6b97d45da60508d902da0e3270e","subject":"flash/nor/at91samd: Add SAMR35J18B support"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2021-11-18 08:37:23.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2021-11-18 12:52:12.000000000","tz":0},"subject":"target,flash: allow target_free_working_area on NULL area pointer","message":"target,flash: allow target_free_working_area on NULL area pointer\n\nStandard C library free() allows NULL pointer as a parameter.\n\nChange target_free_working_area() to conform this convention.\n\nRemove NULL pointer tests before target_free_working_area() calls.\n\nWhile on it add missing setting pointer to NULL after target_free_working_area().\n\nChange-Id: I7c692ab04a9933398ba5bc614723ad0bdecb87b3\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"f735faa9319af324b94e4257444419c8dfec6592":{"kind":"REWORK","_number":4,"created":"2021-12-03 21:59:20.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/12/6712/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/12/6712/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/12/6712/4 \u0026\u0026 git checkout -b change-6712 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/12/6712/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/12/6712/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/12/6712/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/12/6712/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/12/6712/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"35f284fe7c51d29768156cfec172152d2539d98a","subject":"flash/nor/fespi: algorithm, large address, errors"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2021-11-18 08:37:23.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-12-03 21:59:20.000000000","tz":0},"subject":"target,flash: allow target_free_working_area on NULL area pointer","message":"target,flash: allow target_free_working_area on NULL area pointer\n\nStandard C library free() allows NULL pointer as a parameter.\n\nChange target_free_working_area() to conform this convention.\n\nRemove NULL pointer tests before target_free_working_area() calls.\n\nWhile on it add missing setting pointer to NULL after target_free_working_area().\n\nChange-Id: I7c692ab04a9933398ba5bc614723ad0bdecb87b3\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6712\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}