)]}'
{"id":"openocd~master~I96fbdfa98bbb1f2b5e2a9532faf5a15cb5bc28dd","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2021-11-23 11:04:42.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I96fbdfa98bbb1f2b5e2a9532faf5a15cb5bc28dd","subject":"flash/rp2040: don\u0027t initialize to NULL fields in struct","status":"MERGED","created":"2021-11-19 15:32:48.000000000","updated":"2021-11-23 11:04:42.000000000","submitted":"2021-11-23 11:04:42.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6719","meta_rev_id":"c42828d0699e72fe3091f0f62033524815e3625c","_number":6719,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-11-23 11:04:42.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-11-23 11:04:42.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-11-19 16:51:59.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-11-21 15:49:36.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"}],"messages":[{"id":"3f86701cb055fae9320b436fab09c142b81f5b79","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-11-19 15:32:48.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"927375bbe5ee0c146e8ff49e0aaf0e24f221c877","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-11-19 16:51:59.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15583/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14800/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"71774c5617216af3da7dbc432cb7e4f6d1364651","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-11-21 15:49:36.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"c42828d0699e72fe3091f0f62033524815e3625c","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-11-23 11:04:42.000000000","message":"Change has been successfully cherry-picked as facbb481b806275208baca30debfd66d54bc4f9b","accounts_in_message":[],"_revision_number":2}],"current_revision":"facbb481b806275208baca30debfd66d54bc4f9b","revisions":{"a2cd7355161a121d48c4fb4fb6f99c112cb9a503":{"kind":"REWORK","_number":1,"created":"2021-11-19 15:32:48.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/19/6719/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/19/6719/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/19/6719/1 \u0026\u0026 git checkout -b change-6719 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/19/6719/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/19/6719/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/19/6719/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/19/6719/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/19/6719/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7e1278b90a7b989b7398831c1662e7faa5799e2c","subject":"openocd: declare struct command_registration in a single line"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-11-17 23:25:37.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-11-19 14:59:36.000000000","tz":60},"subject":"flash/rp2040: don\u0027t initialize to NULL fields in struct","message":"flash/rp2040: don\u0027t initialize to NULL fields in struct\n\nWhen a struct is initialized, missing fields are already filled\nwith zero or NULL.\nThis change simplifies scripts to compare documentation and\nregistered commands.\n\nChange-Id: I96fbdfa98bbb1f2b5e2a9532faf5a15cb5bc28dd\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"facbb481b806275208baca30debfd66d54bc4f9b":{"kind":"REWORK","_number":2,"created":"2021-11-23 11:04:42.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/19/6719/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/19/6719/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/19/6719/2 \u0026\u0026 git checkout -b change-6719 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/19/6719/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/19/6719/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/19/6719/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/19/6719/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/19/6719/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"43ea974555de9a5bd9870a18f9f8423f1c476ea5","subject":"openocd: declare struct command_registration in a single line"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-11-17 23:25:37.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-11-23 11:04:42.000000000","tz":0},"subject":"flash/rp2040: don\u0027t initialize to NULL fields in struct","message":"flash/rp2040: don\u0027t initialize to NULL fields in struct\n\nWhen a struct is initialized, missing fields are already filled\nwith zero or NULL.\nThis change simplifies scripts to compare documentation and\nregistered commands.\n\nChange-Id: I96fbdfa98bbb1f2b5e2a9532faf5a15cb5bc28dd\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6719\nTested-by: jenkins\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}
