)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"a3d4dbc37d32b8b0e45ee7a02925064171fa3246","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"44aacaca_5a02b013","updated":"2021-11-22 13:40:39.000000000","message":"I wonder if there is some intention in common_magic not set for hla. But IMO common_magic identifies particular struct, not particular target type.","commit_id":"6da215260e50a5710b87d87949963e3f0081cfe8"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"598589ed8e60923feb0516f7512a6e312ff02fb5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9ea4dd3b_14b907b5","in_reply_to":"44aacaca_5a02b013","updated":"2021-11-22 14:22:44.000000000","message":"\u003e I wonder if there is some intention in common_magic not set for hla...\n\nOf course there is. It keeps cortex_m Tcl commands from execution on hla.","commit_id":"6da215260e50a5710b87d87949963e3f0081cfe8"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"388ca2607465eb9eeae85f86bac1b992ad52538f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6e6122dc_a2af3f47","updated":"2021-11-24 19:24:42.000000000","message":"Let\u0027s take this one out of the series and merge it fast","commit_id":"2a75e45f0bcd5393008d7baea83b293b27214cc2"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"51e9c8339e42902565eda72cca8c0f0d265a63df","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d1f1cc28_30d6cfc8","updated":"2021-11-22 16:51:24.000000000","message":"Yes, I think it\u0027s correct.\ncommon_magic is used to check the struct type, struct that is used by HLA too, so has to be set in both cases.\nThen we have the flag is_hla_target (we can discuss if it has to be in struct cortex_m_common or in struct armv7m_common, but it\u0027s not the key point here). This is to be tested for DAP vs HLA.\n","commit_id":"2a75e45f0bcd5393008d7baea83b293b27214cc2"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"4abc26a98a0fbed88b5bf9c53b120febb4ce0b47","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"17273984_f1076776","in_reply_to":"6e6122dc_a2af3f47","updated":"2021-11-25 09:46:16.000000000","message":"Done","commit_id":"2a75e45f0bcd5393008d7baea83b293b27214cc2"}]}
