)]}'
{"id":"openocd~master~I4dae79f056c3d73adf524e26aa8ef2d3a57b471e","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2021-11-22 16:51:24.000000000","reason":"Antonio Borneo replied on the change"},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2021-11-24 19:24:42.000000000","reason":"Tomas Vanek replied on the change"}},"hashtags":[],"change_id":"I4dae79f056c3d73adf524e26aa8ef2d3a57b471e","subject":"target/hla_target: set cortex_m-\u003ecommon_magic","status":"MERGED","created":"2021-11-22 13:05:26.000000000","updated":"2021-11-25 09:47:28.000000000","submitted":"2021-11-25 09:47:28.000000000","submitter":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"total_comment_count":5,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6741","meta_rev_id":"356706e0df506f231ccfec4099a4e297f41f5b6c","_number":6741,"owner":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-11-25 09:47:28.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-11-25 09:47:28.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-11-25 09:47:28.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-11-22 13:26:43.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-11-22 13:40:39.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"ec0d4c1d2761a98adf5631d4cbf415de7a99557f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-11-22 13:05:26.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"66f1f9e45e90b5a8b4c403387e9be258fa31365a","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-11-22 13:26:43.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15622/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14838/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"a3d4dbc37d32b8b0e45ee7a02925064171fa3246","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-11-22 13:40:39.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"598589ed8e60923feb0516f7512a6e312ff02fb5","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-11-22 14:22:44.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"e0b2d324f026a14be547a3c49dd3e1eced8f7cf1","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-11-22 15:15:59.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"ab6d3e1437af10cb857fe9d748825401d040cfec","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-11-22 16:09:07.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15627/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14846/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"51e9c8339e42902565eda72cca8c0f0d265a63df","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-11-22 16:51:24.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"388ca2607465eb9eeae85f86bac1b992ad52538f","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-11-24 19:24:42.000000000","message":"Patch Set 2: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"4abc26a98a0fbed88b5bf9c53b120febb4ce0b47","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-11-25 09:46:16.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"356706e0df506f231ccfec4099a4e297f41f5b6c","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-11-25 09:47:28.000000000","message":"Change has been successfully cherry-picked as f66a16c4a06fde23ae25f39c92990aa049c3c970","accounts_in_message":[],"_revision_number":3}],"current_revision":"f66a16c4a06fde23ae25f39c92990aa049c3c970","revisions":{"6da215260e50a5710b87d87949963e3f0081cfe8":{"kind":"REWORK","_number":1,"created":"2021-11-22 13:05:26.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/41/6741/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/41/6741/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/41/6741/1 \u0026\u0026 git checkout -b change-6741 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/41/6741/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/41/6741/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/41/6741/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/41/6741/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/41/6741/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"8343ad4e109031d220791285913bc61955ae8334","subject":"flash/nor/stm32f1x: lock flash in case of error"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2021-11-22 12:50:01.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2021-11-22 13:05:01.000000000","tz":60},"subject":"target/hla_target: set cortex_m-\u003ecommon_magic","message":"target/hla_target: set cortex_m-\u003ecommon_magic\n\nhla_target uses the same struct cortex_m_common as the standard cortex_m\ntarget. Unlike the cortex_m target hla missed setting of common_magic.\n\nSet commont_magic to help pointer verification.\n\nChange-Id: I4dae79f056c3d73adf524e26aa8ef2d3a57b471e\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"2a75e45f0bcd5393008d7baea83b293b27214cc2":{"kind":"REWORK","_number":2,"created":"2021-11-22 15:15:59.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/41/6741/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/41/6741/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/41/6741/2 \u0026\u0026 git checkout -b change-6741 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/41/6741/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/41/6741/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/41/6741/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/41/6741/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/41/6741/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"8343ad4e109031d220791285913bc61955ae8334","subject":"flash/nor/stm32f1x: lock flash in case of error"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2021-11-22 12:50:01.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2021-11-22 15:11:49.000000000","tz":60},"subject":"target/hla_target: set cortex_m-\u003ecommon_magic","message":"target/hla_target: set cortex_m-\u003ecommon_magic\n\nhla_target uses the same struct cortex_m_common as the standard cortex_m\ntarget. Unlike the cortex_m target hla missed setting of common_magic.\n\nSet commont_magic to help pointer verification.\n\nAdd convenience tests is_cortex_m_or_hla() and\nis_cortex_m_with_dap_access()\n\nUse proper test in cortex_m_verify_pointer() - this code relied on\nunset common_magic on hla target before the change.\n\nChange-Id: I4dae79f056c3d73adf524e26aa8ef2d3a57b471e\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"f66a16c4a06fde23ae25f39c92990aa049c3c970":{"kind":"REWORK","_number":3,"created":"2021-11-25 09:47:28.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/41/6741/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/41/6741/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/41/6741/3 \u0026\u0026 git checkout -b change-6741 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/41/6741/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/41/6741/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/41/6741/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/41/6741/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/41/6741/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4626af440122272a6c18ad293edc81d3051d83ec","subject":"doc: fix typos in commands definition"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2021-11-22 12:50:01.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2021-11-25 09:47:28.000000000","tz":0},"subject":"target/hla_target: set cortex_m-\u003ecommon_magic","message":"target/hla_target: set cortex_m-\u003ecommon_magic\n\nhla_target uses the same struct cortex_m_common as the standard cortex_m\ntarget. Unlike the cortex_m target hla missed setting of common_magic.\n\nSet commont_magic to help pointer verification.\n\nAdd convenience tests is_cortex_m_or_hla() and\nis_cortex_m_with_dap_access()\n\nUse proper test in cortex_m_verify_pointer() - this code relied on\nunset common_magic on hla target before the change.\n\nChange-Id: I4dae79f056c3d73adf524e26aa8ef2d3a57b471e\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6741\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}