)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"39aa58d56f5eaa2769fb51b2bb601313f18fb4a1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"21b2d3bf_a5d023ec","updated":"2021-11-23 16:40:06.000000000","message":"Thanks.\nMaybe the commit message is not super-accurate since set_prefer_sba is removed by the doc, not marked as deprecated. But it is marked deprecated in the code, so ok whit this!","commit_id":"9711bcc04561ed7a416c0708954859b52d48c852"},{"author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"change_message_id":"1a1c65d5e7f2f8c058dabbb6ec6db17b804edf7e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"2016eb71_d9a977ce","updated":"2021-11-24 10:41:39.000000000","message":"I have rebased the change to avoid merge conflicts.\n\nThe commit message has also been updated.","commit_id":"174647a4a08f8559ebbff5a055c844305835595c"}],"doc/openocd.texi":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"bc9b5d72d13edb8782d853cf7e28ab2939838eb4","unresolved":true,"context_lines":[{"line_number":10205,"context_line":"@end deffn"},{"line_number":10206,"context_line":""},{"line_number":10207,"context_line":"@deffn {Command} {riscv set_prefer_sba} on|off"},{"line_number":10208,"context_line":"This command is @emph{deprecated}. Please use @command{riscv set_mem_access} instead."},{"line_number":10209,"context_line":""},{"line_number":10210,"context_line":"@itemize"},{"line_number":10211,"context_line":"@item @command{riscv set_prefer_sba off} is equivalent to"}],"source_content_type":"text/x-texinfo","patch_set":2,"id":"109c895a_8554bf74","line":10208,"updated":"2021-11-22 15:09:33.000000000","message":"Usually we do not document deprecated commands, mainly to avoid them to be used.\n\nAlso (but not for this patch), deprecated commands are removed as real commands in the C code and moved in src/*/startup.tcl as TCL wrappers to call the new commands.\nSo the command should be removed from riscv.c and in src/target/startup.tcl there should be something like:\nproc \"riscv set_prefer_sba\" {args} {\n  switch $args {\n  on {\n     echo \"DEPRECATED! use \u0027riscv set_mem_access sysbus progbuf abstract\u0027 not \u0027riscv set_prefer_sba on\u0027\"\n     eval riscv set_mem_access sysbus progbuf abstract\n  }\n  off {\n     ...\n  }\n  default {\n    echo \"DEPRECATED! ...\"\n    return -code error\n  }\n}","commit_id":"035cae4015ab84f66e8337d1438565baa9a743b8"},{"author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"change_message_id":"44285aca0464c01662b1423055a0fd3411bde9e2","unresolved":false,"context_lines":[{"line_number":10205,"context_line":"@end deffn"},{"line_number":10206,"context_line":""},{"line_number":10207,"context_line":"@deffn {Command} {riscv set_prefer_sba} on|off"},{"line_number":10208,"context_line":"This command is @emph{deprecated}. Please use @command{riscv set_mem_access} instead."},{"line_number":10209,"context_line":""},{"line_number":10210,"context_line":"@itemize"},{"line_number":10211,"context_line":"@item @command{riscv set_prefer_sba off} is equivalent to"}],"source_content_type":"text/x-texinfo","patch_set":2,"id":"8622a064_d8d891e0","line":10208,"in_reply_to":"109c895a_8554bf74","updated":"2021-11-23 11:46:38.000000000","message":"I\u0027ve removed the deprecated command \"set_prefer_sba\" from the documentation, as suggested.\n\nI\u0027ll move the deprecated command to startup.tcl in a separate pull request.","commit_id":"035cae4015ab84f66e8337d1438565baa9a743b8"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"bc9b5d72d13edb8782d853cf7e28ab2939838eb4","unresolved":true,"context_lines":[{"line_number":10226,"context_line":"@item @code{abstract} - Access memory via RISC-V Debug abstract commands."},{"line_number":10227,"context_line":"@end itemize"},{"line_number":10228,"context_line":""},{"line_number":10229,"context_line":"By default, all memory access methods enabled in the following order:"},{"line_number":10230,"context_line":"@code{progbuf sysbus abstract}."},{"line_number":10231,"context_line":""},{"line_number":10232,"context_line":"This command can be used to change the memory access methods if the default"}],"source_content_type":"text/x-texinfo","patch_set":2,"id":"d89e318c_e524a70f","line":10229,"updated":"2021-11-22 15:09:33.000000000","message":"... all memory access methods _are_ enabled ...","commit_id":"035cae4015ab84f66e8337d1438565baa9a743b8"},{"author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"change_message_id":"44285aca0464c01662b1423055a0fd3411bde9e2","unresolved":false,"context_lines":[{"line_number":10226,"context_line":"@item @code{abstract} - Access memory via RISC-V Debug abstract commands."},{"line_number":10227,"context_line":"@end itemize"},{"line_number":10228,"context_line":""},{"line_number":10229,"context_line":"By default, all memory access methods enabled in the following order:"},{"line_number":10230,"context_line":"@code{progbuf sysbus abstract}."},{"line_number":10231,"context_line":""},{"line_number":10232,"context_line":"This command can be used to change the memory access methods if the default"}],"source_content_type":"text/x-texinfo","patch_set":2,"id":"11f76b52_e728ced7","line":10229,"in_reply_to":"d89e318c_e524a70f","updated":"2021-11-23 11:46:38.000000000","message":"Fixed.","commit_id":"035cae4015ab84f66e8337d1438565baa9a743b8"}]}