)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"a921a609f9991e96e8c0113d94fd88270a172da3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e6770d44_24879c52","updated":"2021-11-24 09:43:45.000000000","message":"Revert of\n6548: target: reset target examined flag if target::examine() fails | https://review.openocd.org/c/openocd/+/6548\nis preferred solution for the moment","commit_id":"0015e2abd0fdcc15b63524d5cd2ab75078549ee2"}],"src/target/cortex_m.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"86b6468f1a1a8f135a7f5d9dc61ac53643fb4a58","unresolved":true,"context_lines":[{"line_number":1422,"context_line":""},{"line_number":1423,"context_line":"\tbool srst_asserted \u003d false;"},{"line_number":1424,"context_line":""},{"line_number":1425,"context_line":"\tif (!armv7m-\u003edebug_ap) {"},{"line_number":1426,"context_line":"\t\tif (jtag_reset_config \u0026 RESET_HAS_SRST) {"},{"line_number":1427,"context_line":"\t\t\tadapter_assert_reset();"},{"line_number":1428,"context_line":"\t\t\tif (target-\u003ereset_halt)"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"5b8b3645_48faec25","line":1425,"updated":"2021-11-23 16:34:36.000000000","message":"to keep track of this change, would you mind wrapping it in a local function target_was_examined_once() and adding to the function a comment that it is to workaround limitation on target_was_examined() ?","commit_id":"0015e2abd0fdcc15b63524d5cd2ab75078549ee2"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"94d31804b9603d12dbaea3c758430248c32b1784","unresolved":true,"context_lines":[{"line_number":1573,"context_line":"\t\t}"},{"line_number":1574,"context_line":"\t}"},{"line_number":1575,"context_line":""},{"line_number":1576,"context_line":"\tif (!target_was_examined(target) \u0026\u0026 !target-\u003edefer_examine)"},{"line_number":1577,"context_line":"\t\ttarget_examine_one(target);"},{"line_number":1578,"context_line":""},{"line_number":1579,"context_line":"\treturn ERROR_OK;"},{"line_number":1580,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"ef6773cf_6a6c3d5e","line":1577,"range":{"start_line":1576,"start_character":1,"end_line":1577,"end_character":29},"updated":"2021-11-23 12:44:29.000000000","message":"This is an awful hack.\nTBH I lose motivation to make changes in ocd_process_reset_inner in startup.tcl\nas the reset series is just getting rust in the bottom of gerrit stack.","commit_id":"0015e2abd0fdcc15b63524d5cd2ab75078549ee2"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"a921a609f9991e96e8c0113d94fd88270a172da3","unresolved":true,"context_lines":[{"line_number":1573,"context_line":"\t\t}"},{"line_number":1574,"context_line":"\t}"},{"line_number":1575,"context_line":""},{"line_number":1576,"context_line":"\tif (!target_was_examined(target) \u0026\u0026 !target-\u003edefer_examine)"},{"line_number":1577,"context_line":"\t\ttarget_examine_one(target);"},{"line_number":1578,"context_line":""},{"line_number":1579,"context_line":"\treturn ERROR_OK;"},{"line_number":1580,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"d5fc35c2_31f9b214","line":1577,"range":{"start_line":1576,"start_character":1,"end_line":1577,"end_character":29},"in_reply_to":"8b1cb079_3f260a32","updated":"2021-11-24 09:43:45.000000000","message":"The examination during reset doesn\u0027t work exactly same way as stand-alone one at least for Kinetis. The event kinetis mdm check_security stops/resumes polling but polling is disabled during ocd_process_reset execution and restored later.","commit_id":"0015e2abd0fdcc15b63524d5cd2ab75078549ee2"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"86b6468f1a1a8f135a7f5d9dc61ac53643fb4a58","unresolved":true,"context_lines":[{"line_number":1573,"context_line":"\t\t}"},{"line_number":1574,"context_line":"\t}"},{"line_number":1575,"context_line":""},{"line_number":1576,"context_line":"\tif (!target_was_examined(target) \u0026\u0026 !target-\u003edefer_examine)"},{"line_number":1577,"context_line":"\t\ttarget_examine_one(target);"},{"line_number":1578,"context_line":""},{"line_number":1579,"context_line":"\treturn ERROR_OK;"},{"line_number":1580,"context_line":"}"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"8b1cb079_3f260a32","line":1577,"range":{"start_line":1576,"start_character":1,"end_line":1577,"end_character":29},"in_reply_to":"ef6773cf_6a6c3d5e","updated":"2021-11-23 16:34:36.000000000","message":"let\u0027s fix it for v0.12.0, but later we could think about splitting current examination in two:\n- detecting if target is accessible\n- detecting target properties (M0/M4/M33, num of breakpoint, ...)\nThis will introduce a new target_is_accessible() and rename, to avoid confusion, target_has_been_examined().\nWe could even extend the polling with a test if the target is accessible and eventually update the status to UNKNOWN.","commit_id":"0015e2abd0fdcc15b63524d5cd2ab75078549ee2"}]}