)]}'
{"id":"openocd~master~Ie2e018610026180af5997d70231061a275f05c76","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2022-10-01 08:26:56.000000000","reason":"Antonio Borneo replied on the change"},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2022-10-08 08:46:12.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ie2e018610026180af5997d70231061a275f05c76","subject":"target/cortex_m: make reset robust again","status":"MERGED","created":"2021-11-23 12:25:16.000000000","updated":"2022-10-08 08:46:12.000000000","submitted":"2022-10-08 08:46:12.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":5,"unresolved_comment_count":2,"has_review_started":true,"submission_id":"6745","meta_rev_id":"c412126d5144c2ac41d5295c07633d5c9dca38b9","_number":6745,"owner":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-10-08 08:46:12.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-10-08 08:46:12.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-11-23 12:34:47.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-11-23 16:34:36.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"CC"},{"updated":"2022-10-01 08:26:56.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"728f5c05d1b1a76967858c8d1726ef66bb03430a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-11-23 12:25:16.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ea4e74e242214a608adc571ff310c8d9c015f0e6","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-11-23 12:34:18.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"ae10d94883a73ffb39f054916bee6ac7d160ccc9","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-11-23 12:34:47.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit-build/14849/ : ABORTED","accounts_in_message":[],"_revision_number":1},{"id":"94d31804b9603d12dbaea3c758430248c32b1784","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-11-23 12:44:29.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"08a1295050b8d9ea652a9626bc02e042eaf4a4e3","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-11-23 13:21:59.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15633/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14851/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"86b6468f1a1a8f135a7f5d9dc61ac53643fb4a58","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-11-23 16:34:36.000000000","message":"Patch Set 2:\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"a921a609f9991e96e8c0113d94fd88270a172da3","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-11-24 09:43:45.000000000","message":"Patch Set 2: Code-Review-1\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"1fd52582e9c4c52fa605c1cfdac64bc917af59b5","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-09-29 08:33:39.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"e990efc333d86f7ab5efdf61d132e727a3faf0d1","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-09-29 09:15:29.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit-build/16021/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit/16811/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"4127445dd53a74c05f31df6ac78e89da669c1f86","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-10-01 08:26:56.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"2dc030b90de0b373e6071033da58ded1418575ea","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-10-08 08:43:49.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"c412126d5144c2ac41d5295c07633d5c9dca38b9","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-10-08 08:46:12.000000000","message":"Change has been successfully cherry-picked as b991c416b7e1a070604be919d8762ffe0a930a3f","accounts_in_message":[],"_revision_number":4}],"current_revision":"b991c416b7e1a070604be919d8762ffe0a930a3f","revisions":{"536c614b89a066b6488c95e6d55e10103d02afbd":{"kind":"REWORK","_number":3,"created":"2022-09-29 08:33:39.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/45/6745/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/45/6745/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/45/6745/3 \u0026\u0026 git checkout -b change-6745 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/45/6745/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/45/6745/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/45/6745/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/45/6745/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/45/6745/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ae937791d35b0820e0bc9bf0ab134c2bebd113e4","subject":"flash/nor/rp2040: remove new line from error message"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2021-11-23 09:06:51.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-09-29 08:14:44.000000000","tz":120},"subject":"target/cortex_m: make reset robust again","message":"target/cortex_m: make reset robust again\n\nAfter merging [1] \u0027reset halt\u0027 does not work on not responding Cortex-M.\n\nRelax the examined tests and try to set vector catch VC_CORERESET\nif debug_ap is available.\n\nWhile on it add an info about examination state to debug logs.\n\nFixes: [1] commit 98d9f1168cbd (\"target: reset target examined flag if target::examine() fails\")\nChange-Id: Ie2e018610026180af5997d70231061a275f05c76\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"0015e2abd0fdcc15b63524d5cd2ab75078549ee2":{"kind":"REWORK","_number":2,"created":"2021-11-23 12:34:18.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/45/6745/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/45/6745/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/45/6745/2 \u0026\u0026 git checkout -b change-6745 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/45/6745/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/45/6745/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/45/6745/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/45/6745/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/45/6745/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"6900b31f06dcf8b68bfde30467fdc0dddbd6f2bb","subject":"doc: mention SWD multidrop"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2021-11-23 09:06:51.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2021-11-23 12:29:18.000000000","tz":60},"subject":"target/cortex_m: make reset robust again [WIP]","message":"target/cortex_m: make reset robust again [WIP]\n\nAfter merging [1] \u0027reset halt\u0027 does not work on not responding Cortex-M.\n\nRelax the examined tests and try to set vector catch VC_CORERESET\nif debug_ap is available.\n\nTry to re-examine after reset deassert.\n\n[1] 98d9f1168cbd (target: reset target examined flag if target::examine() fails)\n\nChange-Id: Ie2e018610026180af5997d70231061a275f05c76\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"8f20c8a4c04d0539adf3290463237dd8ec788346":{"kind":"REWORK","_number":1,"created":"2021-11-23 12:25:16.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/45/6745/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/45/6745/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/45/6745/1 \u0026\u0026 git checkout -b change-6745 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/45/6745/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/45/6745/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/45/6745/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/45/6745/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/45/6745/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"6900b31f06dcf8b68bfde30467fdc0dddbd6f2bb","subject":"doc: mention SWD multidrop"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2021-11-23 09:06:51.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2021-11-23 12:23:03.000000000","tz":60},"subject":"target/cortex_m: make reset robust again [WIP]","message":"target/cortex_m: make reset robust again [WIP]\n\nAfter merging [1] \u0027reset halt\u0027 does not work on not responding Cortex-M.\n\nRelax the examined tests and try to set vector catch VC_CORERESET\nif debug_ap is available.\n\nTry to re-examine after reset deassert.\n\n[1] 98d9f1168cbd (target: reset target examined flag if target::examine() fails)\n\nChange-Id: Ie2e018610026180af5997d70231061a275f05c76\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"b991c416b7e1a070604be919d8762ffe0a930a3f":{"kind":"REWORK","_number":4,"created":"2022-10-08 08:46:12.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/45/6745/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/45/6745/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/45/6745/4 \u0026\u0026 git checkout -b change-6745 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/45/6745/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/45/6745/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/45/6745/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/45/6745/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/45/6745/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"978c115dac5a2f420b9ef70207f384f09e380e35","subject":"openocd: fix build with \u0027configure --without-capstone\u0027"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2021-11-23 09:06:51.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-10-08 08:46:12.000000000","tz":0},"subject":"target/cortex_m: make reset robust again","message":"target/cortex_m: make reset robust again\n\nAfter merging [1] \u0027reset halt\u0027 does not work on not responding Cortex-M.\n\nRelax the examined tests and try to set vector catch VC_CORERESET\nif debug_ap is available.\n\nWhile on it add an info about examination state to debug logs.\n\nFixes: [1] commit 98d9f1168cbd (\"target: reset target examined flag if target::examine() fails\")\nChange-Id: Ie2e018610026180af5997d70231061a275f05c76\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6745\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}