)]}'
{"id":"openocd~master~I0c0a5221490945563e17a0a34d99a603f1d6c2ff","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2022-02-25 19:53:18.000000000","reason":"Change was submitted"},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2021-11-25 16:08:31.000000000","reason":"Tomas Vanek replied on the change"}},"hashtags":[],"change_id":"I0c0a5221490945563e17a0a34d99a603f1d6c2ff","subject":"target/cortex_m: fix target_to_cm() helper","status":"MERGED","created":"2021-11-25 11:06:31.000000000","updated":"2022-02-25 19:53:18.000000000","submitted":"2022-02-25 19:53:18.000000000","submitter":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6749","meta_rev_id":"761f41f9211456f14868d248c0a4247151fd9fe3","_number":6749,"owner":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-02-25 19:53:18.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-02-25 19:53:18.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-02-25 19:53:18.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-11-25 12:47:08.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-11-25 15:22:54.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"c9cea2972e93d37cdfe63261923725aacfb5e0a3","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-11-25 11:06:31.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"faff92825579bc5337b0e51b3f4a1e5080e7bc80","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-11-25 12:47:08.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15647/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14865/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"6e7eb1f024084ac479924439e28ca1583f320b13","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-11-25 15:22:54.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"1c802f559ded1ce4ee301bfb651c2d1114fa26b6","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-11-25 15:49:02.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"bcc51ae9c3dac1aeee928b49b71cac4ae4e23850","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-11-25 15:54:44.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"dbbe57f7e6a73787b9c379ccf2cbd729c26ab0f5","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-11-25 16:08:31.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"adc439533bd7a5ffcb11aa14241c044a2aa3d797","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-12-27 07:25:04.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"761f41f9211456f14868d248c0a4247151fd9fe3","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-02-25 19:53:18.000000000","message":"Change has been successfully cherry-picked as 10b5ac9ccb2b51b5aad01e4cb02be84fea3ebc62","accounts_in_message":[],"_revision_number":2}],"current_revision":"10b5ac9ccb2b51b5aad01e4cb02be84fea3ebc62","revisions":{"10b5ac9ccb2b51b5aad01e4cb02be84fea3ebc62":{"kind":"REWORK","_number":2,"created":"2022-02-25 19:53:18.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/49/6749/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/49/6749/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/49/6749/2 \u0026\u0026 git checkout -b change-6749 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/49/6749/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/49/6749/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/49/6749/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/49/6749/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/49/6749/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"29912328f07d562281e8a0db8855c8362afba546","subject":"flash/nor/stm32f2x: Fix erase of bank 2 sectors"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2021-11-24 18:05:21.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-02-25 19:53:18.000000000","tz":0},"subject":"target/cortex_m: fix target_to_cm() helper","message":"target/cortex_m: fix target_to_cm() helper\n\nThe third parameter of container_of() should point to the same member\nas target-\u003earch_info points to, struct arm.\n\nIt worked just because struct arm is the first member in\nstruct armv7m_common.\nIf you move arm member from the first place, OpenOCD fails heavily.\n\nChange-Id: I0c0a5221490945563e17a0a34d99a603f1d6c2ff\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6749\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"db3d5d4d12901341c044dedb59529b81068fcbb2":{"kind":"REWORK","_number":1,"created":"2021-11-25 11:06:31.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/49/6749/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/49/6749/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/49/6749/1 \u0026\u0026 git checkout -b change-6749 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/49/6749/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/49/6749/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/49/6749/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/49/6749/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/49/6749/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f66a16c4a06fde23ae25f39c92990aa049c3c970","subject":"target/hla_target: set cortex_m-\u003ecommon_magic"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2021-11-24 18:05:21.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2021-11-25 10:05:58.000000000","tz":60},"subject":"target/cortex_m: fix target_to_cm() helper","message":"target/cortex_m: fix target_to_cm() helper\n\nThe third parameter of container_of() should point to the same member\nas target-\u003earch_info points to, struct arm.\n\nIt worked just because struct arm is the first member in\nstruct armv7m_common.\nIf you move arm member from the first place, OpenOCD fails heavily.\n\nChange-Id: I0c0a5221490945563e17a0a34d99a603f1d6c2ff\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}