)]}'
{"id":"openocd~master~If90ef7e969ef04f0f2103e0da29dcbe8e1ac1c0d","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2021-12-27 07:25:11.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"If90ef7e969ef04f0f2103e0da29dcbe8e1ac1c0d","subject":"target/armv7m,cortex_m: introduce checked arch_info cast routines","status":"MERGED","created":"2021-11-25 11:06:31.000000000","updated":"2022-02-25 19:56:41.000000000","submitted":"2022-02-25 19:56:41.000000000","submitter":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6750","meta_rev_id":"3016c1ac89924574f41c1b3a59d9e3f68d514b10","_number":6750,"owner":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-02-25 19:56:41.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-02-25 19:56:41.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-02-25 19:56:41.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-11-25 12:29:24.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-11-25 15:25:31.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"0bebc08b9eb3587ce8bf39442838d0be98d76afc","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-11-25 11:06:31.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b5e8518461d07a1740d46dc63104ec92ab5b6b0b","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-11-25 12:29:24.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15648/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14864/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"f0cf5e9e589838653374c0b5ae9fcecb541a49e8","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-11-25 15:25:31.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"d2ed5cda87d1657ebe8c600cdca311717542b2ea","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-12-27 07:25:11.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"3016c1ac89924574f41c1b3a59d9e3f68d514b10","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-02-25 19:56:41.000000000","message":"Change has been successfully cherry-picked as e4ba76a003ce4a2336eade806a04a278c376d0b6","accounts_in_message":[],"_revision_number":2}],"current_revision":"e4ba76a003ce4a2336eade806a04a278c376d0b6","revisions":{"e4ba76a003ce4a2336eade806a04a278c376d0b6":{"kind":"REWORK","_number":2,"created":"2022-02-25 19:56:41.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/50/6750/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/50/6750/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/50/6750/2 \u0026\u0026 git checkout -b change-6750 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/50/6750/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/50/6750/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/50/6750/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/50/6750/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/50/6750/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"10b5ac9ccb2b51b5aad01e4cb02be84fea3ebc62","subject":"target/cortex_m: fix target_to_cm() helper"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2021-11-24 21:11:13.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-02-25 19:56:41.000000000","tz":0},"subject":"target/armv7m,cortex_m: introduce checked arch_info cast routines","message":"target/armv7m,cortex_m: introduce checked arch_info cast routines\n\ntarget_to_armv7m() and target_to_cm() do not match the magic number\nso they are not suitable for use outside of target driver code.\n\nAdd checked versions of pointer getters. Match the magic number\nto ensure the returned value points to struct of the correct type.\n\nChange-Id: If90ef7e969ef04f0f2103e0da29dcbe8e1ac1c0d\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6750\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"1d68bdf7ac033190caf5a5ad0afd805496136077":{"kind":"REWORK","_number":1,"created":"2021-11-25 11:06:31.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/50/6750/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/50/6750/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/50/6750/1 \u0026\u0026 git checkout -b change-6750 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/50/6750/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/50/6750/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/50/6750/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/50/6750/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/50/6750/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"db3d5d4d12901341c044dedb59529b81068fcbb2","subject":"target/cortex_m: fix target_to_cm() helper"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2021-11-24 21:11:13.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2021-11-25 10:06:26.000000000","tz":60},"subject":"target/armv7m,cortex_m: introduce checked arch_info cast routines","message":"target/armv7m,cortex_m: introduce checked arch_info cast routines\n\ntarget_to_armv7m() and target_to_cm() do not match the magic number\nso they are not suitable for use outside of target driver code.\n\nAdd checked versions of pointer getters. Match the magic number\nto ensure the returned value points to struct of the correct type.\n\nChange-Id: If90ef7e969ef04f0f2103e0da29dcbe8e1ac1c0d\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}