)]}'
{"id":"openocd~master~If2471af74ebfe22f14442f48ae109b2e1bb5fa3b","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2022-08-01 09:33:31.000000000","reason":"Removed by Tomas Vanek by clicking the attention icon"},"1000863":{"account":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"last_update":"2022-02-25 11:21:15.000000000","reason":"Tarek BOCHKATI replied on the change"}},"hashtags":[],"change_id":"If2471af74ebfe22f14442f48ae109b2e1bb5fa3b","subject":"flash/nor/stm32xx: fix segfault accessing Cortex-M part number","status":"MERGED","created":"2021-11-25 11:06:31.000000000","updated":"2022-08-01 09:33:31.000000000","submitted":"2022-02-25 20:28:02.000000000","submitter":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"total_comment_count":3,"unresolved_comment_count":1,"has_review_started":true,"submission_id":"6752","meta_rev_id":"a5eada03c8c3f45e829570f5c4af2fcc3b01c8a7","_number":6752,"owner":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-02-25 20:28:02.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-02-25 20:28:02.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-02-25 20:28:02.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-02-25 20:28:02.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-11-25 11:40:03.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"state":"REVIEWER"},{"updated":"2021-11-25 12:59:39.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-11-25 15:30:07.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"fa0cf10ceee3a560b8ccd2d53c793f0373d4f971","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-11-25 11:06:31.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5ff910fdab03084a0f3547edbe4405627a3f7e28","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-11-25 11:40:03.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"86a8a1560b40f0a92fbd844e5436e9038b8f5bf7","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-11-25 12:59:39.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15649/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14866/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"e73831ea7b07e3e1bc5139d12ff74adcb6f0db76","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-11-25 15:30:07.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"8f0198bdc12c737273f89e72e57c8d6939096390","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-12-27 07:25:32.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"30a7738bd5bca6ec1153b0c391c97a5836a88dce","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2022-02-25 11:21:15.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"aea2091834662fa8390d1d334ca2649469ce32d3","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-02-25 20:28:02.000000000","message":"Change has been successfully cherry-picked as 13cd75b6ecfd8d9cf04e56b182b6a162ad50247c","accounts_in_message":[],"_revision_number":2},{"id":"022e7ed0088b4e5c237915d50e160d9fc185371c","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2022-02-28 09:24:16.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2}],"current_revision":"13cd75b6ecfd8d9cf04e56b182b6a162ad50247c","revisions":{"13cd75b6ecfd8d9cf04e56b182b6a162ad50247c":{"kind":"REWORK","_number":2,"created":"2022-02-25 20:28:02.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/52/6752/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/52/6752/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/52/6752/2 \u0026\u0026 git checkout -b change-6752 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/52/6752/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/52/6752/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/52/6752/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/52/6752/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/52/6752/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b53f5c257185e5410622ed72790affb1bda88248","subject":"target/cortex_m: add Cortex-M part number getter"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2021-11-25 05:24:52.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-02-25 20:28:02.000000000","tz":0},"subject":"flash/nor/stm32xx: fix segfault accessing Cortex-M part number","message":"flash/nor/stm32xx: fix segfault accessing Cortex-M part number\n\nSome of STM32 flash drivers read Cortex-M part number from\ncortex_m-\u003ecore_info.\nIn corner cases the core_info pointer was observed uninitialised\neven if target_was_examined() returned true. See also [1]\n\nUse the new and safe helper to get Cortex-M part number.\n\nWhile on it switch also target_to_cm()/target_to_armv7m() to the safe\nversions. This prevents a crash when the flash bank is misconfigured\nwith non-Cortex-M target.\n\nAdd missing checks for target_was_examined() to flash probes.\n\n[1] 6545: fix crash in case cortex_m-\u003ecore_info is not set\n    https://review.openocd.org/c/openocd/+/6545\n\nChange-Id: If2471af74ebfe22f14442f48ae109b2e1bb5fa3b\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nFixes: f5898bd93ff8 (flash/stm32fxx.c: do not read CPUID as this info is stored in cortex_m_common)\nReviewed-on: https://review.openocd.org/c/openocd/+/6752\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-by: Tarek BOCHKATI \u003ctarek.bouchkati@gmail.com\u003e\n"}},"66bd3f1f13827e34a5769bae8f37ae62668b3486":{"kind":"REWORK","_number":1,"created":"2021-11-25 11:06:31.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/52/6752/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/52/6752/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/52/6752/1 \u0026\u0026 git checkout -b change-6752 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/52/6752/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/52/6752/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/52/6752/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/52/6752/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/52/6752/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"620afb0c83d1d9f4a4b0c0b50118daefd147c222","subject":"target/cortex_m: add Cortex-M part number getter"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2021-11-25 05:24:52.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2021-11-25 10:08:15.000000000","tz":60},"subject":"flash/nor/stm32xx: fix segfault accessing Cortex-M part number","message":"flash/nor/stm32xx: fix segfault accessing Cortex-M part number\n\nSome of STM32 flash drivers read Cortex-M part number from\ncortex_m-\u003ecore_info.\nIn corner cases the core_info pointer was observed uninitialised\neven if target_was_examined() returned true. See also [1]\n\nUse the new and safe helper to get Cortex-M part number.\n\nWhile on it switch also target_to_cm()/target_to_armv7m() to the safe\nversions. This prevents a crash when the flash bank is misconfigured\nwith non-Cortex-M target.\n\nAdd missing checks for target_was_examined() to flash probes.\n\n[1] 6545: fix crash in case cortex_m-\u003ecore_info is not set\n    https://review.openocd.org/c/openocd/+/6545\n\nChange-Id: If2471af74ebfe22f14442f48ae109b2e1bb5fa3b\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nFixes: f5898bd93ff8 (flash/stm32fxx.c: do not read CPUID as this info is stored in cortex_m_common)\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}