)]}'
{"id":"openocd~master~Ife4ed61edb09bbb4462ab4c30efde981fe9f485d","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2026-01-04 07:02:36.000000000","reason":"\u003cGERRIT_ACCOUNT_1000687\u003e replied on the change","reason_account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}},"1000863":{"account":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"last_update":"2022-02-25 11:29:23.000000000","reason":"Tarek BOCHKATI replied on the change"}},"hashtags":[],"change_id":"Ife4ed61edb09bbb4462ab4c30efde981fe9f485d","subject":"Revert \"target: reset target examined flag if target::examine() fails\"","status":"NEW","created":"2021-11-25 11:06:31.000000000","updated":"2026-01-04 07:02:36.000000000","submit_type":"CHERRY_PICK","mergeable":false,"submittable":false,"total_comment_count":6,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"cef7963c5cea0efae032b6d49d72f73884eb0ac6","_number":6753,"owner":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"_account_id":1002049,"name":"Erwan Gouriou","email":"erwan.gouriou@st.com","username":"erwango"},{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"value":1,"date":"2021-11-25 13:17:00.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"recommended":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"disliked":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"value":1,"date":"2022-09-29 13:00:27.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1002049,"name":"Erwan Gouriou","email":"erwan.gouriou@st.com","username":"erwango"},{"value":1,"date":"2022-04-11 18:06:13.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},{"value":-1,"date":"2026-01-04 07:02:36.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","value":-1,"default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},{"_account_id":1002049,"name":"Erwan Gouriou","email":"erwan.gouriou@st.com","username":"erwango"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-11-25 11:41:26.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"state":"REVIEWER"},{"updated":"2021-11-25 13:17:00.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-04-11 18:06:13.000000000","updated_by":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"reviewer":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"state":"REVIEWER"},{"updated":"2022-09-29 13:00:27.000000000","updated_by":{"_account_id":1002049,"name":"Erwan Gouriou","email":"erwan.gouriou@st.com","username":"erwango"},"reviewer":{"_account_id":1002049,"name":"Erwan Gouriou","email":"erwan.gouriou@st.com","username":"erwango"},"state":"REVIEWER"}],"messages":[{"id":"bb4c3681fa684224877953d42fd6d7966fc94399","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-11-25 11:06:31.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2cd1d2de31c74ed61f98ef1d09074d0186ea8d9e","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-11-25 13:17:00.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15650/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14867/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"f7ad1d1d051c882936221590bd1980759838d488","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2022-02-25 11:29:23.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"0374a950657d8a48d7dc5c6615097f0a185f5a7e","author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"real_author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"date":"2022-04-11 18:06:13.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"51c7a74adb0b7505b83a732ae3ab36b05b5f6e02","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-08-15 08:17:03.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"68b7f938f619c5062e9edbdd4d4374b162db799d","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-09-28 21:54:05.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"be9b5fb02bbe42d78b89a17ce1f082319a272e9a","author":{"_account_id":1002049,"name":"Erwan Gouriou","email":"erwan.gouriou@st.com","username":"erwango"},"real_author":{"_account_id":1002049,"name":"Erwan Gouriou","email":"erwan.gouriou@st.com","username":"erwango"},"date":"2022-09-29 13:00:27.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"cef7963c5cea0efae032b6d49d72f73884eb0ac6","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2026-01-04 07:02:36.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1}],"current_revision":"1157795f9f6cea2b9cfad7d92a5e17114bc7a27c","revisions":{"1157795f9f6cea2b9cfad7d92a5e17114bc7a27c":{"kind":"REWORK","_number":1,"created":"2021-11-25 11:06:31.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/53/6753/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/53/6753/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/53/6753/1 \u0026\u0026 git checkout -b change-6753 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/53/6753/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/53/6753/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/53/6753/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/53/6753/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/53/6753/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"66bd3f1f13827e34a5769bae8f37ae62668b3486","subject":"flash/nor/stm32xx: fix segfault accessing Cortex-M part number"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2021-11-24 05:10:19.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2021-11-25 11:05:11.000000000","tz":60},"subject":"Revert \"target: reset target examined flag if target::examine() fails\"","message":"Revert \"target: reset target examined flag if target::examine() fails\"\n\nThis reverts commit 98d9f1168cbdc59e4c2c0b1f01b225a4df9ad98a.\n\nThe target examined flag meaning evolved over the years of OpenOCD development\nand unfortunately different parts of code expect different working models\nof examined flag.\n\nSee [1], [2] and [3].\n\nKnown regression:\n\u0027reset halt\u0027 does not work on not responding Cortex-M target.\nIt is serious e.g. for a Kinetis MCU with blank flash. MCU runs in RESET/WDOG loop\nand cannot neither be stopped nor put under the control of OpenOCD.\n\nBased on analyse of the shift of the flag meaning we can also expect\nproblems in old, seldom used and difficult-to-test targets.\n\nRevert the commit in favour of not breaking upcoming 0.12 release\nand address the problem later.\n\nChange-Id: Ife4ed61edb09bbb4462ab4c30efde981fe9f485d\nLink: [1] https://review.openocd.org/gitweb?p\u003dopenocd.git;a\u003dcommit;h\u003d9ac7cdec82c19481b79f2effcefb7106dd7ade41\nLink: [2] 2151: target: reexamine after polling succeeds again | https://review.openocd.org/c/openocd/+/2151\nLink: [3] 3076: Add -defer-examine option to target create command | https://review.openocd.org/c/openocd/+/3076\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"NOT_READY","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"NEED"}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"]}}]}