)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1001422,"name":"Bohdan Tymkiv","email":"bohdan200@gmail.com","username":"bhdt"},"change_message_id":"8f09ccb4b16634fae63ab0936909bb22aaac14fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d7247048_5e6f54d1","updated":"2021-12-02 12:34:11.000000000","message":"Thanks for the review!\nSo, in my understanding tap-\u003ecur_instr is always in JTAG-s byte order (always LE?) while memory pointed by \u0026new_instr is in Host\u0027s byte order, correct? I was not aware of this. In this case Antonio\u0027s solution looks correct tome.","commit_id":"1dc9016743526a1b2cf8da6f4f1d143a570e8d4a"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"900e9a26407ca31f832b6ae1dfc7eeba61b9ac5a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1c611a0d_18c38621","updated":"2021-12-02 10:13:00.000000000","message":"Thanks, Bohdan, good catch!\n","commit_id":"1dc9016743526a1b2cf8da6f4f1d143a570e8d4a"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"32c25a4e189f358cd891d34ed416cc8409757f92","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"dc4a5007_36b35e88","updated":"2021-12-02 11:13:46.000000000","message":"indeed, good catch!","commit_id":"1dc9016743526a1b2cf8da6f4f1d143a570e8d4a"},{"author":{"_account_id":1001422,"name":"Bohdan Tymkiv","email":"bohdan200@gmail.com","username":"bhdt"},"change_message_id":"a69f2d6c8c73ba1afafe2e8b0977a1e6dd5fce25","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a4cacc94_a3c235e8","in_reply_to":"c79f5811_8f78584c","updated":"2021-12-02 13:11:52.000000000","message":"Thanks Tomas, I will submit a new patch in a moment...","commit_id":"1dc9016743526a1b2cf8da6f4f1d143a570e8d4a"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"863564c9f6c637a1ba42a9f09448f0ad9180ba9f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c79f5811_8f78584c","in_reply_to":"d7247048_5e6f54d1","updated":"2021-12-02 13:05:31.000000000","message":"Yes, exactly.","commit_id":"1dc9016743526a1b2cf8da6f4f1d143a570e8d4a"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"e74721929923c6a9620abd7e4bb2274ad34491b1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"de1dfb44_bc7dbf89","updated":"2021-12-11 17:49:23.000000000","message":"I cannot test this on ADIv6, by now. Would be interesting to get the speed improvement.\nLet\u0027s merge it, I will measure it once I get the board again.","commit_id":"69cb1553c25de44c1439be97ce7e081277e54bfb"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"e82aaa0fe6e98eecf325029e42512883b73c0407","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"26bc5729_beb1a048","updated":"2021-12-03 09:42:57.000000000","message":"Test on Kinetis K26, vsllink JTAG, adapter speed: 4000 kHz\n  \u003e load_image rand60kb.bin 0x20000000\n\ncurrent git master\n  downloaded 61440 bytes in 1.345302s (44.600 KiB/s)\n\n3f1c15d2a718 reverted:\n  downloaded 61440 bytes in 0.991947s (60.487 KiB/s)\n\nWith this change:\n  downloaded 61440 bytes in 0.999267s (60.044 KiB/s)\n\nThe speed is restored back.\n\nAntonio, do you want to test it on ADI v6?\n\n","commit_id":"69cb1553c25de44c1439be97ce7e081277e54bfb"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"8d15b7deddd68bd9979d9761491efcd7547e3bff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3f2e571b_a40418c9","in_reply_to":"26bc5729_beb1a048","updated":"2021-12-03 09:54:27.000000000","message":"I will probably have access to the ADIv6 platform next week.","commit_id":"69cb1553c25de44c1439be97ce7e081277e54bfb"}],"src/target/arm_jtag.h":[{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"900e9a26407ca31f832b6ae1dfc7eeba61b9ac5a","unresolved":true,"context_lines":[{"line_number":42,"context_line":"\t\tuint32_t new_instr, void *no_verify_capture, tap_state_t end_state)"},{"line_number":43,"context_line":"{"},{"line_number":44,"context_line":"\t/* inline most common code path */"},{"line_number":45,"context_line":"\tif (buf_get_u32(tap-\u003ecur_instr, 0, tap-\u003eir_length) !\u003d buf_get_u32((uint8_t *)\u0026new_instr, 0, tap-\u003eir_length))"},{"line_number":46,"context_line":"\t\treturn arm_jtag_set_instr_inner(tap, new_instr, no_verify_capture, end_state);"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"\treturn ERROR_OK;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"47f3374f_f04d6810","line":45,"range":{"start_line":45,"start_character":67,"end_line":45,"end_character":88},"updated":"2021-12-02 10:13:00.000000000","message":"Looks like an endianess problem.","commit_id":"1dc9016743526a1b2cf8da6f4f1d143a570e8d4a"},{"author":{"_account_id":1000005,"name":"Andreas Fritiofson","email":"andreas.fritiofson@gmail.com","username":"Nattgris"},"change_message_id":"47b722acc9333d04ec9cb2865380b5935b041028","unresolved":true,"context_lines":[{"line_number":42,"context_line":"\t\tuint32_t new_instr, void *no_verify_capture, tap_state_t end_state)"},{"line_number":43,"context_line":"{"},{"line_number":44,"context_line":"\t/* inline most common code path */"},{"line_number":45,"context_line":"\tif (buf_get_u32(tap-\u003ecur_instr, 0, tap-\u003eir_length) !\u003d buf_get_u32((uint8_t *)\u0026new_instr, 0, tap-\u003eir_length))"},{"line_number":46,"context_line":"\t\treturn arm_jtag_set_instr_inner(tap, new_instr, no_verify_capture, end_state);"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"\treturn ERROR_OK;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"fa3a815e_f6548d2a","line":45,"range":{"start_line":45,"start_character":55,"end_line":45,"end_character":88},"updated":"2021-12-02 10:14:36.000000000","message":"What this does will depend on the host byte order. Needs to be done without pointer casts.","commit_id":"1dc9016743526a1b2cf8da6f4f1d143a570e8d4a"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"32c25a4e189f358cd891d34ed416cc8409757f92","unresolved":true,"context_lines":[{"line_number":42,"context_line":"\t\tuint32_t new_instr, void *no_verify_capture, tap_state_t end_state)"},{"line_number":43,"context_line":"{"},{"line_number":44,"context_line":"\t/* inline most common code path */"},{"line_number":45,"context_line":"\tif (buf_get_u32(tap-\u003ecur_instr, 0, tap-\u003eir_length) !\u003d buf_get_u32((uint8_t *)\u0026new_instr, 0, tap-\u003eir_length))"},{"line_number":46,"context_line":"\t\treturn arm_jtag_set_instr_inner(tap, new_instr, no_verify_capture, end_state);"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"\treturn ERROR_OK;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"7f3334cb_59491dcd","line":45,"updated":"2021-12-02 11:13:46.000000000","message":"maybe only masking out the unused bits, e.g.:\nif (buf_get_u32(tap-\u003ecur_instr, 0, tap-\u003eir_length) !\u003d (new_instr \u0026 (BIT(tap-\u003eir_length) - 1)))","commit_id":"1dc9016743526a1b2cf8da6f4f1d143a570e8d4a"},{"author":{"_account_id":1001422,"name":"Bohdan Tymkiv","email":"bohdan200@gmail.com","username":"bhdt"},"change_message_id":"a69f2d6c8c73ba1afafe2e8b0977a1e6dd5fce25","unresolved":false,"context_lines":[{"line_number":42,"context_line":"\t\tuint32_t new_instr, void *no_verify_capture, tap_state_t end_state)"},{"line_number":43,"context_line":"{"},{"line_number":44,"context_line":"\t/* inline most common code path */"},{"line_number":45,"context_line":"\tif (buf_get_u32(tap-\u003ecur_instr, 0, tap-\u003eir_length) !\u003d buf_get_u32((uint8_t *)\u0026new_instr, 0, tap-\u003eir_length))"},{"line_number":46,"context_line":"\t\treturn arm_jtag_set_instr_inner(tap, new_instr, no_verify_capture, end_state);"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"\treturn ERROR_OK;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"6a93d405_f6d6f757","line":45,"range":{"start_line":45,"start_character":67,"end_line":45,"end_character":88},"in_reply_to":"47f3374f_f04d6810","updated":"2021-12-02 13:11:52.000000000","message":"Done","commit_id":"1dc9016743526a1b2cf8da6f4f1d143a570e8d4a"},{"author":{"_account_id":1001422,"name":"Bohdan Tymkiv","email":"bohdan200@gmail.com","username":"bhdt"},"change_message_id":"a69f2d6c8c73ba1afafe2e8b0977a1e6dd5fce25","unresolved":false,"context_lines":[{"line_number":42,"context_line":"\t\tuint32_t new_instr, void *no_verify_capture, tap_state_t end_state)"},{"line_number":43,"context_line":"{"},{"line_number":44,"context_line":"\t/* inline most common code path */"},{"line_number":45,"context_line":"\tif (buf_get_u32(tap-\u003ecur_instr, 0, tap-\u003eir_length) !\u003d buf_get_u32((uint8_t *)\u0026new_instr, 0, tap-\u003eir_length))"},{"line_number":46,"context_line":"\t\treturn arm_jtag_set_instr_inner(tap, new_instr, no_verify_capture, end_state);"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"\treturn ERROR_OK;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"28b9837b_b1974ec1","line":45,"in_reply_to":"7f3334cb_59491dcd","updated":"2021-12-02 13:11:52.000000000","message":"Done","commit_id":"1dc9016743526a1b2cf8da6f4f1d143a570e8d4a"},{"author":{"_account_id":1001422,"name":"Bohdan Tymkiv","email":"bohdan200@gmail.com","username":"bhdt"},"change_message_id":"a69f2d6c8c73ba1afafe2e8b0977a1e6dd5fce25","unresolved":false,"context_lines":[{"line_number":42,"context_line":"\t\tuint32_t new_instr, void *no_verify_capture, tap_state_t end_state)"},{"line_number":43,"context_line":"{"},{"line_number":44,"context_line":"\t/* inline most common code path */"},{"line_number":45,"context_line":"\tif (buf_get_u32(tap-\u003ecur_instr, 0, tap-\u003eir_length) !\u003d buf_get_u32((uint8_t *)\u0026new_instr, 0, tap-\u003eir_length))"},{"line_number":46,"context_line":"\t\treturn arm_jtag_set_instr_inner(tap, new_instr, no_verify_capture, end_state);"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"\treturn ERROR_OK;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"99ddc47a_a7de2e27","line":45,"range":{"start_line":45,"start_character":55,"end_line":45,"end_character":88},"in_reply_to":"fa3a815e_f6548d2a","updated":"2021-12-02 13:11:52.000000000","message":"Done","commit_id":"1dc9016743526a1b2cf8da6f4f1d143a570e8d4a"}]}