)]}'
{"id":"openocd~master~I7cf9bf77742964b4f377c9ce48ca689e57d0882f","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1001242":{"account":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"last_update":"2022-05-20 16:51:04.000000000","reason":"Tim Newsome replied on the change"},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2022-05-21 09:15:26.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I7cf9bf77742964b4f377c9ce48ca689e57d0882f","subject":"flash/nor/core, target: don\u0027t ask for working mem if no target algo","status":"MERGED","created":"2021-12-06 22:38:11.000000000","updated":"2022-05-29 15:47:21.000000000","submitted":"2022-05-29 15:47:21.000000000","submitter":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6765","meta_rev_id":"d5995577dcf95200b165055077e8b6137ee164b0","_number":6765,"owner":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-05-29 15:47:21.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-05-29 15:47:21.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-05-29 15:47:21.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-12-06 22:52:44.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-05-20 08:41:41.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"state":"REVIEWER"}],"messages":[{"id":"0e960763d24744549a84196347145197c93c0f5b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-12-06 22:38:11.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"57cb3793c89e6b0877078e50fb09e66af8fbdad9","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-12-06 22:52:44.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15685/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14902/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"11d71aeb8534308816912f7d41416302bd1db30c","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-05-20 08:41:41.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"c8904c35c6a75ad2a1354233385d782180e648aa","author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"real_author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"date":"2022-05-20 16:51:04.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"cdc3e32c3c62d2b4871485cb8239107b103ee86a","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-05-21 09:15:26.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"d5995577dcf95200b165055077e8b6137ee164b0","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-05-29 15:47:21.000000000","message":"Change has been successfully cherry-picked as cc8b491856c9fee675732dc21a2307f5c9617f54","accounts_in_message":[],"_revision_number":2}],"current_revision":"cc8b491856c9fee675732dc21a2307f5c9617f54","revisions":{"da21e7beb68af1ce2336bde6478d21c7ab4a38b6":{"kind":"REWORK","_number":1,"created":"2021-12-06 22:38:11.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/65/6765/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/65/6765/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/65/6765/1 \u0026\u0026 git checkout -b change-6765 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/65/6765/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/65/6765/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/65/6765/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/65/6765/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/65/6765/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b1de11616099fe97f3534fa0f268c10dfd6ecf2b","subject":"gdb_server: added and improved several debug prints"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2021-11-19 21:03:44.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2021-12-06 22:34:19.000000000","tz":60},"subject":"flash/nor/core, target: don\u0027t ask for working mem if no target algo","message":"flash/nor/core, target: don\u0027t ask for working mem if no target algo\n\nThe command \u0027flash erase_check\u0027 showed the message\n\u0027Running slow fallback erase check - add working memory\u0027\neven in the case the target didn\u0027t implement blank_check_memory.\n\nChange return code of target_blank_check_memory() in this case\nand sense it in default_flash_blank_check() and show a message\nwithout a request for working memory.\n\nChange-Id: I7cf9bf77742964b4f377c9ce48ca689e57d0882f\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"cc8b491856c9fee675732dc21a2307f5c9617f54":{"kind":"REWORK","_number":2,"created":"2022-05-29 15:47:21.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/65/6765/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/65/6765/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/65/6765/2 \u0026\u0026 git checkout -b change-6765 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/65/6765/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/65/6765/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/65/6765/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/65/6765/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/65/6765/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"bce93f6d513b373c1fbfb42a12cfeb2305d5e822","subject":"Give each SMP group a unique number."}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2021-11-19 21:03:44.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-05-29 15:47:21.000000000","tz":0},"subject":"flash/nor/core, target: don\u0027t ask for working mem if no target algo","message":"flash/nor/core, target: don\u0027t ask for working mem if no target algo\n\nThe command \u0027flash erase_check\u0027 showed the message\n\u0027Running slow fallback erase check - add working memory\u0027\neven in the case the target didn\u0027t implement blank_check_memory.\n\nChange return code of target_blank_check_memory() in this case\nand sense it in default_flash_blank_check() and show a message\nwithout a request for working memory.\n\nChange-Id: I7cf9bf77742964b4f377c9ce48ca689e57d0882f\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6765\nTested-by: jenkins\nReviewed-by: Tim Newsome \u003ctim@sifive.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}