)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"d4d9ad110833a3f45332ddf73223b90b45a27eaf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"769ffc08_e2e3a288","updated":"2021-12-08 22:25:43.000000000","message":"Agree, but not enough.","commit_id":"42b24d002ef68bb9f8e1105ba170d95a62fe85cb"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"6f411c4970d6f3d4e4924e25afc70dbedce8570a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e9d0268a_f43af73e","updated":"2021-12-09 10:08:46.000000000","message":"Fair enough! Thanks","commit_id":"42b24d002ef68bb9f8e1105ba170d95a62fe85cb"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"96a682bef358128938eb3c6b0ad2673dc4b2a938","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"69e5a847_cb769a38","updated":"2021-12-09 09:34:49.000000000","message":"Simon, could you please take a look to other memory leaks pointed by Antonio? Thanks","commit_id":"42b24d002ef68bb9f8e1105ba170d95a62fe85cb"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"96a682bef358128938eb3c6b0ad2673dc4b2a938","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f38a4e51_0491f9c0","in_reply_to":"769ffc08_e2e3a288","updated":"2021-12-09 09:34:49.000000000","message":"\u003e Agree, but not enough.\n\nDid I say I fixed *ALL* leaks from libusb usage including error path? Certainly *NOT*.\nIs the driver less broken with the change than before? I think it is.\nI\u0027m focused to other work. I checked it by valgrind and made this change as a side effect without complete analysis of vsllink code. valgrind is now happy and it\u0027s enough for me.\n\nIt\u0027s nice you found some more problems. I\u0027m reluctant to dig into vsllink code now. Let\u0027s see if Simon could help us.","commit_id":"42b24d002ef68bb9f8e1105ba170d95a62fe85cb"}],"src/jtag/drivers/vsllink.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"d4d9ad110833a3f45332ddf73223b90b45a27eaf","unresolved":true,"context_lines":[{"line_number":287,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":288,"context_line":"\t}"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"\tlibusb_init(\u0026vsllink_handle-\u003elibusb_ctx);"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"\tif (vsllink_usb_open(vsllink_handle) !\u003d ERROR_OK) {"},{"line_number":293,"context_line":"\t\tLOG_ERROR(\"Can\u0027t find USB JTAG Interface!\""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"138bca11_e1adc8d2","line":290,"updated":"2021-12-08 22:25:43.000000000","message":"to balance this libusb_init(), in case of error ...","commit_id":"42b24d002ef68bb9f8e1105ba170d95a62fe85cb"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"d4d9ad110833a3f45332ddf73223b90b45a27eaf","unresolved":true,"context_lines":[{"line_number":292,"context_line":"\tif (vsllink_usb_open(vsllink_handle) !\u003d ERROR_OK) {"},{"line_number":293,"context_line":"\t\tLOG_ERROR(\"Can\u0027t find USB JTAG Interface!\""},{"line_number":294,"context_line":"\t\t\t\"Please check connection and permissions.\");"},{"line_number":295,"context_line":"\t\treturn ERROR_JTAG_INIT_FAILED;"},{"line_number":296,"context_line":"\t}"},{"line_number":297,"context_line":"\tLOG_DEBUG(\"vsllink found on %04X:%04X\","},{"line_number":298,"context_line":"\t\tversaloon_interface.usb_setting.vid,"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"6b0a3358_2e58e951","line":295,"updated":"2021-12-08 22:25:43.000000000","message":"... we need libusb_exit() also here ...","commit_id":"42b24d002ef68bb9f8e1105ba170d95a62fe85cb"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"d4d9ad110833a3f45332ddf73223b90b45a27eaf","unresolved":true,"context_lines":[{"line_number":300,"context_line":"\tversaloon_usb_device_handle \u003d vsllink_handle-\u003eusb_device_handle;"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"\tif (versaloon_interface.init() !\u003d ERROR_OK)"},{"line_number":303,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":304,"context_line":"\tif (versaloon_interface.usb_setting.buf_size \u003c 32) {"},{"line_number":305,"context_line":"\t\tversaloon_interface.fini();"},{"line_number":306,"context_line":"\t\treturn ERROR_FAIL;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"32ec47e4_d2f8c97a","line":303,"updated":"2021-12-08 22:25:43.000000000","message":"... and here ...","commit_id":"42b24d002ef68bb9f8e1105ba170d95a62fe85cb"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"d4d9ad110833a3f45332ddf73223b90b45a27eaf","unresolved":true,"context_lines":[{"line_number":303,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":304,"context_line":"\tif (versaloon_interface.usb_setting.buf_size \u003c 32) {"},{"line_number":305,"context_line":"\t\tversaloon_interface.fini();"},{"line_number":306,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":307,"context_line":"\t}"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"\treturn ERROR_OK;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"e54f28f9_ba55a594","line":306,"updated":"2021-12-08 22:25:43.000000000","message":"... and here.","commit_id":"42b24d002ef68bb9f8e1105ba170d95a62fe85cb"}]}