)]}'
{"id":"openocd~master~Ia947204944a8b549f3c2be7fb2f717aad18970c4","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2021-12-18 17:23:04.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ia947204944a8b549f3c2be7fb2f717aad18970c4","subject":"target/cortex_m: minor refactoring in cortex_m_store_core_reg_u32()","status":"MERGED","created":"2021-12-09 09:58:50.000000000","updated":"2021-12-18 17:23:04.000000000","submitted":"2021-12-18 17:23:04.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6767","meta_rev_id":"eb572436730f084bb4b0ac0c5ef6c13849e248c6","_number":6767,"owner":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-12-18 17:23:04.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-12-18 17:23:04.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-12-09 10:17:24.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-12-09 14:26:25.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"6524f8f6aa3a9936722fa2d7a7082f71521c8adf","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-12-09 09:58:50.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d2f343f31656f82b612158b21ae70ea432cdafff","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-12-09 10:17:24.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15689/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14906/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"d86ecfb113a7c37e77422e00e62c4da8330260f5","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-12-09 14:26:25.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"eb572436730f084bb4b0ac0c5ef6c13849e248c6","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-12-18 17:23:04.000000000","message":"Change has been successfully cherry-picked as 33fa237b2ffdfc24b7e0c0861ac7708b21431c8c","accounts_in_message":[],"_revision_number":2}],"current_revision":"33fa237b2ffdfc24b7e0c0861ac7708b21431c8c","revisions":{"6feaff57730c3e6a7741013060bb70800495ba0f":{"kind":"REWORK","_number":1,"created":"2021-12-09 09:58:50.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/67/6767/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/67/6767/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/67/6767/1 \u0026\u0026 git checkout -b change-6767 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/67/6767/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/67/6767/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/67/6767/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/67/6767/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/67/6767/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b1de11616099fe97f3534fa0f268c10dfd6ecf2b","subject":"gdb_server: added and improved several debug prints"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2021-12-08 21:11:32.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2021-12-09 09:57:03.000000000","tz":60},"subject":"target/cortex_m: minor refactoring in cortex_m_store_core_reg_u32()","message":"target/cortex_m: minor refactoring in cortex_m_store_core_reg_u32()\n\nUnlike cortex_m_load_core_reg_u32() storing core register uses\nthe same code pattern around DHCSR read as offered by the convenience\nhelper cortex_m_read_dhcsr_atomic_sticky().\n\nUse the helper.\n\nChange-Id: Ia947204944a8b549f3c2be7fb2f717aad18970c4\nSeeAlso: 65d762918328 (cortex_m: poll S_REGRDY on register r/w)\nSeeAlso: 0dcf95c7171b (target/cortex_m: cumulate DHCSR sticky bits)\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"33fa237b2ffdfc24b7e0c0861ac7708b21431c8c":{"kind":"REWORK","_number":2,"created":"2021-12-18 17:23:04.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/67/6767/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/67/6767/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/67/6767/2 \u0026\u0026 git checkout -b change-6767 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/67/6767/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/67/6767/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/67/6767/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/67/6767/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/67/6767/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1e07079dee083255eb84fdebdfd4ed4c30e82812","subject":"jtag/drivers/vsllink: fix memory leak"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2021-12-08 21:11:32.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-12-18 17:23:04.000000000","tz":0},"subject":"target/cortex_m: minor refactoring in cortex_m_store_core_reg_u32()","message":"target/cortex_m: minor refactoring in cortex_m_store_core_reg_u32()\n\nUnlike cortex_m_load_core_reg_u32() storing core register uses\nthe same code pattern around DHCSR read as offered by the convenience\nhelper cortex_m_read_dhcsr_atomic_sticky().\n\nUse the helper.\n\nChange-Id: Ia947204944a8b549f3c2be7fb2f717aad18970c4\nSeeAlso: 65d762918328 (cortex_m: poll S_REGRDY on register r/w)\nSeeAlso: 0dcf95c7171b (target/cortex_m: cumulate DHCSR sticky bits)\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6767\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}