)]}'
{"id":"openocd~master~Id68c352ce44dd85a1ea3d67446e17e2a241ef058","project":"openocd","branch":"master","topic":"keepalive","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2024-03-02 11:05:47.000000000","reason":"Change was submitted"},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2021-12-26 17:58:59.000000000","reason":"Tomas Vanek replied on the change"}},"hashtags":[],"change_id":"Id68c352ce44dd85a1ea3d67446e17e2a241ef058","subject":"gdb_server: don\u0027t send unrequested ACK at connection","status":"MERGED","created":"2021-12-09 17:14:53.000000000","updated":"2024-03-02 11:05:47.000000000","submitted":"2024-03-02 11:05:47.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":5,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6768-keepalive","meta_rev_id":"e8af7ee153e62c7909a27a69c40c02b9fba706f4","_number":6768,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},{"value":0,"_account_id":1002161,"name":"Anatoly P","email":"kupokupokupopo@gmail.com","username":"ecco_the_dolphin"},{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-03-02 11:05:47.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-03-02 11:05:47.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-03-02 11:05:47.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1002161,"name":"Anatoly P","email":"kupokupokupopo@gmail.com","username":"ecco_the_dolphin"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-03-02 11:05:47.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-03-02 11:05:47.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},{"_account_id":1002161,"name":"Anatoly P","email":"kupokupokupopo@gmail.com","username":"ecco_the_dolphin"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-12-09 22:18:51.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-12-11 18:09:41.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"},{"updated":"2024-02-26 13:32:27.000000000","updated_by":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"reviewer":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"state":"REVIEWER"},{"updated":"2024-03-01 05:17:31.000000000","updated_by":{"_account_id":1002161,"name":"Anatoly P","email":"kupokupokupopo@gmail.com","username":"ecco_the_dolphin"},"reviewer":{"_account_id":1002161,"name":"Anatoly P","email":"kupokupokupopo@gmail.com","username":"ecco_the_dolphin"},"state":"REVIEWER"}],"messages":[{"id":"047af3ce6e5515a3771be1914c0390cc36d47f94","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-12-09 17:14:53.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8b09219ec88c869e58dd59ffed983c7eba2098e0","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-12-09 21:42:54.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"6a5789915271d31d816533072d06c5f644cb372f","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-12-09 22:18:51.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15693/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14910/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"643244badc71bf150676b496bf4b1f4a47771747","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-12-11 18:09:26.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"6f731a341b0771466101f1fc624e51693287e396","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-12-26 17:58:59.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"1f69088fae9f6fc6be178cf9b7ef1dbc1c326369","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-12-26 21:37:38.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"227b84a326c39246237389a02ab26d8696ce7106","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-12-27 07:15:34.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"2e3ea79034503686c42fd3c3b745fce0ffc2bc74","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-02-03 22:39:35.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.","accounts_in_message":[],"_revision_number":3},{"id":"bad2df1ad39cd933aa69efa1de1a129b525e9a8f","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-02-03 23:54:14.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15830/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/15042/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"afa0f4ed00cf58ecaed772e79e789731875bfbf2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-02-26 15:59:59.000000000","message":"Uploaded patch set 4: Code-Review+1: Patch Set 3 was rebased.","accounts_in_message":[],"_revision_number":4},{"id":"6a530c60cc691a2bf0a0ca991d904d7ff8aad34a","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-02-26 19:09:29.000000000","message":"Patch Set 4: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15903/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/15112/ : SUCCESS","accounts_in_message":[],"_revision_number":4},{"id":"9441df9739d86bd3c55e1d42d90e6ae076cc1060","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-02-25 20:28:01.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"ed5798e4a71f6e474dabf8051f25e0a89c890743","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2024-02-25 20:36:23.000000000","message":"Patch Set 4: Code-Review+1","accounts_in_message":[],"_revision_number":4},{"id":"52a20fef2674ec2c3cfc38ff58b43dc8d7bc84d8","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2024-02-26 13:32:27.000000000","message":"Patch Set 4: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"6636ab91b127ba240d6ab93edee003ca6f476b70","author":{"_account_id":1002161,"name":"Anatoly P","email":"kupokupokupopo@gmail.com","username":"ecco_the_dolphin"},"real_author":{"_account_id":1002161,"name":"Anatoly P","email":"kupokupokupopo@gmail.com","username":"ecco_the_dolphin"},"date":"2024-03-01 05:17:31.000000000","message":"Patch Set 4: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"e8af7ee153e62c7909a27a69c40c02b9fba706f4","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2024-03-02 11:05:47.000000000","message":"Change has been successfully cherry-picked as 07141132a7d787005c0829618a60b4a842be7847","accounts_in_message":[],"_revision_number":5}],"current_revision":"07141132a7d787005c0829618a60b4a842be7847","revisions":{"07141132a7d787005c0829618a60b4a842be7847":{"kind":"REWORK","_number":5,"created":"2024-03-02 11:05:47.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/68/6768/5","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/68/6768/5","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/68/6768/5 \u0026\u0026 git checkout -b change-6768 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/68/6768/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/68/6768/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/68/6768/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/68/6768/5","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/68/6768/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"271c4e5253abcd2ec617d5fb5e1a374d2b6a543d","subject":"target/esp_xtensa_smp: don\u0027t use coreid as an SMP index"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-12-03 23:48:23.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2024-03-02 11:05:47.000000000","tz":0},"subject":"gdb_server: don\u0027t send unrequested ACK at connection","message":"gdb_server: don\u0027t send unrequested ACK at connection\n\nOn 2008-03-05, before git\u0027s age, commit 6d9501467441 adds sending\nan ACK (\u0027+\u0027 char) at GDB connection, before receiving any GDB\nremote command that requires to be ACK\u0027ed.\n\nNeither the text added in the commit message (\"added ACK upon\nconnection (send +)\") nor in the associated comment (\"send ACK to\nGDB for debug request\") provide an exhaustive explanation for\nsending this unsolicited ACK.\n\nThis code has never been touched since its introduction.\n\nAnalysis of GDB code doesn\u0027t show it\u0027s required, including old GDB\ncode.\nRunning gdbserver (from GDB package) and attaching it with \"nc\"\nshows that gdbserver does not send any ACK to a new connection.\nSame for lldb-server.\n\nDrop it!\n\nChange-Id: Id68c352ce44dd85a1ea3d67446e17e2a241ef058\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6768\nTested-by: jenkins\nReviewed-by: Jan Matyas \u003cjan.matyas@codasip.com\u003e\nReviewed-by: Anatoly P \u003canatoly.parshintsev@syntacore.com\u003e\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"dfbf2eb60b756f66a665e42d1f796a5006395838":{"kind":"TRIVIAL_REBASE","_number":4,"created":"2022-02-26 15:59:59.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/68/6768/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/68/6768/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/68/6768/4 \u0026\u0026 git checkout -b change-6768 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/68/6768/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/68/6768/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/68/6768/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/68/6768/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/68/6768/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"0799e84ce09b12d94bb11a52709563093e04c0b6","subject":"server: rework add_connection() and reject connection()"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-12-03 23:48:23.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-02-26 15:49:56.000000000","tz":60},"subject":"gdb_server: don\u0027t send unrequested ACK at connection","message":"gdb_server: don\u0027t send unrequested ACK at connection\n\nOn 2008-03-05, before git\u0027s age, commit 6d9501467441 adds sending\nan ACK (\u0027+\u0027 char) at GDB connection, before receiving any GDB\nremote command that requires to be ACK\u0027ed.\n\nNeither the text added in the commit message (\"added ACK upon\nconnection (send +)\") nor in the associated comment (\"send ACK to\nGDB for debug request\") provide an exhaustive explanation for\nsending this unsolicited ACK.\n\nThis code has never been touched since its introduction.\n\nAnalysis of GDB code doesn\u0027t show it\u0027s required, including old GDB\ncode.\nRunning gdbserver (from GDB package) and attaching it with \"nc\"\nshows that gdbserver does not send any ACK to a new connection.\nSame for lldb-server.\n\nDrop it!\n\nChange-Id: Id68c352ce44dd85a1ea3d67446e17e2a241ef058\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"797517ea9247fae6044a32fa33f86e3fffb0126c":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2022-02-03 22:39:35.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/68/6768/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/68/6768/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/68/6768/3 \u0026\u0026 git checkout -b change-6768 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/68/6768/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/68/6768/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/68/6768/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/68/6768/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/68/6768/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"8d0998995fb99a76fd36f315d68bce33fb7d10ce","subject":"server: rework add_connection() and reject connection()"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-12-03 23:48:23.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-02-03 22:37:32.000000000","tz":60},"subject":"gdb_server: don\u0027t send unrequested ACK at connection","message":"gdb_server: don\u0027t send unrequested ACK at connection\n\nOn 2008-03-05, before git\u0027s age, commit 6d9501467441 adds sending\nan ACK (\u0027+\u0027 char) at GDB connection, before receiving any GDB\nremote command that requires to be ACK\u0027ed.\n\nNeither the text added in the commit message (\"added ACK upon\nconnection (send +)\") nor in the associated comment (\"send ACK to\nGDB for debug request\") provide an exhaustive explanation for\nsending this unsolicited ACK.\n\nThis code has never been touched since its introduction.\n\nAnalysis of GDB code doesn\u0027t show it\u0027s required, including old GDB\ncode.\nRunning gdbserver (from GDB package) and attaching it with \"nc\"\nshows that gdbserver does not send any ACK to a new connection.\nSame for lldb-server.\n\nDrop it!\n\nChange-Id: Id68c352ce44dd85a1ea3d67446e17e2a241ef058\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"d5a0e844349cf533b8745d033e7f94fed9da29a9":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2021-12-09 21:42:54.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/68/6768/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/68/6768/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/68/6768/2 \u0026\u0026 git checkout -b change-6768 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/68/6768/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/68/6768/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/68/6768/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/68/6768/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/68/6768/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"98b62328a77876b5324e6dff182cf61fb91bba4f","subject":"openocd: add keep_alive during command sleep"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-12-03 23:48:23.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-12-09 21:42:22.000000000","tz":60},"subject":"gdb_server: don\u0027t send unrequested ACK at connection","message":"gdb_server: don\u0027t send unrequested ACK at connection\n\nOn 2008-03-05, before git\u0027s age, commit 6d9501467441 adds sending\nan ACK (\u0027+\u0027 char) at GDB connection, before receiving any GDB\nremote command that requires to be ACK\u0027ed.\n\nNeither the text added in the commit message (\"added ACK upon\nconnection (send +)\") nor in the associated comment (\"send ACK to\nGDB for debug request\") provide an exhaustive explanation for\nsending this unsolicited ACK.\n\nThis code has never been touched since its introduction.\n\nAnalysis of GDB code doesn\u0027t show it\u0027s required, including old GDB\ncode.\nRunning gdbserver (from GDB package) and attaching it with \"nc\"\nshows that gdbserver does not send any ACK to a new connection.\nSame for lldb-server.\n\nDrop it!\n\nChange-Id: Id68c352ce44dd85a1ea3d67446e17e2a241ef058\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"12e460a926098777006a777aab41c917af671c95":{"kind":"REWORK","_number":1,"created":"2021-12-09 17:14:53.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/68/6768/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/68/6768/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/68/6768/1 \u0026\u0026 git checkout -b change-6768 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/68/6768/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/68/6768/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/68/6768/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/68/6768/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/68/6768/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b1de11616099fe97f3534fa0f268c10dfd6ecf2b","subject":"gdb_server: added and improved several debug prints"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-12-03 23:48:23.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-12-09 15:55:14.000000000","tz":60},"subject":"gdb_server: don\u0027t send unrequested ACK at connection","message":"gdb_server: don\u0027t send unrequested ACK at connection\n\nOn 2008-03-05, before git\u0027s age, commit 6d9501467441 adds sending\nan ACK (\u0027+\u0027 char) at GDB connection, before receiving any GDB\nremote command that requires to be ACK\u0027ed.\n\nNeither the text added in the commit message (\"added ACK upon\nconnection (send +)\") nor in the associated comment (\"send ACK to\nGDB for debug request\") provide an exhaustive explanation for\nsending this unsolicited ACK.\n\nThis code has never been touched since its introduction.\n\nAnalysis of GDB code doesn\u0027t show it\u0027s required, including old GDB\ncode.\nRunning gdbserver (from GDB package) and attaching it with \"nc\"\nshows that gdbserver does not send any ACK to a new connection.\nSame for lldb-server.\n\nDrop it!\n\nChange-Id: Id68c352ce44dd85a1ea3d67446e17e2a241ef058\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}