)]}'
{"id":"openocd~master~I574a8013e7d159d1c71087af83b7c2ce92be86bd","project":"openocd","branch":"master","hashtags":[],"change_id":"I574a8013e7d159d1c71087af83b7c2ce92be86bd","subject":"gdb_server: fix a comment in gdb_new_connection()","status":"MERGED","created":"2021-12-09 17:14:53.000000000","updated":"2021-12-18 17:26:36.000000000","submitted":"2021-12-18 17:26:36.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6769","meta_rev_id":"1a8f6e87e656bcb3f2d66250d9c912e1ef598a6d","_number":6769,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-12-18 17:26:36.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-12-18 17:26:36.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-12-09 22:36:56.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"3514e00fd8d4e02f2198eb9470a23c684453d0de","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-12-09 17:14:53.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b31f8803d53aaf76d6f4605ab93426a0e88b8bd0","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-12-09 21:42:54.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"a59c3d3d526a64d9f931e64eddfd984b7d8508bd","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-12-09 22:36:56.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15694/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14911/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"7a18655628084e92ad645d5c9f0b47b528006579","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-12-11 18:09:58.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"b396c0026d313e64c738ef7a298092e5c2acbd3b","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-12-18 17:26:27.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"1a8f6e87e656bcb3f2d66250d9c912e1ef598a6d","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-12-18 17:26:36.000000000","message":"Change has been successfully cherry-picked as 5795f4d3ef938172e3d7a942ed57023572650037","accounts_in_message":[],"_revision_number":3}],"current_revision":"5795f4d3ef938172e3d7a942ed57023572650037","revisions":{"67cd7ab4be610904e0f4cbe61b43e02ac75a2397":{"kind":"REWORK","_number":1,"created":"2021-12-09 17:14:53.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/69/6769/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/69/6769/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/69/6769/1 \u0026\u0026 git checkout -b change-6769 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/69/6769/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/69/6769/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/69/6769/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/69/6769/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/69/6769/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"12e460a926098777006a777aab41c917af671c95","subject":"gdb_server: don\u0027t send unrequested ACK at connection"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-12-04 17:38:56.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-12-09 15:55:14.000000000","tz":60},"subject":"gdb_server: fix a comment in gdb_new_connection()","message":"gdb_server: fix a comment in gdb_new_connection()\n\nOn 2008-03-05, before git\u0027s age, commit 6d9501467441 adds a\ncomment about unobserved ACK supposedly sent by GDB at connection.\n\nThe ACK is sent since GDB 3.95 (1999-05-04), but a bug introduced\nin GDB 6.5 (2006-06-21) and fixed in GDB 7.0 (2009-10-06) makes\nGDB sending the query for \"supported packets\" before sending the\nACK. Due to the bug, the author of the commit failed to see the\nACK.\n\nChange-Id: I574a8013e7d159d1c71087af83b7c2ce92be86bd\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"2ded39c0240983cd0b03f073f22da88789687934":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2021-12-09 21:42:54.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/69/6769/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/69/6769/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/69/6769/2 \u0026\u0026 git checkout -b change-6769 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/69/6769/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/69/6769/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/69/6769/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/69/6769/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/69/6769/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d5a0e844349cf533b8745d033e7f94fed9da29a9","subject":"gdb_server: don\u0027t send unrequested ACK at connection"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-12-04 17:38:56.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-12-09 21:42:22.000000000","tz":60},"subject":"gdb_server: fix a comment in gdb_new_connection()","message":"gdb_server: fix a comment in gdb_new_connection()\n\nOn 2008-03-05, before git\u0027s age, commit 6d9501467441 adds a\ncomment about unobserved ACK supposedly sent by GDB at connection.\n\nThe ACK is sent since GDB 3.95 (1999-05-04), but a bug introduced\nin GDB 6.5 (2006-06-21) and fixed in GDB 7.0 (2009-10-06) makes\nGDB sending the query for \"supported packets\" before sending the\nACK. Due to the bug, the author of the commit failed to see the\nACK.\n\nChange-Id: I574a8013e7d159d1c71087af83b7c2ce92be86bd\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"5795f4d3ef938172e3d7a942ed57023572650037":{"kind":"REWORK","_number":3,"created":"2021-12-18 17:26:36.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/69/6769/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/69/6769/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/69/6769/3 \u0026\u0026 git checkout -b change-6769 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/69/6769/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/69/6769/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/69/6769/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/69/6769/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/69/6769/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"29e689ede680f0b3bd106b80b9844c45459265e4","subject":"openocd: add keep_alive during command sleep"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-12-04 17:38:56.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-12-18 17:26:36.000000000","tz":0},"subject":"gdb_server: fix a comment in gdb_new_connection()","message":"gdb_server: fix a comment in gdb_new_connection()\n\nOn 2008-03-05, before git\u0027s age, commit 6d9501467441 adds a\ncomment about unobserved ACK supposedly sent by GDB at connection.\n\nThe ACK is sent since GDB 3.95 (1999-05-04), but a bug introduced\nin GDB 6.5 (2006-06-21) and fixed in GDB 7.0 (2009-10-06) makes\nGDB sending the query for \"supported packets\" before sending the\nACK. Due to the bug, the author of the commit failed to see the\nACK.\n\nChange-Id: I574a8013e7d159d1c71087af83b7c2ce92be86bd\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6769\nTested-by: jenkins\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}