)]}'
{"id":"openocd~master~Iab4fd5ab67043001db527574557405609543bf62","project":"openocd","branch":"master","topic":"keepalive","hashtags":[],"change_id":"Iab4fd5ab67043001db527574557405609543bf62","subject":"gdb_server: add workaround for lldb","status":"NEW","created":"2021-12-09 17:14:53.000000000","updated":"2022-02-26 21:07:02.000000000","submit_type":"CHERRY_PICK","submittable":false,"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"e1c3ebfc4de51bc14b48afc05a98089799cbc10f","_number":6771,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":1,"date":"2022-02-26 21:07:02.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"recommended":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:newPatchSet","value":1,"date":"2022-02-26 15:59:59.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","value":1,"default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-12-09 23:07:54.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"27c62284b36df3b51b8a5ff3df3f41f973d1d802","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-12-09 17:14:53.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"64b7b2e1ef9beb124c2765081d7bd11fc05a525d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-12-09 21:42:54.000000000","message":"Uploaded patch set 2: New patch set was added with same tree, parent, and commit message as Patch Set 1.","accounts_in_message":[],"_revision_number":2},{"id":"d75a7ccce935ab8934071759eeafdc50d3c0bd97","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-12-09 23:07:54.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15696/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14913/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"a0b9a124fe1169d8dbb8f2feecf1d27630ce154c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-02-03 22:39:35.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"b4ed5542cb65fb4c7c36a12b50e12421c2113a74","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-02-04 00:39:50.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15832/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/15044/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"ff14d4b4d5328ba7cb7bb91b762a4508c3602d16","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-02-26 15:59:59.000000000","message":"Uploaded patch set 4: Code-Review+1: Patch Set 3 was rebased.","accounts_in_message":[],"_revision_number":4},{"id":"e1c3ebfc4de51bc14b48afc05a98089799cbc10f","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-02-26 21:07:02.000000000","message":"Patch Set 4: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15906/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/15118/ : SUCCESS","accounts_in_message":[],"_revision_number":4}],"current_revision":"a1a83cd19184ef133f35f4f270bcf794d5b64a10","revisions":{"a1a83cd19184ef133f35f4f270bcf794d5b64a10":{"kind":"TRIVIAL_REBASE","_number":4,"created":"2022-02-26 15:59:59.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/71/6771/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/71/6771/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/71/6771/4 \u0026\u0026 git checkout -b change-6771 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/71/6771/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/71/6771/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/71/6771/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/71/6771/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/71/6771/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"0f0d53d2dd67028bbe2e79c74d3e39e777073911","subject":"server: accept connections during keep-alive"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-12-09 10:14:36.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-02-26 15:50:11.000000000","tz":60},"subject":"gdb_server: add workaround for lldb","message":"gdb_server: add workaround for lldb\n\nLLDB till current version 13.0.0 fails when junk bytes (used by\nOpenOCD for keepalive) enter in the same packet with the reply of\na command.\nA patch to fix LLDB is ongoing.\n\nAs a workaround, add a delay after the initial ACK, so the\nfollowing \"$OK#9a\" will be processed separately.\n\nChange-Id: Iab4fd5ab67043001db527574557405609543bf62\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"9b7d7ca3f1cdd3a92e44fd0cd9d8ce3f270a287f":{"kind":"REWORK","_number":1,"created":"2021-12-09 17:14:53.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/71/6771/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/71/6771/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/71/6771/1 \u0026\u0026 git checkout -b change-6771 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/71/6771/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/71/6771/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/71/6771/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/71/6771/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/71/6771/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"05dffed0211381167f60a454a28614e9f6af50e7","subject":"[WIP] server: accept connections during keep_alive"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-12-09 10:14:36.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-12-09 17:13:08.000000000","tz":60},"subject":"gdb_server: add workaround for lldb","message":"gdb_server: add workaround for lldb\n\nlldb till 13.0.0 fails when junk bytes (used by OpenOCD for\nkeepalive) enter in the same packet with the reply of a command.\nAdd a delay after the initial ACK, so the following \"$OK#9a\" will\nbe processed separately.\n\nChange-Id: Iab4fd5ab67043001db527574557405609543bf62\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"7d0552d472622311cefcd0d72372e5abf9ac63af":{"kind":"NO_CHANGE","_number":2,"created":"2021-12-09 21:42:54.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/71/6771/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/71/6771/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/71/6771/2 \u0026\u0026 git checkout -b change-6771 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/71/6771/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/71/6771/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/71/6771/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/71/6771/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/71/6771/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"458ed9b338013dea52058d6bde7fa68e019b3429","subject":"[WIP] server: accept connections during keep_alive"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-12-09 10:14:36.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-12-09 21:42:22.000000000","tz":60},"subject":"gdb_server: add workaround for lldb","message":"gdb_server: add workaround for lldb\n\nlldb till 13.0.0 fails when junk bytes (used by OpenOCD for\nkeepalive) enter in the same packet with the reply of a command.\nAdd a delay after the initial ACK, so the following \"$OK#9a\" will\nbe processed separately.\n\nChange-Id: Iab4fd5ab67043001db527574557405609543bf62\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"c0a18193f90c192b01e6b88b1480fc6120cde42e":{"kind":"REWORK","_number":3,"created":"2022-02-03 22:39:35.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/71/6771/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/71/6771/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/71/6771/3 \u0026\u0026 git checkout -b change-6771 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/71/6771/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/71/6771/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/71/6771/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/71/6771/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/71/6771/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1b10dfa6c82b3c2884323be46428ed986ca3ec9a","subject":"server: accept connections during keep-alive"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-12-09 10:14:36.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-02-03 22:37:32.000000000","tz":60},"subject":"gdb_server: add workaround for lldb","message":"gdb_server: add workaround for lldb\n\nLLDB till current version 13.0.0 fails when junk bytes (used by\nOpenOCD for keepalive) enter in the same packet with the reply of\na command.\nA patch to fix LLDB is ongoing.\n\nAs a workaround, add a delay after the initial ACK, so the\nfollowing \"$OK#9a\" will be processed separately.\n\nChange-Id: Iab4fd5ab67043001db527574557405609543bf62\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"NOT_READY","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"NEED"}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"]}}]}