)]}'
{"id":"openocd~master~I18aeab9e8a71c3eadbd5cf8782f570ce05eb0118","project":"openocd","branch":"master","attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2021-12-13 20:09:47.000000000","reason":"Tomas Vanek replied on the change"},"1000863":{"account":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"last_update":"2021-12-12 22:06:55.000000000","reason":"Antonio Borneo replied on the change"}},"removed_from_attention_set":{"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2021-12-13 20:09:47.000000000","reason":"Tomas Vanek replied on the change"}},"hashtags":[],"change_id":"I18aeab9e8a71c3eadbd5cf8782f570ce05eb0118","subject":"target/cortex_m: workaround setting invalid bp due to gdb bug","status":"NEW","created":"2021-12-10 17:38:04.000000000","updated":"2021-12-13 20:09:47.000000000","submit_type":"CHERRY_PICK","mergeable":false,"submittable":false,"total_comment_count":5,"unresolved_comment_count":1,"has_review_started":true,"meta_rev_id":"9624de16be99ea381d9c20eec0470125d8bd6501","_number":6774,"owner":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"value":1,"date":"2021-12-10 19:03:15.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"disliked":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"value":-1,"date":"2021-12-13 20:09:47.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","value":-1,"default_value":0}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}],"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-12-10 19:03:15.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-12-12 22:06:55.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"CC"},{"updated":"2021-12-12 22:06:55.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"state":"REVIEWER"}],"messages":[{"id":"9b0412a07ad988c9e90aaf7ed80b2f00664679b8","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-12-10 17:38:04.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"afc99f10abc203cce756bf3ab26c7f77703fecf6","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-12-10 19:03:15.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15699/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14916/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"be6d62c4c97ea93a47834d90c755fa120805f951","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-12-10 20:31:12.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"56e305ebaaa467e9772ec1a4fc9189dc87413e63","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-12-12 22:06:55.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"9624de16be99ea381d9c20eec0470125d8bd6501","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-12-13 20:09:47.000000000","message":"Patch Set 1: Code-Review-1\n\n(2 comments)","accounts_in_message":[],"_revision_number":1}],"current_revision":"ebcafdeddd636da03c1ea67fcca95ef1c088620b","revisions":{"ebcafdeddd636da03c1ea67fcca95ef1c088620b":{"kind":"REWORK","_number":1,"created":"2021-12-10 17:38:04.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/74/6774/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/74/6774/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/74/6774/1 \u0026\u0026 git checkout -b change-6774 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/74/6774/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/74/6774/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/74/6774/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/74/6774/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/74/6774/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a03a3cf9b1c69e4ac3d28376f5e77ada47654eb0","subject":"target/breakpoints: add address related error types"}],"author":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2021-12-06 17:56:44.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2021-12-10 17:36:02.000000000","tz":60},"subject":"target/cortex_m: workaround setting invalid bp due to gdb bug","message":"target/cortex_m: workaround setting invalid bp due to gdb bug\n\nCortex-M uses \"magic\" addresses for exception return and lockup.\nThe magic addresses are in execute never range.\n\nGDB bug in \u0027advance\u0027 and \u0027until\u0027 commands causes the magic\nin LR register is not properly handled and GDB tries to set a breakpoint\nat magic address. All tested versions of GDB up to current git master\nsuffer from this bug.\n\nIf gdb_server propagates the error from breakpoint setting to GDB, commands\n\u0027advance\u0027 and \u0027until\u0027 fail without running the target.\n\nHow to replicate the problem with gdb (versions 8.3, 9.2, 10.2, 12.0.50)\nand a Cortex-M0/3/4 device with normal app loaded to the flash:\n (gdb) mon reset halt\n (gdb) step\n - synchronize GDB register cache after reset halt\n (gdb) info registers\n - check LR, CPU should set it to 0xffffffff\n (gdb) advance main\n Warning:\n Cannot insert breakpoint 0.\n Cannot access memory at address 0xfffffffe\n\n Command aborted.\n\n----Part of openocd -d3 log:----\nDebug: gdb_log_incoming_packet(): received packet: Z0,fffffffe,2\nDebug: gdb_breakpoint_watchpoint_packet(): [stm32g4x.cpu]\nDebug: cmsis_dap_swd_read_process(): SWD ack not OK @ 4 FAULT\n ...\nError: mem_ap_read(): Failed to read memory at 0xfffff000\nError: breakpoint_add_internal(): can\u0027t add breakpoint: unknown reason\n--------------------------------\n\nRefuse setting a breakpoint at magic address.\nDo not propagate this error to GDB.\n\nChange-Id: I18aeab9e8a71c3eadbd5cf8782f570ce05eb0118\nSigned-off-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"NOT_READY","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"NEED"}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"]}}]}