)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"7f7ccf0b99db84d0261e1fc00682d9e01b6f7168","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"69c5bb46_280eeee0","updated":"2021-12-15 09:11:05.000000000","message":"I think Valgrind will eventually complain only when the last register in the array is bigger than 8 bytes.","commit_id":"0c386059c1769c4be46c58449a5c9a04c6d4cb39"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"b819da08b6751bb71a38f20469ba878bb60b2ec6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a92fb253_64c80c7f","updated":"2021-12-15 05:51:27.000000000","message":"Looks good. Did you check by valgrind?","commit_id":"0c386059c1769c4be46c58449a5c9a04c6d4cb39"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"6a41f19417009a821e156225a33847bfb42790c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c96fc3dc_b4d5778b","in_reply_to":"69c5bb46_280eeee0","updated":"2021-12-15 09:21:03.000000000","message":"I meant to valgrind the new code, not the old 😊","commit_id":"0c386059c1769c4be46c58449a5c9a04c6d4cb39"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"b742d7a4c065114b80a9eefc53634d33e2f3022d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d9e24cc3_72d75001","in_reply_to":"a92fb253_64c80c7f","updated":"2021-12-15 15:36:23.000000000","message":"Yes. No new memory is leaked.","commit_id":"0c386059c1769c4be46c58449a5c9a04c6d4cb39"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"b05dd6404a34d2a3d7a5d598f4bb740b1d3c6b36","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d15bf4b8_6a9c9639","in_reply_to":"bcd24962_0090b70a","updated":"2021-12-15 18:02:05.000000000","message":"Yes, 144 bytes are leaked in RISC-V examine() the first time it\u0027s called. This data is used but not cleaned up when OpenOCD terminates. I don\u0027t recall why I didn\u0027t fix it, but I never gave it much priority since it would only be freed when OpenOCD exits in any case.","commit_id":"0c386059c1769c4be46c58449a5c9a04c6d4cb39"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"ae26e4461a0f37c946b4e21b13bf444c0f79f785","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f4bb4465_94186d5a","in_reply_to":"d15bf4b8_6a9c9639","updated":"2021-12-24 15:10:36.000000000","message":"Would be good to fix that leak.","commit_id":"0c386059c1769c4be46c58449a5c9a04c6d4cb39"},{"author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"change_message_id":"bbecccc38093b52ad45fe410f2e68ae78b840dea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bcd24962_0090b70a","in_reply_to":"d9e24cc3_72d75001","updated":"2021-12-15 16:22:48.000000000","message":"This sounds like you know some old leaks. Do you?","commit_id":"0c386059c1769c4be46c58449a5c9a04c6d4cb39"}],"src/target/riscv/riscv.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"7f7ccf0b99db84d0261e1fc00682d9e01b6f7168","unresolved":true,"context_lines":[{"line_number":1752,"context_line":"{"},{"line_number":1753,"context_line":"\tRISCV_INFO(r);"},{"line_number":1754,"context_line":"\tLOG_DEBUG(\"[%s] {%d} reg_class\u003d%d, read\u003d%d\","},{"line_number":1755,"context_line":"\t\t\ttarget_name(target), r-\u003ecurrent_hartid, reg_class, read);"},{"line_number":1756,"context_line":""},{"line_number":1757,"context_line":"\tif (!target-\u003ereg_cache) {"},{"line_number":1758,"context_line":"\t\tLOG_ERROR(\"Target not initialized. Return ERROR_FAIL.\");"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"6f1be41b_48cbfd08","line":1755,"updated":"2021-12-15 09:11:05.000000000","message":"What about using the new LOG_TARGET_DEBUG() ?\nIt does the same, but in a consistent way.\nAnyway, there would be some effort to switch everywhere to the new LOG, so not mandatory to change now, just a suggestion for future patches.","commit_id":"0c386059c1769c4be46c58449a5c9a04c6d4cb39"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"b742d7a4c065114b80a9eefc53634d33e2f3022d","unresolved":false,"context_lines":[{"line_number":1752,"context_line":"{"},{"line_number":1753,"context_line":"\tRISCV_INFO(r);"},{"line_number":1754,"context_line":"\tLOG_DEBUG(\"[%s] {%d} reg_class\u003d%d, read\u003d%d\","},{"line_number":1755,"context_line":"\t\t\ttarget_name(target), r-\u003ecurrent_hartid, reg_class, read);"},{"line_number":1756,"context_line":""},{"line_number":1757,"context_line":"\tif (!target-\u003ereg_cache) {"},{"line_number":1758,"context_line":"\t\tLOG_ERROR(\"Target not initialized. Return ERROR_FAIL.\");"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"461d653c_76d7266b","line":1755,"in_reply_to":"6f1be41b_48cbfd08","updated":"2021-12-15 15:36:23.000000000","message":"I\u0027m inclined to punt for now, and do a big conversion in RISC-V code at some point in the future.","commit_id":"0c386059c1769c4be46c58449a5c9a04c6d4cb39"}]}