)]}'
{"id":"openocd~master~I9df4eaf05617a2c8df3140fff9fe53f61ab2b261","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2021-12-24 15:10:20.000000000","reason":"Change was submitted"},"1001242":{"account":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"last_update":"2021-12-15 18:02:05.000000000","reason":"Tim Newsome replied on the change"},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2021-12-15 16:22:48.000000000","reason":"Tomas Vanek replied on the change"}},"hashtags":[],"change_id":"I9df4eaf05617a2c8df3140fff9fe53f61ab2b261","subject":"target/riscv: calloc() memory per register.","status":"MERGED","created":"2021-12-14 23:48:15.000000000","updated":"2021-12-24 15:10:36.000000000","submitted":"2021-12-24 15:10:20.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":9,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6775","meta_rev_id":"ae26e4461a0f37c946b4e21b13bf444c0f79f785","_number":6775,"owner":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-12-24 15:10:20.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-12-24 15:10:20.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-12-24 15:10:20.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-12-15 00:07:28.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-12-15 05:51:27.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"CC"},{"updated":"2021-12-15 09:11:05.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"},{"updated":"2021-12-15 16:22:48.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"}],"messages":[{"id":"64f097da142e8a21957833474d4eaab5b217e7b7","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"real_author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"date":"2021-12-14 23:48:15.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"fe410dcc6a5bf57baaaebf926c4a630aa45b79b4","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-12-15 00:07:28.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15701/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14918/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"b819da08b6751bb71a38f20469ba878bb60b2ec6","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-12-15 05:51:27.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"7f7ccf0b99db84d0261e1fc00682d9e01b6f7168","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-12-15 09:11:05.000000000","message":"Patch Set 1: Code-Review+1\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"6a41f19417009a821e156225a33847bfb42790c7","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-12-15 09:21:03.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"b742d7a4c065114b80a9eefc53634d33e2f3022d","author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"real_author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"date":"2021-12-15 15:36:23.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"bbecccc38093b52ad45fe410f2e68ae78b840dea","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-12-15 16:22:48.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"b05dd6404a34d2a3d7a5d598f4bb740b1d3c6b36","author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"real_author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"date":"2021-12-15 18:02:05.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"b768013b027c08c2f20071c04fa34cdb769d4d35","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-12-24 15:10:20.000000000","message":"Change has been successfully cherry-picked as 3ba21e5f007a81b42be194a663cb6f15f150b245","accounts_in_message":[],"_revision_number":2},{"id":"ae26e4461a0f37c946b4e21b13bf444c0f79f785","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-12-24 15:10:36.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2}],"current_revision":"3ba21e5f007a81b42be194a663cb6f15f150b245","revisions":{"3ba21e5f007a81b42be194a663cb6f15f150b245":{"kind":"REWORK","_number":2,"created":"2021-12-24 15:10:20.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/75/6775/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/75/6775/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/75/6775/2 \u0026\u0026 git checkout -b change-6775 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/75/6775/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/75/6775/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/75/6775/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/75/6775/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/75/6775/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9828c0a440364fac11eb80fdea5dfaaaee42ab2d","subject":"semihosting: use macro COMMAND_HANDLER"}],"author":{"name":"Tim Newsome","email":"tim@sifive.com","date":"2021-11-02 16:55:07.000000000","tz":-420},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-12-24 15:10:20.000000000","tz":0},"subject":"target/riscv: calloc() memory per register.","message":"target/riscv: calloc() memory per register.\n\nThis replaces a static array with 8 bytes per register. When there are\nvector registers larger than 8 bytes, they would end up clobbering each\nother\u0027s values. I can\u0027t believe I didn\u0027t catch this earlier.\n\nSee https://github.com/riscv/riscv-openocd/pull/658\n\nChange-Id: I9df4eaf05617a2c8df3140fff9fe53f61ab2b261\nSigned-off-by: Tim Newsome \u003ctim@sifive.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6775\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\n"}},"0c386059c1769c4be46c58449a5c9a04c6d4cb39":{"kind":"REWORK","_number":1,"created":"2021-12-14 23:48:15.000000000","uploader":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"ref":"refs/changes/75/6775/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/75/6775/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/75/6775/1 \u0026\u0026 git checkout -b change-6775 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/75/6775/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/75/6775/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/75/6775/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/75/6775/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/75/6775/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1ad6ed38b6da09b1d5d9e56d1344fced2dce12bc","subject":"flash/nor/efm32: fixed BG1x identification"}],"author":{"name":"Tim Newsome","email":"tim@sifive.com","date":"2021-11-02 16:55:07.000000000","tz":-420},"committer":{"name":"Tim Newsome","email":"tim@sifive.com","date":"2021-12-14 23:47:19.000000000","tz":-480},"subject":"target/riscv: calloc() memory per register.","message":"target/riscv: calloc() memory per register.\n\nThis replaces a static array with 8 bytes per register. When there are\nvector registers larger than 8 bytes, they would end up clobbering each\nother\u0027s values. I can\u0027t believe I didn\u0027t catch this earlier.\n\nSee https://github.com/riscv/riscv-openocd/pull/658\n\nChange-Id: I9df4eaf05617a2c8df3140fff9fe53f61ab2b261\nSigned-off-by: Tim Newsome \u003ctim@sifive.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}