)]}'
{"id":"openocd~master~I0e5385cb54197c743348f0d2ce215c93b8e396a4","project":"openocd","branch":"master","hashtags":[],"change_id":"I0e5385cb54197c743348f0d2ce215c93b8e396a4","subject":"semihosting: use macro COMMAND_HANDLER","status":"MERGED","created":"2021-12-16 23:56:02.000000000","updated":"2021-12-24 15:07:26.000000000","submitted":"2021-12-24 15:07:26.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6786","meta_rev_id":"0097bf1a0713dce23edfdc60053337669213a3d1","_number":6786,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2021-12-24 15:07:26.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2021-12-24 15:07:26.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-12-17 00:13:13.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"b4758a5ffea2ccc53b17b87f7262a86113ae2b8b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-12-16 23:56:02.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"87a66c6cb648ff16951e56f8490918b13527b2c5","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-12-17 00:13:13.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15715/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14932/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"5957bc825c2c5ef541e77345698eabb9a8155a05","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-12-17 16:56:56.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"67002057a7a48feb7068cb6fa51cfcc0240e2556","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-12-24 15:06:59.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"0097bf1a0713dce23edfdc60053337669213a3d1","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-12-24 15:07:26.000000000","message":"Change has been successfully cherry-picked as 9828c0a440364fac11eb80fdea5dfaaaee42ab2d","accounts_in_message":[],"_revision_number":2}],"current_revision":"9828c0a440364fac11eb80fdea5dfaaaee42ab2d","revisions":{"b0895587be1b08c7f7edcfc2b6ffe13cbd89d9f4":{"kind":"REWORK","_number":1,"created":"2021-12-16 23:56:02.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/86/6786/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/86/6786/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/86/6786/1 \u0026\u0026 git checkout -b change-6786 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/86/6786/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/86/6786/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/86/6786/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/86/6786/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/86/6786/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"fdf17dba569ac8aca0771c28b661e3722d776541","subject":"flash/nor/spi: add micron MT25QU01G"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-12-16 23:53:11.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-12-16 23:53:11.000000000","tz":60},"subject":"semihosting: use macro COMMAND_HANDLER","message":"semihosting: use macro COMMAND_HANDLER\n\nWe have the macro\n\t#define COMMAND_HANDLER(name) \\\n\t\tstatic __COMMAND_HANDLER(name)\nUse it!\n\nChange-Id: I0e5385cb54197c743348f0d2ce215c93b8e396a4\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"9828c0a440364fac11eb80fdea5dfaaaee42ab2d":{"kind":"REWORK","_number":2,"created":"2021-12-24 15:07:26.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/86/6786/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/86/6786/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/86/6786/2 \u0026\u0026 git checkout -b change-6786 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/86/6786/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/86/6786/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/86/6786/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/86/6786/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/86/6786/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"5795f4d3ef938172e3d7a942ed57023572650037","subject":"gdb_server: fix a comment in gdb_new_connection()"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-12-16 23:53:11.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-12-24 15:07:26.000000000","tz":0},"subject":"semihosting: use macro COMMAND_HANDLER","message":"semihosting: use macro COMMAND_HANDLER\n\nWe have the macro\n\t#define COMMAND_HANDLER(name) \\\n\t\tstatic __COMMAND_HANDLER(name)\nUse it!\n\nChange-Id: I0e5385cb54197c743348f0d2ce215c93b8e396a4\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6786\nTested-by: jenkins\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}