)]}'
{"id":"openocd~master~I98f5027c8663e33feacfbf9d17e791a854d73d97","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2021-12-25 20:57:21.000000000","reason":"Antonio Borneo replied on the change"}},"hashtags":[],"change_id":"I98f5027c8663e33feacfbf9d17e791a854d73d97","subject":"openocd: add helper/oocd_valgrind.h","status":"NEW","created":"2021-12-24 23:11:55.000000000","updated":"2021-12-25 20:57:21.000000000","submit_type":"CHERRY_PICK","mergeable":false,"submittable":false,"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"98d39273fa6e151f7d911641cd4965cf326bb233","_number":6791,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":1,"date":"2021-12-25 00:20:05.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"recommended":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"value":1,"date":"2021-12-25 20:57:21.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","value":1,"default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-12-24 23:13:18.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"ae1b11c0c9115123bd3665d683d3cdfa68c197cc","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-12-24 23:11:55.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"53853d57b3450fc5dc14b17f26b5ea9ef6296f17","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-12-24 23:13:18.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit/15728/ : FAILURE\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14945/ : FAILURE","accounts_in_message":[],"_revision_number":1},{"id":"c93202829a9193b5f3e1010ab360c4a6e60bdba7","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-12-24 23:21:46.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"f4bbd6468bc5c3b3f91f05b37932dc65dd3a9c27","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-12-25 00:20:05.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15731/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14948/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"98d39273fa6e151f7d911641cd4965cf326bb233","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2021-12-25 20:57:21.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2}],"current_revision":"e0ea3ebf4d8c27d4a08e139733438047742b0c69","revisions":{"e0ea3ebf4d8c27d4a08e139733438047742b0c69":{"kind":"REWORK","_number":2,"created":"2021-12-24 23:21:46.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/91/6791/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/91/6791/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/91/6791/2 \u0026\u0026 git checkout -b change-6791 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/91/6791/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/91/6791/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/91/6791/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/91/6791/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/91/6791/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d27d66bc1bdbef0cbfe43d88597576e173317c01","subject":"Document how vector registers are exposed to gdb."}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-12-24 00:39:49.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-12-24 23:21:03.000000000","tz":60},"subject":"openocd: add helper/oocd_valgrind.h","message":"openocd: add helper/oocd_valgrind.h\n\nOpenOCD implements queues to pack operations in a burst over the\ncommunication channel. E.g. JTAG elementary transfers are queued\nand flushed in one shot.\nEnqueued read operations are executed when the queue is flushed;\nthe variable that will contain the read value has undefined value\nuntil the flush callback initialises it.\n\nValgrind is already able to identify the use of uninitialized\nvariables in very simple cases, e.g. first use of a local variable\nor of a malloc\u0027ed area.\n\nValgrind allows to instrument the code to pass further info to the\nrunning valgrind. It is possible, for example, to declare a\nvariable as uninitialized.\n\nValgrind documentation suggest to copy the include file valgrind.h\nin the project, so it will compile also on hosts where valgrind is\nnot installed. But this has the drawback to require a periodic\nrealignment with valgrind code.\nLet autoconf detect the presence of valgrind. Add a wrapper to\nvalgrind\u0027s header files that allows compiling OpenOCD on hosts\nthat have no valgrind installed.\n\nChange-Id: I98f5027c8663e33feacfbf9d17e791a854d73d97\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"535c0aef7160229a1b2e01d0a6edb4df19f2e746":{"kind":"REWORK","_number":1,"created":"2021-12-24 23:11:55.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/91/6791/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/91/6791/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/91/6791/1 \u0026\u0026 git checkout -b change-6791 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/91/6791/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/91/6791/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/91/6791/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/91/6791/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/91/6791/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d27d66bc1bdbef0cbfe43d88597576e173317c01","subject":"Document how vector registers are exposed to gdb."}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-12-24 00:39:49.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2021-12-24 22:54:43.000000000","tz":60},"subject":"openocd: add helper/oocd_valgrind.h","message":"openocd: add helper/oocd_valgrind.h\n\nOpenOCD implements queues to pack operations in a burst over the\ncommunication channel. E.g. JTAG elementary transfers are queued\nand flushed in one shot.\nEnqueued read operations are executed when the queue is flushed;\nthe variable that will contain the read value has undefined value\nuntil the flush callback initialises it.\n\nValgrind is already able to identify the use of uninitialized\nvariables in very simple cases, e.g. first use of a local variable\nor of a malloc\u0027ed area.\n\nValgrind allows to instrument the code to pass further info to the\nrunning valgrind. It is possible, for example, to declare a\nvariable as uninitialized.\n\nValgrind documentation suggest to copy the include file valgrind.h\nin the project, so it will compile also on hosts where valgrind is\nnot installed. But this has the drawback to require a periodic\nrealignment with valgrind code.\nLet autoconf detect the presence of valgrind. Add a wrapper to\nvalgrind\u0027s header files that allows compiling OpenOCD on hosts\nthat have no valgrind installed.\n\nChange-Id: I98f5027c8663e33feacfbf9d17e791a854d73d97\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"NOT_READY","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"NEED"}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"]}}]}