)]}'
{"id":"openocd~master~I4ab4eb7a6514c2e1c6ce4333bed1ab5ffecb5cee","project":"openocd","branch":"master","attention_set":{"1001874":{"account":{"_account_id":1001874,"name":"Andrzej Sierżęga","email":"asier70@gmail.com","username":"asier70"},"last_update":"2021-12-29 10:49:02.000000000","reason":"Maximilian Gerhardt replied on the change"},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2021-12-28 16:16:46.000000000","reason":"Maximilian Gerhardt replied on the change"},"1001949":{"account":{"_account_id":1001949,"name":"Maximilian Gerhardt","email":"maximilian.gerhardt@rub.de","username":"maxgerhardt"},"last_update":"2025-02-08 08:01:54.000000000","reason":"\u003cGERRIT_ACCOUNT_1002374\u003e replied on the change","reason_account":{"_account_id":1002374,"name":"ALTracer","username":"ALTracer"}}},"removed_from_attention_set":{},"hashtags":[],"change_id":"I4ab4eb7a6514c2e1c6ce4333bed1ab5ffecb5cee","subject":"flash/stm32f1x: Add GD32E50x Support","status":"NEW","created":"2021-12-26 12:23:49.000000000","updated":"2025-02-08 08:01:54.000000000","submit_type":"CHERRY_PICK","mergeable":false,"submittable":false,"total_comment_count":29,"unresolved_comment_count":1,"has_review_started":true,"meta_rev_id":"3e9f84ec4573784818d9e61896563d69834c9c74","_number":6794,"owner":{"_account_id":1001949,"name":"Maximilian Gerhardt","email":"maximilian.gerhardt@rub.de","username":"maxgerhardt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":1,"date":"2021-12-29 11:04:15.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"_account_id":1001874,"name":"Andrzej Sierżęga","email":"asier70@gmail.com","username":"asier70"},{"_account_id":1002374,"name":"ALTracer","username":"ALTracer"}],"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-12-26 12:24:50.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-12-27 08:01:49.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"CC"},{"updated":"2021-12-27 09:37:19.000000000","updated_by":{"_account_id":1001874,"name":"Andrzej Sierżęga","email":"asier70@gmail.com","username":"asier70"},"reviewer":{"_account_id":1001874,"name":"Andrzej Sierżęga","email":"asier70@gmail.com","username":"asier70"},"state":"CC"},{"updated":"2025-02-08 08:01:54.000000000","updated_by":{"_account_id":1002374,"name":"ALTracer","username":"ALTracer"},"reviewer":{"_account_id":1002374,"name":"ALTracer","username":"ALTracer"},"state":"CC"}],"messages":[{"id":"310492fcd6ea1c960dc44290ebc57694fe1cad90","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001949,"name":"Maximilian Gerhardt","email":"maximilian.gerhardt@rub.de","username":"maxgerhardt"},"real_author":{"_account_id":1001949,"name":"Maximilian Gerhardt","email":"maximilian.gerhardt@rub.de","username":"maxgerhardt"},"date":"2021-12-26 12:23:49.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"118e4a0151935ba7ca9db37ba79fa97367e04be0","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-12-26 12:24:50.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit/15732/ : FAILURE\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14949/ : FAILURE","accounts_in_message":[],"_revision_number":1},{"id":"ee6e2c6be7eb15338c46618f0f7ada229347cdf9","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001949,"name":"Maximilian Gerhardt","email":"maximilian.gerhardt@rub.de","username":"maxgerhardt"},"real_author":{"_account_id":1001949,"name":"Maximilian Gerhardt","email":"maximilian.gerhardt@rub.de","username":"maxgerhardt"},"date":"2021-12-26 12:28:08.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"6c564102d43a4a8a86ef70d9257baff8c5e72c77","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-12-26 12:49:21.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15733/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14950/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"4b6ee6d36a06578c0f127dc9ee9c06038836d03d","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-12-27 08:01:49.000000000","message":"Patch Set 2:\n\n(4 comments)","accounts_in_message":[],"_revision_number":2},{"id":"c9b511be61b7967799d7d3d48d7e7c4969a74e79","author":{"_account_id":1001874,"name":"Andrzej Sierżęga","email":"asier70@gmail.com","username":"asier70"},"real_author":{"_account_id":1001874,"name":"Andrzej Sierżęga","email":"asier70@gmail.com","username":"asier70"},"date":"2021-12-27 09:37:19.000000000","message":"Patch Set 2:\n\n(6 comments)","accounts_in_message":[],"_revision_number":2},{"id":"44b3a2db91c509013c2ccbe56df3f2c5cf561d88","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001949,"name":"Maximilian Gerhardt","email":"maximilian.gerhardt@rub.de","username":"maxgerhardt"},"real_author":{"_account_id":1001949,"name":"Maximilian Gerhardt","email":"maximilian.gerhardt@rub.de","username":"maxgerhardt"},"date":"2021-12-27 22:02:42.000000000","message":"Uploaded patch set 3: Commit message was updated.","accounts_in_message":[],"_revision_number":3},{"id":"c8ed8728d97ad78d8f2f2ec796d1c73a5fd081f1","author":{"_account_id":1001949,"name":"Maximilian Gerhardt","email":"maximilian.gerhardt@rub.de","username":"maxgerhardt"},"real_author":{"_account_id":1001949,"name":"Maximilian Gerhardt","email":"maximilian.gerhardt@rub.de","username":"maxgerhardt"},"date":"2021-12-27 22:10:00.000000000","message":"Patch Set 3:\n\n(9 comments)","accounts_in_message":[],"_revision_number":3},{"id":"54d515aab682d080acdc26ddf8851f5048d913cd","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-12-27 22:20:16.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15734/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14951/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"021733734095b5776bb7f9271742e4f97a420d7d","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-12-28 07:17:46.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"57fb65a087926830562a6c19f40ad400ed2b11d7","author":{"_account_id":1001949,"name":"Maximilian Gerhardt","email":"maximilian.gerhardt@rub.de","username":"maxgerhardt"},"real_author":{"_account_id":1001949,"name":"Maximilian Gerhardt","email":"maximilian.gerhardt@rub.de","username":"maxgerhardt"},"date":"2021-12-28 11:41:44.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"bb7f784f1616d1a7d9f822472e287c4920d96de5","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2021-12-28 13:15:57.000000000","message":"Patch Set 3:\n\n(2 comments)","accounts_in_message":[],"_revision_number":3},{"id":"4ba1cfe72b995b83b28ff1ddc057fdf01f944f5e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001949,"name":"Maximilian Gerhardt","email":"maximilian.gerhardt@rub.de","username":"maxgerhardt"},"real_author":{"_account_id":1001949,"name":"Maximilian Gerhardt","email":"maximilian.gerhardt@rub.de","username":"maxgerhardt"},"date":"2021-12-28 16:14:56.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"2c64ec38a429cbfeff44076335eee0859a18f42a","author":{"_account_id":1001949,"name":"Maximilian Gerhardt","email":"maximilian.gerhardt@rub.de","username":"maxgerhardt"},"real_author":{"_account_id":1001949,"name":"Maximilian Gerhardt","email":"maximilian.gerhardt@rub.de","username":"maxgerhardt"},"date":"2021-12-28 16:16:46.000000000","message":"Patch Set 4:\n\n(2 comments)","accounts_in_message":[],"_revision_number":4},{"id":"d1fce8c6454ff19bcf0cec8197378099d45ef987","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001949,"name":"Maximilian Gerhardt","email":"maximilian.gerhardt@rub.de","username":"maxgerhardt"},"real_author":{"_account_id":1001949,"name":"Maximilian Gerhardt","email":"maximilian.gerhardt@rub.de","username":"maxgerhardt"},"date":"2021-12-28 16:19:54.000000000","message":"Uploaded patch set 5: Commit message was updated.","accounts_in_message":[],"_revision_number":5},{"id":"bf95722420973817cf25600dd38465c2c4f789c4","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-12-28 16:20:03.000000000","message":"Patch Set 4: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit-build/14953/ : ABORTED\n\nhttps://build.openocd.org/job/openocd-gerrit/15736/ : SUCCESS","accounts_in_message":[],"_revision_number":4},{"id":"88a4e68a69d7e6f70131eb42a6f2428733efa897","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-12-28 16:37:44.000000000","message":"Patch Set 5: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15737/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14954/ : SUCCESS","accounts_in_message":[],"_revision_number":5},{"id":"81af43a1c37456093a6b4e0c37adbd32555dee54","author":{"_account_id":1001874,"name":"Andrzej Sierżęga","email":"asier70@gmail.com","username":"asier70"},"real_author":{"_account_id":1001874,"name":"Andrzej Sierżęga","email":"asier70@gmail.com","username":"asier70"},"date":"2021-12-29 09:54:23.000000000","message":"Patch Set 5:\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"288791f93d3a2e1597ccb07147977775941717cf","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001949,"name":"Maximilian Gerhardt","email":"maximilian.gerhardt@rub.de","username":"maxgerhardt"},"real_author":{"_account_id":1001949,"name":"Maximilian Gerhardt","email":"maximilian.gerhardt@rub.de","username":"maxgerhardt"},"date":"2021-12-29 10:47:40.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"9aa48febca17f3021c122b3cf1c7c5ab2179af63","author":{"_account_id":1001949,"name":"Maximilian Gerhardt","email":"maximilian.gerhardt@rub.de","username":"maxgerhardt"},"real_author":{"_account_id":1001949,"name":"Maximilian Gerhardt","email":"maximilian.gerhardt@rub.de","username":"maxgerhardt"},"date":"2021-12-29 10:49:02.000000000","message":"Patch Set 6:\n\n(1 comment)","accounts_in_message":[],"_revision_number":6},{"id":"4e0d65d1403af28fe22210b0c2fd7d123ba658d5","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2021-12-29 11:04:15.000000000","message":"Patch Set 6: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15738/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14955/ : SUCCESS","accounts_in_message":[],"_revision_number":6},{"id":"3e9f84ec4573784818d9e61896563d69834c9c74","author":{"_account_id":1002374,"name":"ALTracer","username":"ALTracer"},"real_author":{"_account_id":1002374,"name":"ALTracer","username":"ALTracer"},"date":"2025-02-08 08:01:54.000000000","message":"Patch Set 6:\n\n(2 comments)","accounts_in_message":[],"_revision_number":6}],"current_revision":"14a5539a620c29499d020f3269f5d46d0713d80b","revisions":{"4217c6a072334d7004709a3e4d66e431f0bd8f69":{"kind":"REWORK","_number":2,"created":"2021-12-26 12:28:08.000000000","uploader":{"_account_id":1001949,"name":"Maximilian Gerhardt","email":"maximilian.gerhardt@rub.de","username":"maxgerhardt"},"ref":"refs/changes/94/6794/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/94/6794/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/94/6794/2 \u0026\u0026 git checkout -b change-6794 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/94/6794/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/94/6794/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/94/6794/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/94/6794/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/94/6794/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d27d66bc1bdbef0cbfe43d88597576e173317c01","subject":"Document how vector registers are exposed to gdb."}],"author":{"name":"Max Gerhardt","email":"maximilian.gerhardt@rub.de","date":"2021-12-26 12:03:22.000000000","tz":60},"committer":{"name":"Max Gerhardt","email":"maximilian.gerhardt@rub.de","date":"2021-12-26 12:27:45.000000000","tz":60},"subject":"Add GD32E50x Support","message":"Add GD32E50x Support\n\nSee user manual at https://github.com/CommunityGD32Cores/gigadevice-firmware-and-docs/blob/main/GD32E50x/GD32E50x_User_Manual_Rev1.2.pdf for reference.\n\nNotes / change justication:\n* used hardware: GD32E503C-START board with GD32E503CET6 chip and on-board CMSIS-DAP (\"GD-Link\") probe\n* SWD DPIDR: 0x0be12477\n* DBGMCU ID code: 0x20030444\n* device id part 0x444 overlaps with existing stm32f03x, had to add check on revision ID of my particular chip (0x2003) to avoid confusion, not too nice\n* device_id_register \u003d 0xE0044000 is correct per page 270\n* flash_size_reg \u003d 0x1FFFF7E0 is correct per page 44\n* page_size \u003d 8192, ppage_size \u003d 1 correct per page 47 and 57\n* user_data_offset \u003d 2 (bits), option_offset \u003d 10 (bits) hopefully correct per page 63\n* gd32e50x.cfg\u0027s DBG_CTL address and content correct per page 270\n* flashing of binaries and opening of a GDB server works (blinky example tested)\n* \"flash info 0\" shows expected protected page layout\n\nRemaining bugs:\n* after core is halted (\"halt\" command), MCU seems to reset continously, but always after a different delay (between 5 seconds and 2 minutes). error messages: \"error writing data: (null), Polling target gd32e50x.cpu failed, trying to reexamine, SWD DPIDR 0x0be12477, gd32e50x.cpu: Cortex-M33 r0p4 processor detected, gd32e50x.cpu: target has 8 breakpoints, 4 watchpoints\"\n* looks like watchdog reset, but examination of DBG_CTL register via \"mrw 0xE0044004\" shows all relevant bits are on -- no idea what\u0027s happening here\n* tests done with Linux guest VM (VirtualBox) inside Windows host and USB forwarding, did not test on Windows host itslef\n\nRelated ticket: https://sourceforge.net/p/openocd/tickets/328/\n\nSigned-off-by: Max Gerhardt \u003cmaximilian.gerhardt@rub.de\u003e\nChange-Id: I4ab4eb7a6514c2e1c6ce4333bed1ab5ffecb5cee\n"}},"ff85e16c08a23a7fb64b6d4ff30fbe8aa816a348":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2021-12-27 22:02:42.000000000","uploader":{"_account_id":1001949,"name":"Maximilian Gerhardt","email":"maximilian.gerhardt@rub.de","username":"maxgerhardt"},"ref":"refs/changes/94/6794/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/94/6794/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/94/6794/3 \u0026\u0026 git checkout -b change-6794 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/94/6794/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/94/6794/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/94/6794/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/94/6794/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/94/6794/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d27d66bc1bdbef0cbfe43d88597576e173317c01","subject":"Document how vector registers are exposed to gdb."}],"author":{"name":"Max Gerhardt","email":"maximilian.gerhardt@rub.de","date":"2021-12-26 12:03:22.000000000","tz":60},"committer":{"name":"Max Gerhardt","email":"maximilian.gerhardt@rub.de","date":"2021-12-27 22:01:32.000000000","tz":60},"subject":"flash/stm32f1x: Add GD32E50x Support","message":"flash/stm32f1x: Add GD32E50x Support\n\nSee user manual at https://github.com/CommunityGD32Cores/gigadevice-firmware-and-docs/blob/main/GD32E50x/GD32E50x_User_Manual_Rev1.2.pdf for reference.\n\nNotes / change justication:\n* used hardware: GD32E503C-START board with GD32E503CET6 chip and on-board CMSIS-DAP (\"GD-Link\") probe\n* SWD DPIDR: 0x0be12477\n* DBGMCU ID code: 0x20030444\n* device id part 0x444 overlaps with existing stm32f03x, had to add check on revision ID of my particular chip (0x2003) to avoid confusion, not too nice\n* device_id_register \u003d 0xE0044000 is correct per page 270\n* flash_size_reg \u003d 0x1FFFF7E0 is correct per page 44\n* page_size \u003d 8192, ppage_size \u003d 1 correct per page 47 and 57\n* for user_data_offset \u003d 10 (bits), option_offset \u003d 0 (bits), see page 63, same as for GD32F103\n* gd32e50x.cfg\u0027s DBG_CTL address and content correct per page 270\n* flashing of binaries and opening of a GDB server works (blinky example tested)\n* \"flash info 0\" shows expected protected page layout\n\nRemaining topics:\n* When testing in a VM, the error message \"error writing data: (null), Polling target gd32e50x.cpu failed, trying to reexamine\" occured, testing outside a VM is an outstanding task..\n* the \"if (device_id \u003d\u003d 0x444 \u0026\u0026 rev_id \u003d\u003d 0x2003)\" check might not get all E50x devices, only tested for one particular GD32E503CE chip.\n\nSigned-off-by: Max Gerhardt \u003cmaximilian.gerhardt@rub.de\u003e\nChange-Id: I4ab4eb7a6514c2e1c6ce4333bed1ab5ffecb5cee\n"}},"49f69a73734bff7cbe9fb889951c15ff5a413a7e":{"kind":"REWORK","_number":1,"created":"2021-12-26 12:23:49.000000000","uploader":{"_account_id":1001949,"name":"Maximilian Gerhardt","email":"maximilian.gerhardt@rub.de","username":"maxgerhardt"},"ref":"refs/changes/94/6794/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/94/6794/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/94/6794/1 \u0026\u0026 git checkout -b change-6794 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/94/6794/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/94/6794/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/94/6794/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/94/6794/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/94/6794/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d27d66bc1bdbef0cbfe43d88597576e173317c01","subject":"Document how vector registers are exposed to gdb."}],"author":{"name":"Max Gerhardt","email":"maximilian.gerhardt@rub.de","date":"2021-12-26 12:03:22.000000000","tz":60},"committer":{"name":"Max Gerhardt","email":"maximilian.gerhardt@rub.de","date":"2021-12-26 12:22:52.000000000","tz":60},"subject":"Add GD32E50x Support","message":"Add GD32E50x Support\n\nSee user manual at https://github.com/CommunityGD32Cores/gigadevice-firmware-and-docs/blob/main/GD32E50x/GD32E50x_User_Manual_Rev1.2.pdf for reference.\n\nNotes / change justication:\n* used hardware: GD32E503C-START board with GD32E503CET6 chip and on-board CMSIS-DAP (\"GD-Link\") probe\n* SWD DPIDR: 0x0be12477\n* DBGMCU ID code: 0x20030444\n* device id part 0x444 overlaps with existing stm32f03x, had to add check on revision ID of my particular chip (0x2003) to avoid confusion, not too nice\n* device_id_register \u003d 0xE0044000 is correct per page 270\n* flash_size_reg \u003d 0x1FFFF7E0 is correct per page 44\n* page_size \u003d 8192, ppage_size \u003d 1 correct per page 47 and 57\n* user_data_offset \u003d 2 (bits), option_offset \u003d 10 (bits) hopefully correct per page 63\n* gd32e50x.cfg\u0027s DBG_CTL address and content correct per page 270\n* flashing of binaries and opening of a GDB server works (blinky example tested)\n* \"flash info 0\" shows expected protected page layout\n\nRemaining bugs:\n* after core is halted (\"halt\" command), MCU seems to reset continously, but always after a different delay (between 5 seconds and 2 minutes). error messages: \"error writing data: (null), Polling target gd32e50x.cpu failed, trying to reexamine, SWD DPIDR 0x0be12477, gd32e50x.cpu: Cortex-M33 r0p4 processor detected, gd32e50x.cpu: target has 8 breakpoints, 4 watchpoints\"\n* looks like watchdog reset, but examination of DBG_CTL register via \"mrw 0xE0044004\" shows all relevant bits are on -- no idea what\u0027s happening here\n* tests done with Linux guest VM (VirtualBox) inside Windows host and USB forwarding, did not test on Windows host itslef\n\nRelated ticket: https://sourceforge.net/p/openocd/tickets/328/\n\nSigned-off-by: Max Gerhardt \u003cmaximilian.gerhardt@rub.de\u003e\nChange-Id: I4ab4eb7a6514c2e1c6ce4333bed1ab5ffecb5cee\n"}},"14a5539a620c29499d020f3269f5d46d0713d80b":{"kind":"REWORK","_number":6,"created":"2021-12-29 10:47:40.000000000","uploader":{"_account_id":1001949,"name":"Maximilian Gerhardt","email":"maximilian.gerhardt@rub.de","username":"maxgerhardt"},"ref":"refs/changes/94/6794/6","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/94/6794/6","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/94/6794/6 \u0026\u0026 git checkout -b change-6794 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/94/6794/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/94/6794/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/94/6794/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/94/6794/6","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/94/6794/6 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d27d66bc1bdbef0cbfe43d88597576e173317c01","subject":"Document how vector registers are exposed to gdb."}],"author":{"name":"Max Gerhardt","email":"maximilian.gerhardt@rub.de","date":"2021-12-26 12:03:22.000000000","tz":60},"committer":{"name":"Max Gerhardt","email":"maximilian.gerhardt@rub.de","date":"2021-12-29 10:46:49.000000000","tz":60},"subject":"flash/stm32f1x: Add GD32E50x Support","message":"flash/stm32f1x: Add GD32E50x Support\n\nSee user manual at https://github.com/CommunityGD32Cores/gigadevice-firmware-and-docs/blob/main/GD32E50x/GD32E50x_User_Manual_Rev1.2.pdf for reference.\n\nNotes / change justication:\n* used hardware: GD32E503C-START board with GD32E503CET6 chip and on-board CMSIS-DAP (\"GD-Link\") probe\n* SWD DPIDR: 0x0be12477\n* DBGMCU ID code: 0x20030444\n* device id part 0x444 overlaps with existing stm32f03x, had to add check on revision ID of my particular chip (0x2003) to avoid confusion, not too nice\n* device_id_register \u003d 0xE0044000 is correct per page 270\n* flash_size_reg \u003d 0x1FFFF7E0 is correct per page 44\n* page_size \u003d 8192, ppage_size \u003d 1 correct per page 47 and 57\n* the default user_data_offset \u003d 10 (bits), option_offset \u003d 0 (bits), see page 63, are already correct, same as for GD32F103\n* gd32e50x.cfg\u0027s DBG_CTL address and content correct per page 270\n* flashing of binaries and opening of a GDB server works (blinky example tested)\n* \"flash info 0\" shows expected protected page layout\n\nRemaining topics:\n* When testing in a VM, the error message \"error writing data: (null)\", this does not happen outside a VM in the Windows host.\n* the \"if (device_id \u003d\u003d 0x444 \u0026\u0026 rev_id \u003d\u003d 0x2003)\" check might not get all E50x devices, only tested for one particular GD32E503CE chip.\n\nSigned-off-by: Max Gerhardt \u003cmaximilian.gerhardt@rub.de\u003e\nChange-Id: I4ab4eb7a6514c2e1c6ce4333bed1ab5ffecb5cee\n"}},"18c50286840a06f8d7d2bf5322970a9c8288e592":{"kind":"REWORK","_number":4,"created":"2021-12-28 16:14:56.000000000","uploader":{"_account_id":1001949,"name":"Maximilian Gerhardt","email":"maximilian.gerhardt@rub.de","username":"maxgerhardt"},"ref":"refs/changes/94/6794/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/94/6794/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/94/6794/4 \u0026\u0026 git checkout -b change-6794 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/94/6794/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/94/6794/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/94/6794/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/94/6794/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/94/6794/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d27d66bc1bdbef0cbfe43d88597576e173317c01","subject":"Document how vector registers are exposed to gdb."}],"author":{"name":"Max Gerhardt","email":"maximilian.gerhardt@rub.de","date":"2021-12-26 12:03:22.000000000","tz":60},"committer":{"name":"Max Gerhardt","email":"maximilian.gerhardt@rub.de","date":"2021-12-28 16:14:27.000000000","tz":60},"subject":"flash/stm32f1x: Add GD32E50x Support","message":"flash/stm32f1x: Add GD32E50x Support\n\nSee user manual at https://github.com/CommunityGD32Cores/gigadevice-firmware-and-docs/blob/main/GD32E50x/GD32E50x_User_Manual_Rev1.2.pdf for reference.\n\nNotes / change justication:\n* used hardware: GD32E503C-START board with GD32E503CET6 chip and on-board CMSIS-DAP (\"GD-Link\") probe\n* SWD DPIDR: 0x0be12477\n* DBGMCU ID code: 0x20030444\n* device id part 0x444 overlaps with existing stm32f03x, had to add check on revision ID of my particular chip (0x2003) to avoid confusion, not too nice\n* device_id_register \u003d 0xE0044000 is correct per page 270\n* flash_size_reg \u003d 0x1FFFF7E0 is correct per page 44\n* page_size \u003d 8192, ppage_size \u003d 1 correct per page 47 and 57\n* for user_data_offset \u003d 10 (bits), option_offset \u003d 0 (bits), see page 63, same as for GD32F103\n* gd32e50x.cfg\u0027s DBG_CTL address and content correct per page 270\n* flashing of binaries and opening of a GDB server works (blinky example tested)\n* \"flash info 0\" shows expected protected page layout\n\nRemaining topics:\n* When testing in a VM, the error message \"error writing data: (null), Polling target gd32e50x.cpu failed, trying to reexamine\" occured, testing outside a VM is an outstanding task..\n* the \"if (device_id \u003d\u003d 0x444 \u0026\u0026 rev_id \u003d\u003d 0x2003)\" check might not get all E50x devices, only tested for one particular GD32E503CE chip.\n\nSigned-off-by: Max Gerhardt \u003cmaximilian.gerhardt@rub.de\u003e\nChange-Id: I4ab4eb7a6514c2e1c6ce4333bed1ab5ffecb5cee\n"}},"7d928552ed3b07972146ab2e43a5e3ba47ecafda":{"kind":"NO_CODE_CHANGE","_number":5,"created":"2021-12-28 16:19:54.000000000","uploader":{"_account_id":1001949,"name":"Maximilian Gerhardt","email":"maximilian.gerhardt@rub.de","username":"maxgerhardt"},"ref":"refs/changes/94/6794/5","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/94/6794/5","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/94/6794/5 \u0026\u0026 git checkout -b change-6794 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/94/6794/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/94/6794/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/94/6794/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/94/6794/5","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/94/6794/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d27d66bc1bdbef0cbfe43d88597576e173317c01","subject":"Document how vector registers are exposed to gdb."}],"author":{"name":"Max Gerhardt","email":"maximilian.gerhardt@rub.de","date":"2021-12-26 12:03:22.000000000","tz":60},"committer":{"name":"Max Gerhardt","email":"maximilian.gerhardt@rub.de","date":"2021-12-28 16:19:04.000000000","tz":60},"subject":"flash/stm32f1x: Add GD32E50x Support","message":"flash/stm32f1x: Add GD32E50x Support\n\nSee user manual at https://github.com/CommunityGD32Cores/gigadevice-firmware-and-docs/blob/main/GD32E50x/GD32E50x_User_Manual_Rev1.2.pdf for reference.\n\nNotes / change justication:\n* used hardware: GD32E503C-START board with GD32E503CET6 chip and on-board CMSIS-DAP (\"GD-Link\") probe\n* SWD DPIDR: 0x0be12477\n* DBGMCU ID code: 0x20030444\n* device id part 0x444 overlaps with existing stm32f03x, had to add check on revision ID of my particular chip (0x2003) to avoid confusion, not too nice\n* device_id_register \u003d 0xE0044000 is correct per page 270\n* flash_size_reg \u003d 0x1FFFF7E0 is correct per page 44\n* page_size \u003d 8192, ppage_size \u003d 1 correct per page 47 and 57\n* for user_data_offset \u003d 10 (bits), option_offset \u003d 0 (bits), see page 63, same as for GD32F103\n* gd32e50x.cfg\u0027s DBG_CTL address and content correct per page 270\n* flashing of binaries and opening of a GDB server works (blinky example tested)\n* \"flash info 0\" shows expected protected page layout\n\nRemaining topics:\n* When testing in a VM, the error message \"error writing data: (null)\", this does not happen outside a VM in the Windows host.\n* the \"if (device_id \u003d\u003d 0x444 \u0026\u0026 rev_id \u003d\u003d 0x2003)\" check might not get all E50x devices, only tested for one particular GD32E503CE chip.\n\nSigned-off-by: Max Gerhardt \u003cmaximilian.gerhardt@rub.de\u003e\nChange-Id: I4ab4eb7a6514c2e1c6ce4333bed1ab5ffecb5cee\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"NOT_READY","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"NEED"}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"]}}]}
