)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"58b06f947bdd97e1dada6af8b9c3f7947c2d3c7a","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Wren Turkal \u003cwt@penguintechs.org\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-01-04 23:30:18 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Initial cut at support for LPC55S16."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This will allow the LPC55S16 device to be debugged with openocd."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ec238ed7_a8a08cee","line":7,"updated":"2022-01-06 17:20:39.000000000","message":"Please change the first line with something like:\ntcl/target: add support for LPC55S16","commit_id":"a36c678727fcb2edd7fbc8aed6c2773969897095"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1001945,"name":"Adrien Grassein","email":"adrien.grassein@gmail.com","username":"grassead"},"change_message_id":"fba8a552247b16f1389f43e29b7e5d4c7555d1f6","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3ce8cf13_b6a9d5d4","updated":"2022-01-06 19:56:55.000000000","message":"Hello, I already add a patch for this: https://review.openocd.org/c/openocd/+/6787\nThanks,","commit_id":"a36c678727fcb2edd7fbc8aed6c2773969897095"},{"author":{"_account_id":1000160,"name":"Paul Fertser","email":"fercerpav@gmail.com","username":"pfertser"},"change_message_id":"d8fb285ddb9dc1f7343828e0ff481c27c30bb703","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"414b6873_8f6330ae","updated":"2024-03-25 21:01:12.000000000","message":"Hey. Please see if https://review.openocd.org/c/openocd/+/8189 flash driver and config work with this target.","commit_id":"a36c678727fcb2edd7fbc8aed6c2773969897095"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"58b06f947bdd97e1dada6af8b9c3f7947c2d3c7a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8d9e66d7_f74bc203","updated":"2022-01-06 17:20:39.000000000","message":"Thanks for this patch. Few comments below","commit_id":"a36c678727fcb2edd7fbc8aed6c2773969897095"},{"author":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},"change_message_id":"3d5a3b4eb6fd9dec2486711ac651da7766c1ca05","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c0db82b4_dee397f1","updated":"2024-01-24 11:22:15.000000000","message":"inline","commit_id":"a36c678727fcb2edd7fbc8aed6c2773969897095"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"c5518fd556af1b6392c9b6f517b9930ff49fb245","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e43bd8b9_ea4d37b7","in_reply_to":"3ce8cf13_b6a9d5d4","updated":"2022-01-21 18:41:16.000000000","message":"Adrien, your patch is for lpc55s69, this for lpc55s16. Did I missed something?","commit_id":"a36c678727fcb2edd7fbc8aed6c2773969897095"}],"tcl/target/lpc55s16.cfg":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"58b06f947bdd97e1dada6af8b9c3f7947c2d3c7a","unresolved":true,"context_lines":[{"line_number":1,"context_line":"source [find target/swj-dp.tcl]"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"adapter speed 4294967295"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"4a520af6_4c312da6","line":1,"updated":"2022-01-06 17:20:39.000000000","message":"Please add as first line:\n# SPDX-License-Identifier: GPL-2.0-or-later","commit_id":"a36c678727fcb2edd7fbc8aed6c2773969897095"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"58b06f947bdd97e1dada6af8b9c3f7947c2d3c7a","unresolved":true,"context_lines":[{"line_number":1,"context_line":"source [find target/swj-dp.tcl]"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"adapter speed 4294967295"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"if { [info exists CHIPNAME] } {"},{"line_number":6,"context_line":"\tset _CHIPNAME $CHIPNAME"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"b569c053_15f976e6","line":3,"updated":"2022-01-06 17:20:39.000000000","message":"the value is in kHz. Any special reason for this strange value ~4THz (0xffffffff)?\nusually we have more humble values like 1000 or 4000","commit_id":"a36c678727fcb2edd7fbc8aed6c2773969897095"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"58b06f947bdd97e1dada6af8b9c3f7947c2d3c7a","unresolved":true,"context_lines":[{"line_number":23,"context_line":"if { [info exists M33_SWD_TAPID] } {"},{"line_number":24,"context_line":"\tset _SWD_TAPID $M33_SWD_TAPID"},{"line_number":25,"context_line":"} else {"},{"line_number":26,"context_line":"#\tset _SWD_TAPID 0x2ba01477"},{"line_number":27,"context_line":"\tset _SWD_TAPID 0x0be12477"},{"line_number":28,"context_line":"}"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"554aeb9d_7d7462ab","line":26,"updated":"2022-01-06 17:20:39.000000000","message":"why this line commented out? What the reason to keep it?","commit_id":"a36c678727fcb2edd7fbc8aed6c2773969897095"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"58b06f947bdd97e1dada6af8b9c3f7947c2d3c7a","unresolved":true,"context_lines":[{"line_number":40,"context_line":"#\tset _M0_JTAG_TAPID $M0_JTAG_TAPID"},{"line_number":41,"context_line":"#} else {"},{"line_number":42,"context_line":"#\tset _M0_JTAG_TAPID 0x0ba01477"},{"line_number":43,"context_line":"#}"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"swj_newdap $_CHIPNAME m4 -irlen 4 -ircapture 0x1 -irmask 0xf \\"},{"line_number":46,"context_line":"\t\t\t\t-expected-id $_CPUTAPID"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"82c97ab5_6f8ddc4a","line":43,"updated":"2022-01-06 17:20:39.000000000","message":"same for these lines","commit_id":"a36c678727fcb2edd7fbc8aed6c2773969897095"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"58b06f947bdd97e1dada6af8b9c3f7947c2d3c7a","unresolved":true,"context_lines":[{"line_number":42,"context_line":"#\tset _M0_JTAG_TAPID 0x0ba01477"},{"line_number":43,"context_line":"#}"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"swj_newdap $_CHIPNAME m4 -irlen 4 -ircapture 0x1 -irmask 0xf \\"},{"line_number":46,"context_line":"\t\t\t\t-expected-id $_CPUTAPID"},{"line_number":47,"context_line":"dap create $_CHIPNAME.m4.dap -chain-position $_CHIPNAME.m4"},{"line_number":48,"context_line":"target create $_CHIPNAME.m4 cortex_m -dap $_CHIPNAME.m4.dap"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"fd88b1de_48835293","line":45,"updated":"2022-01-06 17:20:39.000000000","message":"M4 or M33? Few lines above you used M33_JTAG_TAPID!","commit_id":"a36c678727fcb2edd7fbc8aed6c2773969897095"},{"author":{"_account_id":1000859,"name":"Karl Palsson","email":"karlp@tweak.au","username":"karlp"},"change_message_id":"3d5a3b4eb6fd9dec2486711ac651da7766c1ca05","unresolved":true,"context_lines":[{"line_number":51,"context_line":"if { [info exists WORKAREASIZE] } {"},{"line_number":52,"context_line":"\tset _WORKAREASIZE $WORKAREASIZE"},{"line_number":53,"context_line":"} else {"},{"line_number":54,"context_line":"\tset _WORKAREASIZE 0x98000"},{"line_number":55,"context_line":"}"},{"line_number":56,"context_line":"$_CHIPNAME.m4 configure -work-area-phys 0x10000000 \\"},{"line_number":57,"context_line":"\t\t\t-work-area-size $_WORKAREASIZE -work-area-backup 0"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"ee63319e_3f8dd631","line":54,"updated":"2024-01-24 11:22:15.000000000","message":"Not only is there absolutely no reason to try and use the entire chunk of ram, there\u0027s no guarantees of both sections being automatically available, or contiguous.\n\nFurther, 0x98000 is not 256+96 anyway....  Just set this to something like 32k, that\u0027s _more_ than enough for working space for flash algorithms","commit_id":"a36c678727fcb2edd7fbc8aed6c2773969897095"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"58b06f947bdd97e1dada6af8b9c3f7947c2d3c7a","unresolved":true,"context_lines":[{"line_number":63,"context_line":"#   # the reset and will not fit our requirements for a consistent debug"},{"line_number":64,"context_line":"#   # session"},{"line_number":65,"context_line":"#   cortex_m reset_config vectreset"},{"line_number":66,"context_line":"#}"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"70e97bda_c89dfb11","line":66,"updated":"2022-01-06 17:20:39.000000000","message":"and for these","commit_id":"a36c678727fcb2edd7fbc8aed6c2773969897095"}]}