)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"7cec3aaa057ead4cff48ce1b430aeed0db9134bd","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b3a8add6_91737979","line":17,"updated":"2022-01-21 16:34:06.000000000","message":"remove the ticket number from the title and put here:\nFixes: https://sourceforge.net/p/openocd/tickets/232/","commit_id":"84ae1d36aafd844bbde4033306b58e809ffb7e99"},{"author":{"_account_id":1001953,"name":"Pavel Kirienko","email":"pavel.kirienko@gmail.com","username":"pavel-kirienko"},"change_message_id":"efca1df48f9428e5cf5be86496fe5cbab9e02f05","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b5ef9ff1_5549a807","line":17,"in_reply_to":"b3a8add6_91737979","updated":"2022-01-21 17:24:08.000000000","message":"Done","commit_id":"84ae1d36aafd844bbde4033306b58e809ffb7e99"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"118c00b4e118c296330549591ed7942c0a507b69","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Pavel Kirienko \u003cpavel.kirienko@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-01-21 19:13:25 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"semihosting: Fix return value handling for semihosting calls SYS_READ and SYS_WRITE (Fixes: https://sourceforge.net/p/openocd/tickets/232/)"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"ARM/RISC-V semihosting calls SYS_READ/SYS_WRITE require"},{"line_number":10,"context_line":"inversion of the result value as described in"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5324a402_52b0e557","line":7,"updated":"2022-01-21 18:24:17.000000000","message":"please keep short also the title, e.g.:\nsemihosting: fix return value of SYS_READ and SYS_WRITE","commit_id":"239c020d523286d83a957a447f0610ef2714e888"},{"author":{"_account_id":1001953,"name":"Pavel Kirienko","email":"pavel.kirienko@gmail.com","username":"pavel-kirienko"},"change_message_id":"631fb530af4d517587d4276c69137283e45aedfc","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Pavel Kirienko \u003cpavel.kirienko@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-01-21 19:13:25 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"semihosting: Fix return value handling for semihosting calls SYS_READ and SYS_WRITE (Fixes: https://sourceforge.net/p/openocd/tickets/232/)"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"ARM/RISC-V semihosting calls SYS_READ/SYS_WRITE require"},{"line_number":10,"context_line":"inversion of the result value as described in"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"cc97c589_a250381e","line":7,"in_reply_to":"5324a402_52b0e557","updated":"2022-01-21 18:51:04.000000000","message":"Done","commit_id":"239c020d523286d83a957a447f0610ef2714e888"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"118c00b4e118c296330549591ed7942c0a507b69","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"97ff810d_ea3a39d7","line":19,"updated":"2022-01-21 18:24:17.000000000","message":"add here the line:\nFixes: https://sourceforge.net/p/openocd/tickets/232/","commit_id":"239c020d523286d83a957a447f0610ef2714e888"},{"author":{"_account_id":1001953,"name":"Pavel Kirienko","email":"pavel.kirienko@gmail.com","username":"pavel-kirienko"},"change_message_id":"631fb530af4d517587d4276c69137283e45aedfc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"35a64663_74576e0d","line":19,"in_reply_to":"97ff810d_ea3a39d7","updated":"2022-01-21 18:51:04.000000000","message":"Done","commit_id":"239c020d523286d83a957a447f0610ef2714e888"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1001953,"name":"Pavel Kirienko","email":"pavel.kirienko@gmail.com","username":"pavel-kirienko"},"change_message_id":"e80364f31eda790a79d10323e1e36d860e682789","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"52ee9646_70c7df52","updated":"2022-01-09 21:48:21.000000000","message":"Link to the issue and the original patch by hogthrob: https://sourceforge.net/p/openocd/tickets/232/","commit_id":"84ae1d36aafd844bbde4033306b58e809ffb7e99"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"7cec3aaa057ead4cff48ce1b430aeed0db9134bd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"70229ef9_962acf2e","updated":"2022-01-21 16:34:06.000000000","message":"Please keep the lines within 70 chars in the commit message.\n\nCan you check the other proposed patches on the same/similar issue:\nhttps://review.openocd.org/c/openocd/+/5127\nhttps://review.openocd.org/c/openocd/+/6072\nWhich one is correct?","commit_id":"84ae1d36aafd844bbde4033306b58e809ffb7e99"},{"author":{"_account_id":1001953,"name":"Pavel Kirienko","email":"pavel.kirienko@gmail.com","username":"pavel-kirienko"},"change_message_id":"2c59de2b8874455733a717b3410507050d09a4f5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"dc0728ed_3b501532","in_reply_to":"52ee9646_70c7df52","updated":"2022-01-14 17:27:04.000000000","message":".","commit_id":"84ae1d36aafd844bbde4033306b58e809ffb7e99"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"118c00b4e118c296330549591ed7942c0a507b69","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"11587ad1_63a80ba9","in_reply_to":"5670c4bc_3126248a","updated":"2022-01-21 18:24:17.000000000","message":"fine for me. but I\u0027m not expert on semihosting, I will wait for other reviews on this patch.","commit_id":"84ae1d36aafd844bbde4033306b58e809ffb7e99"},{"author":{"_account_id":1001953,"name":"Pavel Kirienko","email":"pavel.kirienko@gmail.com","username":"pavel-kirienko"},"change_message_id":"0541209183a9df65513839df57b20054e1a2b36a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5670c4bc_3126248a","in_reply_to":"70229ef9_962acf2e","updated":"2022-01-21 17:23:20.000000000","message":"Commit message updated as requested.\n\nPatch 5127 is incomplete because it neglects the same issue for SYS_WRITE.\n\nPatch 6072 does not appear to handle the error case correctly -- if (result \u003c 0), semihosting-\u003eresult is not assigned.\n\nI am obviously biased but my best judgment is that my patch is cleaner.","commit_id":"84ae1d36aafd844bbde4033306b58e809ffb7e99"},{"author":{"_account_id":1001953,"name":"Pavel Kirienko","email":"pavel.kirienko@gmail.com","username":"pavel-kirienko"},"change_message_id":"c7285f108a4a4bcbdcaf72db11cd3dc394aff43b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5e3ba79f_5b3576dd","updated":"2022-06-23 18:49:23.000000000","message":"Guys, is there any chance to have this merged? This has been a known issue for a long time and it seems like there is nothing that might prevent it from being accepted. Thanks.","commit_id":"82268d4fe54f7f19f352ce842a1292d4f9f10eb2"},{"author":{"_account_id":1001242,"name":"Tim Newsome","email":"tim@sifive.com","username":"timsifive"},"change_message_id":"379c0ff3c98bcd0182a25340782f64ae91fbf1e0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ce57f52f_7bd6b7e4","updated":"2022-01-24 17:32:47.000000000","message":"Looks OK to me, and this change does not affect the semihosting smoke-test I run.","commit_id":"82268d4fe54f7f19f352ce842a1292d4f9f10eb2"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"aa33648f98608e9caa36f8bac45a251d2e07fd2d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f8ff8eef_6519688c","updated":"2022-01-21 23:35:23.000000000","message":"The patch looks ok for me, but I\u0027m not comfortable on semihosting. I would like some other reviewer to agree.","commit_id":"82268d4fe54f7f19f352ce842a1292d4f9f10eb2"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"82e2066025af7f662cc3557184d0644dba1188fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7ae9f5b5_3724f845","updated":"2022-06-25 14:26:50.000000000","message":"queued for merge next weekend\nthanks","commit_id":"82268d4fe54f7f19f352ce842a1292d4f9f10eb2"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"b9e2dce1300e4bd28d9f415585aef052a38e7a9f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5f471de5_af226294","updated":"2022-06-25 14:35:09.000000000","message":"there are two conflicting patches that partially fox the same issue\nhttps://review.openocd.org/5127/\nhttps://review.openocd.org/6072/\nDo you agree that this patch 6803 is more complete and the other two can be dropped?","commit_id":"82268d4fe54f7f19f352ce842a1292d4f9f10eb2"},{"author":{"_account_id":1001953,"name":"Pavel Kirienko","email":"pavel.kirienko@gmail.com","username":"pavel-kirienko"},"change_message_id":"9f0195ef209dc9dd0c86f06cca9165ff70698384","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"859d2478_7378675d","in_reply_to":"5f471de5_af226294","updated":"2022-06-25 15:20:34.000000000","message":"See my answer above.","commit_id":"82268d4fe54f7f19f352ce842a1292d4f9f10eb2"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"a9f24de9942ef097ad00cdd259ef2a154e4f4986","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b896b304_43fda73e","in_reply_to":"859d2478_7378675d","updated":"2022-07-02 08:28:23.000000000","message":"Right, sorry for returning to it!","commit_id":"82268d4fe54f7f19f352ce842a1292d4f9f10eb2"}]}