)]}'
{"id":"openocd~master~Ifb2c740fd689e71d6f1a4bde1edaecd76fdca910","project":"openocd","branch":"master","attention_set":{"1001953":{"account":{"_account_id":1001953,"name":"Pavel Kirienko","email":"pavel.kirienko@gmail.com","username":"pavel-kirienko"},"last_update":"2022-03-03 15:18:43.000000000","reason":"Antonio Borneo replied on the change"}},"removed_from_attention_set":{"1001667":{"account":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"last_update":"2022-01-29 18:25:21.000000000","reason":"Change was submitted"},"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2022-01-29 18:24:43.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"Ifb2c740fd689e71d6f1a4bde1edaecd76fdca910","subject":"semihosting: use open mode flags from GDB, not from sys/stat.h","status":"MERGED","created":"2022-01-09 21:35:29.000000000","updated":"2022-03-04 06:42:24.000000000","submitted":"2022-01-29 18:25:21.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":15,"unresolved_comment_count":3,"has_review_started":true,"submission_id":"6804","meta_rev_id":"cf18f38d8221197d01f09aed6a7d43065c3a2eed","_number":6804,"owner":{"_account_id":1001953,"name":"Pavel Kirienko","email":"pavel.kirienko@gmail.com","username":"pavel-kirienko"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-01-29 18:25:21.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"value":0,"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-01-29 18:25:21.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"}],"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-01-09 21:41:04.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2022-01-09 22:09:30.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-01-11 11:54:57.000000000","updated_by":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"reviewer":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"state":"REVIEWER"},{"updated":"2022-01-21 16:11:37.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"CC"},{"updated":"2022-01-21 23:28:35.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"},{"updated":"2022-03-03 15:07:39.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"state":"CC"}],"messages":[{"id":"506ab06bc1ee79a18698012bd0d26a22fe83ce67","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001953,"name":"Pavel Kirienko","email":"pavel.kirienko@gmail.com","username":"pavel-kirienko"},"real_author":{"_account_id":1001953,"name":"Pavel Kirienko","email":"pavel.kirienko@gmail.com","username":"pavel-kirienko"},"date":"2022-01-09 21:35:29.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"6a8e54708efa91d033774806ca5b8f21db8a6c96","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001953,"name":"Pavel Kirienko","email":"pavel.kirienko@gmail.com","username":"pavel-kirienko"},"real_author":{"_account_id":1001953,"name":"Pavel Kirienko","email":"pavel.kirienko@gmail.com","username":"pavel-kirienko"},"date":"2022-01-09 21:40:48.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"269c9df84f21a69045b66d882e7ddafce16ff588","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-01-09 21:41:04.000000000","message":"Patch Set 1:\n\nNo Builds Executed","accounts_in_message":[],"_revision_number":1},{"id":"e86b82b6090d64c56734fc2ae4dfcebd176c4a76","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-01-09 22:09:30.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15757/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14974/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"e4b39864a79a7e8282b204d5ff6c683837117028","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2022-01-11 11:54:57.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"da3b680ed10009e48620a16330c77e19781a7f0e","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-01-21 16:11:37.000000000","message":"Patch Set 2:\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"3ce4776ea46fbce2c1845c1bf922af772d2281f4","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001953,"name":"Pavel Kirienko","email":"pavel.kirienko@gmail.com","username":"pavel-kirienko"},"real_author":{"_account_id":1001953,"name":"Pavel Kirienko","email":"pavel.kirienko@gmail.com","username":"pavel-kirienko"},"date":"2022-01-21 17:18:31.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"53236780f7de6d051afee1b73a68ef2322812f7b","author":{"_account_id":1001953,"name":"Pavel Kirienko","email":"pavel.kirienko@gmail.com","username":"pavel-kirienko"},"real_author":{"_account_id":1001953,"name":"Pavel Kirienko","email":"pavel.kirienko@gmail.com","username":"pavel-kirienko"},"date":"2022-01-21 17:25:08.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"97675f6593ab3a41cf677c38a1ba6c0602c08b6a","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-01-21 17:49:43.000000000","message":"Patch Set 3: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15770/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14988/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"3f943a065ee8703d80c255e2d26a109ad8b26395","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-01-21 18:27:26.000000000","message":"Patch Set 3:\n\n(2 comments)","accounts_in_message":[],"_revision_number":3},{"id":"8198276e5fb71506b9fd3275d95c92fc21647b1f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001953,"name":"Pavel Kirienko","email":"pavel.kirienko@gmail.com","username":"pavel-kirienko"},"real_author":{"_account_id":1001953,"name":"Pavel Kirienko","email":"pavel.kirienko@gmail.com","username":"pavel-kirienko"},"date":"2022-01-21 18:50:06.000000000","message":"Uploaded patch set 4: Commit message was updated.","accounts_in_message":[],"_revision_number":4},{"id":"c4ae7c438a0ae41940c502c4a163a27d39a88cfa","author":{"_account_id":1001953,"name":"Pavel Kirienko","email":"pavel.kirienko@gmail.com","username":"pavel-kirienko"},"real_author":{"_account_id":1001953,"name":"Pavel Kirienko","email":"pavel.kirienko@gmail.com","username":"pavel-kirienko"},"date":"2022-01-21 18:51:28.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"541cf1fe15a614e81565f340965ce00f75513c9c","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-01-21 19:19:08.000000000","message":"Patch Set 4: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15773/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14990/ : SUCCESS","accounts_in_message":[],"_revision_number":4},{"id":"06858536944f394ed72157b1512d7911cfccb2b7","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-01-21 23:28:35.000000000","message":"Patch Set 4: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"3a61e40e87f92f8c16ab2b92e3df43ed9ad3cb28","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2022-01-24 13:11:59.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"a259ee16129d0840740e5112256bdb8aa5b53660","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-01-29 18:24:43.000000000","message":"Patch Set 4: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"fd602ff959d80657ef5d1aa9a39f36907874b235","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-01-29 18:25:21.000000000","message":"Change has been successfully cherry-picked as dbbac5f11d662ab0827a997aa5d173fd62c51708","accounts_in_message":[],"_revision_number":5},{"id":"fed049511500ec5209f9cc15d3e6c2a83d963c0c","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-03-03 15:18:43.000000000","message":"Patch Set 5:\n\n(3 comments)","accounts_in_message":[],"_revision_number":5},{"id":"685d051b6e7a9c40daaf1b210f93042464694ab6","author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"real_author":{"_account_id":1001964,"name":"Erhan Kurubas","display_name":"Erhan Kurubas","email":"erhan.kurubas@espressif.com","username":"erhankur"},"date":"2022-03-03 17:35:13.000000000","message":"Patch Set 5:\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"cf18f38d8221197d01f09aed6a7d43065c3a2eed","author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"real_author":{"_account_id":1001667,"name":"Jan Matyas","email":"jan.matyas@codasip.com","username":"JanMatCodasip"},"date":"2022-03-04 06:42:24.000000000","message":"Patch Set 5:\n\n(1 comment)","accounts_in_message":[],"_revision_number":5}],"current_revision":"dbbac5f11d662ab0827a997aa5d173fd62c51708","revisions":{"63864135c28544e5926aecddb7330530b236cb05":{"kind":"REWORK","_number":1,"created":"2022-01-09 21:35:29.000000000","uploader":{"_account_id":1001953,"name":"Pavel Kirienko","email":"pavel.kirienko@gmail.com","username":"pavel-kirienko"},"ref":"refs/changes/04/6804/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/04/6804/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/04/6804/1 \u0026\u0026 git checkout -b change-6804 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/04/6804/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/04/6804/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/04/6804/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/04/6804/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/04/6804/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"84ae1d36aafd844bbde4033306b58e809ffb7e99","subject":"semihosting: Fix return value handling for semihosting calls SYS_READ and SYS_WRITE (ticket #232)"}],"author":{"name":"Pavel Kirienko","email":"pavel.kirienko@gmail.com","date":"2022-01-09 21:18:13.000000000","tz":120},"committer":{"name":"Pavel Kirienko","email":"pavel.kirienko@gmail.com","date":"2022-01-09 21:34:27.000000000","tz":120},"subject":"semihosting: Replace incorrect semihosting file open mode flags pulled from sys/stat.h with correct values defined by the GDB remote protocol","message":"semihosting: Replace incorrect semihosting file open mode flags pulled from sys/stat.h with correct values defined by the GDB remote protocol\n\nValues defined in sys/stat.h are not guaranteed to match the constants defined by the GDB remote protocol,\nwhich are defined in https://sourceware.org/gdb/onlinedocs/gdb/Open-Flags.html#Open-Flags.\nOn my local system, for example, O_TRUNC is defined as 0x40, whereas GDB requires it to be 0x400,\ncausing all \"w\" file open modes to misbehave.\n\nThis patch has been tested with STM32F446.\n\nChange-Id: Ifb2c740fd689e71d6f1a4bde1edaecd76fdca910\nSigned-off-by: Pavel Kirienko \u003cpavel.kirienko@gmail.com\u003e\n"}},"7c84ee233bb16c4c2e10d47fdc15cc56b5b861aa":{"kind":"REWORK","_number":3,"created":"2022-01-21 17:18:31.000000000","uploader":{"_account_id":1001953,"name":"Pavel Kirienko","email":"pavel.kirienko@gmail.com","username":"pavel-kirienko"},"ref":"refs/changes/04/6804/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/04/6804/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/04/6804/3 \u0026\u0026 git checkout -b change-6804 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/04/6804/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/04/6804/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/04/6804/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/04/6804/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/04/6804/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"239c020d523286d83a957a447f0610ef2714e888","subject":"semihosting: Fix return value handling for semihosting calls SYS_READ and SYS_WRITE (Fixes: https://sourceforge.net/p/openocd/tickets/232/)"}],"author":{"name":"Pavel Kirienko","email":"pavel.kirienko@gmail.com","date":"2022-01-09 21:18:13.000000000","tz":120},"committer":{"name":"Pavel Kirienko","email":"pavel.kirienko@gmail.com","date":"2022-01-21 17:16:09.000000000","tz":120},"subject":"semihosting: Replace incorrect semihosting file open mode flags pulled from sys/stat.h with correct values defined by the GDB remote protocol","message":"semihosting: Replace incorrect semihosting file open mode flags pulled from sys/stat.h with correct values defined by the GDB remote protocol\n\nValues defined in sys/stat.h are not guaranteed to match\nthe constants defined by the GDB remote protocol, which are defined in\nhttps://sourceware.org/gdb/onlinedocs/gdb/Open-Flags.html#Open-Flags.\nOn my local system (Manjaro 21.2.1 x86_64), for example, O_TRUNC is\ndefined as 0x40, whereas GDB requires it to be 0x400,\ncausing all \"w\" file open modes to misbehave.\n\nThis patch has been tested with STM32F446.\n\nChange-Id: Ifb2c740fd689e71d6f1a4bde1edaecd76fdca910\nSigned-off-by: Pavel Kirienko \u003cpavel.kirienko@gmail.com\u003e\n"}},"72144621597eeeeeec91184d2f1279cfe1447e58":{"kind":"REWORK","_number":2,"created":"2022-01-09 21:40:48.000000000","uploader":{"_account_id":1001953,"name":"Pavel Kirienko","email":"pavel.kirienko@gmail.com","username":"pavel-kirienko"},"ref":"refs/changes/04/6804/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/04/6804/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/04/6804/2 \u0026\u0026 git checkout -b change-6804 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/04/6804/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/04/6804/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/04/6804/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/04/6804/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/04/6804/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"84ae1d36aafd844bbde4033306b58e809ffb7e99","subject":"semihosting: Fix return value handling for semihosting calls SYS_READ and SYS_WRITE (ticket #232)"}],"author":{"name":"Pavel Kirienko","email":"pavel.kirienko@gmail.com","date":"2022-01-09 21:18:13.000000000","tz":120},"committer":{"name":"Pavel Kirienko","email":"pavel.kirienko@gmail.com","date":"2022-01-09 21:40:28.000000000","tz":120},"subject":"semihosting: Replace incorrect semihosting file open mode flags pulled from sys/stat.h with correct values defined by the GDB remote protocol","message":"semihosting: Replace incorrect semihosting file open mode flags pulled from sys/stat.h with correct values defined by the GDB remote protocol\n\nValues defined in sys/stat.h are not guaranteed to match the constants defined by the GDB remote protocol,\nwhich are defined in https://sourceware.org/gdb/onlinedocs/gdb/Open-Flags.html#Open-Flags.\nOn my local system, for example, O_TRUNC is defined as 0x40, whereas GDB requires it to be 0x400,\ncausing all \"w\" file open modes to misbehave.\n\nThis patch has been tested with STM32F446.\n\nChange-Id: Ifb2c740fd689e71d6f1a4bde1edaecd76fdca910\nSigned-off-by: Pavel Kirienko \u003cpavel.kirienko@gmail.com\u003e\n"}},"dbbac5f11d662ab0827a997aa5d173fd62c51708":{"kind":"REWORK","_number":5,"created":"2022-01-29 18:25:21.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/04/6804/5","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/04/6804/5","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/04/6804/5 \u0026\u0026 git checkout -b change-6804 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/04/6804/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/04/6804/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/04/6804/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/04/6804/5","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/04/6804/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"6541233aa78d40200092920ec4a72e3917ae3b6d","subject":"Combine register lists of smp targets."}],"author":{"name":"Pavel Kirienko","email":"pavel.kirienko@gmail.com","date":"2022-01-09 21:18:13.000000000","tz":120},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-01-29 18:25:21.000000000","tz":0},"subject":"semihosting: use open mode flags from GDB, not from sys/stat.h","message":"semihosting: use open mode flags from GDB, not from sys/stat.h\n\nValues defined in sys/stat.h are not guaranteed to match\nthe constants defined by the GDB remote protocol, which are defined in\nhttps://sourceware.org/gdb/onlinedocs/gdb/Open-Flags.html#Open-Flags.\nOn my local system (Manjaro 21.2.1 x86_64), for example, O_TRUNC is\ndefined as 0x40, whereas GDB requires it to be 0x400,\ncausing all \"w\" file open modes to misbehave.\n\nThis patch has been tested with STM32F446.\n\nChange-Id: Ifb2c740fd689e71d6f1a4bde1edaecd76fdca910\nSigned-off-by: Pavel Kirienko \u003cpavel.kirienko@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6804\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"9cce379c32a9198f2c91c02d1ecd5e4eaee78d6d":{"kind":"NO_CODE_CHANGE","_number":4,"created":"2022-01-21 18:50:06.000000000","uploader":{"_account_id":1001953,"name":"Pavel Kirienko","email":"pavel.kirienko@gmail.com","username":"pavel-kirienko"},"ref":"refs/changes/04/6804/4","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/04/6804/4","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/04/6804/4 \u0026\u0026 git checkout -b change-6804 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/04/6804/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/04/6804/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/04/6804/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/04/6804/4","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/04/6804/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"82268d4fe54f7f19f352ce842a1292d4f9f10eb2","subject":"semihosting: fix return value of SYS_READ and SYS_WRITE"}],"author":{"name":"Pavel Kirienko","email":"pavel.kirienko@gmail.com","date":"2022-01-09 21:18:13.000000000","tz":120},"committer":{"name":"Pavel Kirienko","email":"pavel.kirienko@gmail.com","date":"2022-01-21 18:49:22.000000000","tz":120},"subject":"semihosting: use open mode flags from GDB, not from sys/stat.h","message":"semihosting: use open mode flags from GDB, not from sys/stat.h\n\nValues defined in sys/stat.h are not guaranteed to match\nthe constants defined by the GDB remote protocol, which are defined in\nhttps://sourceware.org/gdb/onlinedocs/gdb/Open-Flags.html#Open-Flags.\nOn my local system (Manjaro 21.2.1 x86_64), for example, O_TRUNC is\ndefined as 0x40, whereas GDB requires it to be 0x400,\ncausing all \"w\" file open modes to misbehave.\n\nThis patch has been tested with STM32F446.\n\nChange-Id: Ifb2c740fd689e71d6f1a4bde1edaecd76fdca910\nSigned-off-by: Pavel Kirienko \u003cpavel.kirienko@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}