)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3c22bae3e456e7f85725e89e93714d433d9bd514","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0e69c49b_1fe38ae3","updated":"2022-01-21 17:42:50.000000000","message":"Looks ok for me.\nARM documentation does not report there should be error from DRPS in this case, but anyway does not make sense to run any operation in armv8_dpm_modeswitch() to remain in the same mode.\nI\u0027m just thinking if the check should be moved before, so armv8_dpm_modeswitch() returns without marking dirty some of the registers. This would make this case more visible and giving some minor performance improvement.\nWhat do you think?","commit_id":"6ec8c9709448a8d5e7fc868124fae6fc07273b41"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"da10a28aa512fd6402078fa765fae033d2387b00","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"28863a9e_a2000379","updated":"2023-04-11 15:53:15.000000000","message":"I completely lost this series in my inbox.\nApparently it still applies to master branch, so let\u0027s go ahead. I will merge it in 2 weeks, if nobody complains.","commit_id":"18cccdb96b3fbdaf369991c8c9a0eccc7996f1ee"}],"src/target/armv8_dpm.c":[{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"3c22bae3e456e7f85725e89e93714d433d9bd514","unresolved":true,"context_lines":[{"line_number":595,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":596,"context_line":"\t}"},{"line_number":597,"context_line":""},{"line_number":598,"context_line":"\tLOG_DEBUG(\"target_el \u003d %i, last_el \u003d %i\", target_el, dpm-\u003elast_el);"},{"line_number":599,"context_line":"\tif (target_el \u003e dpm-\u003elast_el) {"},{"line_number":600,"context_line":"\t\tretval \u003d dpm-\u003einstr_execute(dpm,"},{"line_number":601,"context_line":"\t\t\t\tarmv8_opcode(armv8, ARMV8_OPC_DCPS) | target_el);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"03c6d3ad_d90c25ca","line":598,"updated":"2022-01-21 17:42:50.000000000","message":"e.g. moving here:\nif (dpm-\u003elast_el \u003d\u003d target_el)\n   return ERROR_OK; /* nothing to do */\nThis early exit implicitly makes impossible using DRPS in EL0, but let\u0027s keep the test in line 609. In fact, once excluded dpm-\u003elast_el \u003d\u003d target_el:\nif (target_el \u003e dpm-\u003elast_el) {\n   ...\n} else {\n   /* here target_el \u003c dpm-\u003elast_el, but target_el is unsigned, so dpm-\u003elast_el is \u003e0 */\n   if (dpm-\u003elast_el !\u003d 0) { /* must be true */","commit_id":"6ec8c9709448a8d5e7fc868124fae6fc07273b41"},{"author":{"_account_id":1001902,"name":"Julien Massot","email":"julien.massot@iot.bzh","username":"julien-massot"},"change_message_id":"932bf058e45499d43049b8cc0562cb6b2109c371","unresolved":true,"context_lines":[{"line_number":595,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":596,"context_line":"\t}"},{"line_number":597,"context_line":""},{"line_number":598,"context_line":"\tLOG_DEBUG(\"target_el \u003d %i, last_el \u003d %i\", target_el, dpm-\u003elast_el);"},{"line_number":599,"context_line":"\tif (target_el \u003e dpm-\u003elast_el) {"},{"line_number":600,"context_line":"\t\tretval \u003d dpm-\u003einstr_execute(dpm,"},{"line_number":601,"context_line":"\t\t\t\tarmv8_opcode(armv8, ARMV8_OPC_DCPS) | target_el);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"4ae11922_f01b66a8","line":598,"in_reply_to":"03c6d3ad_d90c25ca","updated":"2022-02-04 09:19:46.000000000","message":"Just send a new version with your suggestion","commit_id":"6ec8c9709448a8d5e7fc868124fae6fc07273b41"},{"author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"change_message_id":"da10a28aa512fd6402078fa765fae033d2387b00","unresolved":false,"context_lines":[{"line_number":595,"context_line":"\t\treturn ERROR_FAIL;"},{"line_number":596,"context_line":"\t}"},{"line_number":597,"context_line":""},{"line_number":598,"context_line":"\tLOG_DEBUG(\"target_el \u003d %i, last_el \u003d %i\", target_el, dpm-\u003elast_el);"},{"line_number":599,"context_line":"\tif (target_el \u003e dpm-\u003elast_el) {"},{"line_number":600,"context_line":"\t\tretval \u003d dpm-\u003einstr_execute(dpm,"},{"line_number":601,"context_line":"\t\t\t\tarmv8_opcode(armv8, ARMV8_OPC_DCPS) | target_el);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"d4614e85_7a60ffa2","line":598,"in_reply_to":"4ae11922_f01b66a8","updated":"2023-04-11 15:53:15.000000000","message":"Done","commit_id":"6ec8c9709448a8d5e7fc868124fae6fc07273b41"}]}