)]}'
{"id":"openocd~master~I41d1006233251dcaf6d69bda580488b204b7eb63","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2023-04-11 15:53:15.000000000","reason":"Antonio Borneo replied on the change"},"1001902":{"account":{"_account_id":1001902,"name":"Julien Massot","email":"julien.massot@iot.bzh","username":"julien-massot"},"last_update":"2023-04-30 14:44:52.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I41d1006233251dcaf6d69bda580488b204b7eb63","subject":"target:armv8: aarch32 do not try to restore same EL","status":"MERGED","created":"2022-01-12 13:14:32.000000000","updated":"2023-04-30 14:44:52.000000000","submitted":"2023-04-30 14:44:52.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":5,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6807","meta_rev_id":"ac8fbf3df8a76dfa64de9506c26a7ac121001a7e","_number":6807,"owner":{"_account_id":1001902,"name":"Julien Massot","email":"julien.massot@iot.bzh","username":"julien-massot"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-04-30 14:44:52.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-04-30 14:44:52.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-01-12 13:32:51.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-01-21 17:42:50.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"CC"},{"updated":"2023-04-11 15:53:15.000000000","updated_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"reviewer":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"state":"REVIEWER"}],"messages":[{"id":"bc484e26d44ae99605c9ec9204d4774667078d72","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001902,"name":"Julien Massot","email":"julien.massot@iot.bzh","username":"julien-massot"},"real_author":{"_account_id":1001902,"name":"Julien Massot","email":"julien.massot@iot.bzh","username":"julien-massot"},"date":"2022-01-12 13:14:32.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e842ef274a3df9156e3f5c1fc2abe79bc8b17160","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-01-12 13:32:51.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15761/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14978/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"3c22bae3e456e7f85725e89e93714d433d9bd514","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-01-21 17:42:50.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"2e244128e9809982c923461c2c056c3b6d0bfbfb","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001902,"name":"Julien Massot","email":"julien.massot@iot.bzh","username":"julien-massot"},"real_author":{"_account_id":1001902,"name":"Julien Massot","email":"julien.massot@iot.bzh","username":"julien-massot"},"date":"2022-02-04 09:14:50.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"932bf058e45499d43049b8cc0562cb6b2109c371","author":{"_account_id":1001902,"name":"Julien Massot","email":"julien.massot@iot.bzh","username":"julien-massot"},"real_author":{"_account_id":1001902,"name":"Julien Massot","email":"julien.massot@iot.bzh","username":"julien-massot"},"date":"2022-02-04 09:19:46.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"f8fe776c29ac7dbfbf025027f1095660ddffb8a6","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-02-04 09:41:42.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15840/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/15052/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"da10a28aa512fd6402078fa765fae033d2387b00","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-04-11 15:53:15.000000000","message":"Patch Set 2: Code-Review+1\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"b96e77ff7151fc369e854363f0f247cdfe1adc7f","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-04-30 14:44:24.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"ac8fbf3df8a76dfa64de9506c26a7ac121001a7e","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2023-04-30 14:44:52.000000000","message":"Change has been successfully cherry-picked as 0bb0056abc269ed14b04cbb1d768fb0281e64225","accounts_in_message":[],"_revision_number":3}],"current_revision":"0bb0056abc269ed14b04cbb1d768fb0281e64225","revisions":{"0bb0056abc269ed14b04cbb1d768fb0281e64225":{"kind":"REWORK","_number":3,"created":"2023-04-30 14:44:52.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/07/6807/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/07/6807/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/07/6807/3 \u0026\u0026 git checkout -b change-6807 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/07/6807/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/07/6807/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/07/6807/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/07/6807/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/07/6807/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"91bd4313444c5a949ce49d88ab487608df7d6c37","subject":"pld: move file sanity checks to pld.c"}],"author":{"name":"Julien Massot","email":"julien.massot@iot.bzh","date":"2022-01-12 13:10:36.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2023-04-30 14:44:52.000000000","tz":0},"subject":"target:armv8: aarch32 do not try to restore same EL","message":"target:armv8: aarch32 do not try to restore same EL\n\nWhile debugging a Cortex-R52 OpenOCD fail to restore context\non line\nretval \u003d dpm-\u003einstr_write_data_r0(dpm,\n\t\tARMV8_MSR_GP_xPSR_T1(1, 0, 15), cpsr);\n\nwhich trigger this exception:\n\naarch64.c:1206 aarch64_restore_context(): r8a779a0.r52\narmv8_dpm.c:560 armv8_dpm_modeswitch(): restoring mode, cpsr \u003d 0x0000011f\n1262753 armv8_dpm.c:598 armv8_dpm_modeswitch(): target_el \u003d 1, last_el \u003d 1\narmv8_dpm.c:611 armv8_dpm_modeswitch(): SPSR \u003d 0x0000011f\narmv8_dpm.c:260 dpmv8_exec_opcode(): Opcode 0x8f00f390, DSCR.ERR\u003d1, DSCR.EL\u003d1\n\nand finally OpenOCD doesn\u0027t succeed to restore the processor.\n\nThis check \u0027dpm-\u003elast_el !\u003d target_el\u0027 exist for aarch64,\nso might be correct for aarch32 too.\n\nSigned-off-by: Julien Massot \u003cjulien.massot@iot.bzh\u003e\nChange-Id: I41d1006233251dcaf6d69bda580488b204b7eb63\nReviewed-on: https://review.openocd.org/c/openocd/+/6807\nTested-by: jenkins\nReviewed-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"18cccdb96b3fbdaf369991c8c9a0eccc7996f1ee":{"kind":"REWORK","_number":2,"created":"2022-02-04 09:14:50.000000000","uploader":{"_account_id":1001902,"name":"Julien Massot","email":"julien.massot@iot.bzh","username":"julien-massot"},"ref":"refs/changes/07/6807/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/07/6807/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/07/6807/2 \u0026\u0026 git checkout -b change-6807 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/07/6807/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/07/6807/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/07/6807/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/07/6807/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/07/6807/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"dbbac5f11d662ab0827a997aa5d173fd62c51708","subject":"semihosting: use open mode flags from GDB, not from sys/stat.h"}],"author":{"name":"Julien Massot","email":"julien.massot@iot.bzh","date":"2022-01-12 13:10:36.000000000","tz":60},"committer":{"name":"Julien Massot","email":"julien.massot@iot.bzh","date":"2022-02-04 08:59:11.000000000","tz":60},"subject":"target:armv8: aarch32 do not try to restore same EL","message":"target:armv8: aarch32 do not try to restore same EL\n\nWhile debugging a Cortex-R52 OpenOCD fail to restore context\non line\nretval \u003d dpm-\u003einstr_write_data_r0(dpm,\n\t\tARMV8_MSR_GP_xPSR_T1(1, 0, 15), cpsr);\n\nwhich trigger this exception:\n\naarch64.c:1206 aarch64_restore_context(): r8a779a0.r52\narmv8_dpm.c:560 armv8_dpm_modeswitch(): restoring mode, cpsr \u003d 0x0000011f\n1262753 armv8_dpm.c:598 armv8_dpm_modeswitch(): target_el \u003d 1, last_el \u003d 1\narmv8_dpm.c:611 armv8_dpm_modeswitch(): SPSR \u003d 0x0000011f\narmv8_dpm.c:260 dpmv8_exec_opcode(): Opcode 0x8f00f390, DSCR.ERR\u003d1, DSCR.EL\u003d1\n\nand finally OpenOCD doesn\u0027t succeed to restore the processor.\n\nThis check \u0027dpm-\u003elast_el !\u003d target_el\u0027 exist for aarch64,\nso might be correct for aarch32 too.\n\nSigned-off-by: Julien Massot \u003cjulien.massot@iot.bzh\u003e\nChange-Id: I41d1006233251dcaf6d69bda580488b204b7eb63\n"}},"6ec8c9709448a8d5e7fc868124fae6fc07273b41":{"kind":"REWORK","_number":1,"created":"2022-01-12 13:14:32.000000000","uploader":{"_account_id":1001902,"name":"Julien Massot","email":"julien.massot@iot.bzh","username":"julien-massot"},"ref":"refs/changes/07/6807/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/07/6807/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/07/6807/1 \u0026\u0026 git checkout -b change-6807 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/07/6807/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/07/6807/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/07/6807/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/07/6807/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/07/6807/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"aad87180586a43500f8af1cf79255c7293bb258b","subject":"flash/nor/efr32: fixed lockbits and user data"}],"author":{"name":"Julien Massot","email":"julien.massot@iot.bzh","date":"2022-01-12 13:10:36.000000000","tz":60},"committer":{"name":"Julien Massot","email":"julien.massot@iot.bzh","date":"2022-01-12 13:14:19.000000000","tz":60},"subject":"target:armv8: aarch32 do not try to restore same EL","message":"target:armv8: aarch32 do not try to restore same EL\n\nWhile debugging a Cortex-R52 OpenOCD fail to restore context\non line\nretval \u003d dpm-\u003einstr_write_data_r0(dpm,\n\t\tARMV8_MSR_GP_xPSR_T1(1, 0, 15), cpsr);\n\nwhich trigger this exception:\n\naarch64.c:1206 aarch64_restore_context(): r8a779a0.r52\narmv8_dpm.c:560 armv8_dpm_modeswitch(): restoring mode, cpsr \u003d 0x0000011f\n1262753 armv8_dpm.c:598 armv8_dpm_modeswitch(): target_el \u003d 1, last_el \u003d 1\narmv8_dpm.c:611 armv8_dpm_modeswitch(): SPSR \u003d 0x0000011f\narmv8_dpm.c:260 dpmv8_exec_opcode(): Opcode 0x8f00f390, DSCR.ERR\u003d1, DSCR.EL\u003d1\n\nand finally OpenOCD doesn\u0027t succeed to restore the processor.\n\nThis check \u0027dpm-\u003elast_el !\u003d target_el\u0027 exist for aarch64,\nso might be correct for aarch32 too.\n\nSigned-off-by: Julien Massot \u003cjulien.massot@iot.bzh\u003e\nChange-Id: I41d1006233251dcaf6d69bda580488b204b7eb63\n"}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}}]}