)]}'
{"id":"openocd~master~I15260f8a86d9002769a1ae1c40ebdf62142dae18","project":"openocd","branch":"master","attention_set":{},"removed_from_attention_set":{"1001954":{"account":{"_account_id":1001954,"name":"Simon Johansson","email":"ampleyfly@gmail.com","username":"ampleyfly"},"last_update":"2022-02-25 10:58:41.000000000","reason":"Change was submitted"},"1000863":{"account":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"last_update":"2022-02-25 10:58:41.000000000","reason":"Change was submitted"},"1000687":{"account":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"last_update":"2022-02-10 10:37:17.000000000","reason":"Tomas Vanek replied on the change"}},"hashtags":[],"change_id":"I15260f8a86d9002769a1ae1c40ebdf62142dae18","subject":"flash/nor/stm32f2x: Fix erase of bank 2 sectors","status":"MERGED","created":"2022-01-17 13:16:14.000000000","updated":"2022-02-25 10:58:41.000000000","submitted":"2022-02-25 10:58:41.000000000","submitter":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"total_comment_count":7,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6810","meta_rev_id":"7d64871109c54388dc3abd680fb2ebf8fe472c49","_number":6810,"owner":{"_account_id":1001954,"name":"Simon Johansson","email":"ampleyfly@gmail.com","username":"ampleyfly"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"value":0,"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-02-25 10:58:41.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-02-25 10:58:41.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-02-25 10:58:41.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-01-17 13:36:35.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-01-17 15:10:18.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"state":"REVIEWER"},{"updated":"2022-01-17 15:10:18.000000000","updated_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"reviewer":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"state":"REVIEWER"}],"messages":[{"id":"5ecf8f0eaac77ffc383c5640a223bf95e3718ea3","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1001954,"name":"Simon Johansson","email":"ampleyfly@gmail.com","username":"ampleyfly"},"real_author":{"_account_id":1001954,"name":"Simon Johansson","email":"ampleyfly@gmail.com","username":"ampleyfly"},"date":"2022-01-17 13:16:14.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"0852c5833cdac566ca801d01cf7bc5297520b14a","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-01-17 13:36:35.000000000","message":"Patch Set 1: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15764/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14981/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"d559788c230c536ca58966fe622b2aae37d4bee5","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-01-17 15:10:18.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"8d222305d6860d74a074e71b768e8ae95eda990a","author":{"_account_id":1001954,"name":"Simon Johansson","email":"ampleyfly@gmail.com","username":"ampleyfly"},"real_author":{"_account_id":1001954,"name":"Simon Johansson","email":"ampleyfly@gmail.com","username":"ampleyfly"},"date":"2022-01-18 13:16:22.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"c3f4fe7c669bea5158c99cbf0d42e63fa07be4e8","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-01-29 20:55:50.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"f61004b8ae3bd78c4f4e1036ca1f3457786483c2","author":{"_account_id":1001954,"name":"Simon Johansson","email":"ampleyfly@gmail.com","username":"ampleyfly"},"real_author":{"_account_id":1001954,"name":"Simon Johansson","email":"ampleyfly@gmail.com","username":"ampleyfly"},"date":"2022-02-10 09:37:06.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"b6107b7930b3996a7a2b3357611daa9113fe7dbb","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-02-10 10:37:17.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"1b7ef5857f921ee3ebf4f926d3a40d70237401a9","author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"real_author":{"_account_id":1000863,"name":"Tarek BOCHKATI","email":"tarek.bouchkati@gmail.com","username":"BouchkatiTarek"},"date":"2022-02-25 10:55:40.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"b6a17ca593ece4d536bedfed79229be224f4baa6","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-02-25 10:58:32.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"7d64871109c54388dc3abd680fb2ebf8fe472c49","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"real_author":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"date":"2022-02-25 10:58:41.000000000","message":"Change has been successfully cherry-picked as 29912328f07d562281e8a0db8855c8362afba546","accounts_in_message":[],"_revision_number":2}],"current_revision":"29912328f07d562281e8a0db8855c8362afba546","revisions":{"29912328f07d562281e8a0db8855c8362afba546":{"kind":"REWORK","_number":2,"created":"2022-02-25 10:58:41.000000000","uploader":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"},"ref":"refs/changes/10/6810/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/10/6810/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/10/6810/2 \u0026\u0026 git checkout -b change-6810 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/10/6810/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/10/6810/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/10/6810/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/10/6810/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/10/6810/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"94e7535be85a7bd5905dec68b6eae9a98aae0d7e","subject":".gitmodules: switch away from repo.or.cz"}],"author":{"name":"Simon Johansson","email":"ampleyfly@gmail.com","date":"2022-01-17 12:30:59.000000000","tz":60},"committer":{"name":"Tomas Vanek","email":"vanekt@fbl.cz","date":"2022-02-25 10:58:41.000000000","tz":0},"subject":"flash/nor/stm32f2x: Fix erase of bank 2 sectors","message":"flash/nor/stm32f2x: Fix erase of bank 2 sectors\n\nThis commit corrects the erase function for stm32f2x when dealing with\nsectors in bank 2, for STM32F42x/43x devices with 1MB flash.\n\nOn STM32F42x/43x with 1MB flash in dual bank configuration, the sector\nnumbering is not consecutive. The last sector in bank 1 is number 7, and\nthe first sector in bank 2 is number 12.\nThe sector indices used by openocd, however, _are_ consecutive (0 to 15\nin this case). The arguments \"first\" and \"last\" to stm32x_erase() are of\nthis type, and so the logic surrounding sector numbers needed to be\ncorrected.\nSince the two banks in dual bank mode have the same number of sectors, a\nsector index in bank 2 is larger than or equal to half the total number\nof sectors.\n\nChange-Id: I15260f8a86d9002769a1ae1c40ebdf62142dae18\nSigned-off-by: Simon Johansson \u003campleyfly@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6810\nTested-by: jenkins\nReviewed-by: Tomas Vanek \u003cvanekt@fbl.cz\u003e\nReviewed-by: Tarek BOCHKATI \u003ctarek.bouchkati@gmail.com\u003e\n"}},"579e4789f1406634815dbf138fedd2add479db17":{"kind":"REWORK","_number":1,"created":"2022-01-17 13:16:14.000000000","uploader":{"_account_id":1001954,"name":"Simon Johansson","email":"ampleyfly@gmail.com","username":"ampleyfly"},"ref":"refs/changes/10/6810/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/10/6810/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/10/6810/1 \u0026\u0026 git checkout -b change-6810 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/10/6810/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/10/6810/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/10/6810/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/10/6810/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/10/6810/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"aad87180586a43500f8af1cf79255c7293bb258b","subject":"flash/nor/efr32: fixed lockbits and user data"}],"author":{"name":"Simon Johansson","email":"ampleyfly@gmail.com","date":"2022-01-17 12:30:59.000000000","tz":60},"committer":{"name":"Simon Johansson","email":"ampleyfly@gmail.com","date":"2022-01-17 13:11:09.000000000","tz":60},"subject":"flash/nor/stm32f2x: Fix erase of bank 2 sectors","message":"flash/nor/stm32f2x: Fix erase of bank 2 sectors\n\nThis commit corrects the erase function for stm32f2x when dealing with\nsectors in bank 2, for STM32F42x/43x devices with 1MB flash.\n\nOn STM32F42x/43x with 1MB flash in dual bank configuration, the sector\nnumbering is not consecutive. The last sector in bank 1 is number 7, and\nthe first sector in bank 2 is number 12.\nThe sector indices used by openocd, however, _are_ consecutive (0 to 15\nin this case). The arguments \"first\" and \"last\" to stm32x_erase() are of\nthis type, and so the logic surrounding sector numbers needed to be\ncorrected.\nSince the two banks in dual bank mode have the same number of sectors, a\nsector index in bank 2 is larger than or equal to half the total number\nof sectors.\n\nChange-Id: I15260f8a86d9002769a1ae1c40ebdf62142dae18\nSigned-off-by: Simon Johansson \u003campleyfly@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000687,"name":"Tomas Vanek","display_name":"Tomas Vanek","email":"vanekt@fbl.cz","username":"vanekt"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}