)]}'
{"id":"openocd~master~I6544ac7740b808a6c0fbacf97ac00b97f5bd3832","project":"openocd","branch":"master","topic":"romtable","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2022-01-29 19:13:00.000000000","reason":"Antonio Borneo replied on the change"}},"hashtags":[],"change_id":"I6544ac7740b808a6c0fbacf97ac00b97f5bd3832","subject":"arm_adi_v5: rework dap_read_part_id()","status":"MERGED","created":"2022-01-23 14:39:04.000000000","updated":"2022-05-14 08:50:41.000000000","submitted":"2022-05-14 08:50:41.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6815-romtable","meta_rev_id":"5c47c8187144a4fc0f8e7d69f0e6e4e6c6f809eb","_number":6815,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-05-14 08:50:41.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-05-14 08:50:41.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-01-23 15:38:08.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"1432ee78501647460c75d1af92ca9c162010f15e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-01-23 14:39:04.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c3035b1cca3ed0afc5dbcadd6a1fd981261be9c8","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-01-23 15:36:47.000000000","message":"Uploaded patch set 2: New patch set was added with same tree, parent, and commit message as Patch Set 1.","accounts_in_message":[],"_revision_number":2},{"id":"3972bf1710567c78ece12ceafcf345e2f5ba2a49","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-01-23 15:38:08.000000000","message":"Patch Set 1: Verified-1\n\nBuild Failed \n\nhttps://build.openocd.org/job/openocd-gerrit/15779/ : ABORTED","accounts_in_message":[],"_revision_number":1},{"id":"cee36c04d5c603781f0cfa6fd8f014800642bbef","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-01-23 16:56:39.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15783/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14995/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"a1e757cb66ecc00b811eb4f4cb655d18eb016bb2","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-01-29 19:13:00.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"e25bce58f54848b81fb8a532c76030d94b822634","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-04-28 21:04:10.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"5c47c8187144a4fc0f8e7d69f0e6e4e6c6f809eb","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-05-14 08:50:41.000000000","message":"Change has been successfully cherry-picked as c3f6e21d5ccc165493b23677b6d63c24f5c183c3","accounts_in_message":[],"_revision_number":3}],"current_revision":"c3f6e21d5ccc165493b23677b6d63c24f5c183c3","revisions":{"265cec5444b99f1f3866b33280d8736711eb9c09":{"kind":"REWORK","_number":1,"created":"2022-01-23 14:39:04.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/15/6815/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/15/6815/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/15/6815/1 \u0026\u0026 git checkout -b change-6815 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/15/6815/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/15/6815/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/15/6815/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/15/6815/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/15/6815/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3526e5b02b4d6801a226bd633b8d44f753654a3e","subject":"arm_adi_v5: add support for display Class 0x9 ROM tables"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-01-13 23:43:37.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-01-23 13:46:49.000000000","tz":60},"subject":"arm_adi_v5: rework dap_read_part_id()","message":"arm_adi_v5: rework dap_read_part_id()\n\nRework dap_read_part_id() while preparing for reorganizing the\n\u0027ROM Table Parsing\u0027 (RTP):\n- rename it with \u0027rtp\u0027 prefix;\n- extends it to read other CoreSight registers, thus improving the\n  overall speed by queuing more reads;\n- reduce the list of arguments by using a struct;\n- reorder the reads by increasing offset, potentially gaining\n  speed using MEM_AP_REG_BDx and/or auto-increment;\n- log a debug message in case of read error.\n\nChange-Id: I6544ac7740b808a6c0fbacf97ac00b97f5bd3832\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"c3f6e21d5ccc165493b23677b6d63c24f5c183c3":{"kind":"REWORK","_number":3,"created":"2022-05-14 08:50:41.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/15/6815/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/15/6815/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/15/6815/3 \u0026\u0026 git checkout -b change-6815 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/15/6815/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/15/6815/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/15/6815/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/15/6815/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/15/6815/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1fd2a6c7f5cba7c5ec655e355e63dd31804bb900","subject":"arm_adi_v5: add support for display Class 0x9 ROM tables"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-01-13 23:43:37.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-05-14 08:50:41.000000000","tz":0},"subject":"arm_adi_v5: rework dap_read_part_id()","message":"arm_adi_v5: rework dap_read_part_id()\n\nRework dap_read_part_id() while preparing for reorganizing the\n\u0027ROM Table Parsing\u0027 (RTP):\n- rename it with \u0027rtp\u0027 prefix;\n- extends it to read other CoreSight registers, thus improving the\n  overall speed by queuing more reads;\n- reduce the list of arguments by using a struct;\n- reorder the reads by increasing offset, potentially gaining\n  speed using MEM_AP_REG_BDx and/or auto-increment;\n- log a debug message in case of read error.\n\nChange-Id: I6544ac7740b808a6c0fbacf97ac00b97f5bd3832\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6815\nTested-by: jenkins\n"}},"300efdbb3c8d6ca7e1716ee852630d9f1ef8d3a7":{"kind":"NO_CHANGE","_number":2,"created":"2022-01-23 15:36:47.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/15/6815/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/15/6815/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/15/6815/2 \u0026\u0026 git checkout -b change-6815 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/15/6815/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/15/6815/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/15/6815/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/15/6815/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/15/6815/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"6a7b6c5b002bf39809ec171c64355aa3df55f6d8","subject":"arm_adi_v5: add support for display Class 0x9 ROM tables"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-01-13 23:43:37.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-01-23 15:36:02.000000000","tz":60},"subject":"arm_adi_v5: rework dap_read_part_id()","message":"arm_adi_v5: rework dap_read_part_id()\n\nRework dap_read_part_id() while preparing for reorganizing the\n\u0027ROM Table Parsing\u0027 (RTP):\n- rename it with \u0027rtp\u0027 prefix;\n- extends it to read other CoreSight registers, thus improving the\n  overall speed by queuing more reads;\n- reduce the list of arguments by using a struct;\n- reorder the reads by increasing offset, potentially gaining\n  speed using MEM_AP_REG_BDx and/or auto-increment;\n- log a debug message in case of read error.\n\nChange-Id: I6544ac7740b808a6c0fbacf97ac00b97f5bd3832\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}