)]}'
{"id":"openocd~master~I5ad106a99b9c21ddb48b5b162ae87101e4f49878","project":"openocd","branch":"master","topic":"romtable","hashtags":[],"change_id":"I5ad106a99b9c21ddb48b5b162ae87101e4f49878","subject":"arm_adi_v5: split ROM table loop from generic coresight","status":"MERGED","created":"2022-01-23 14:39:04.000000000","updated":"2022-05-14 08:51:07.000000000","submitted":"2022-05-14 08:51:07.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6816-romtable","meta_rev_id":"a23dd33e75421e54a97445fb44729cfb19005cb9","_number":6816,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-05-14 08:51:07.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-05-14 08:51:07.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-01-23 15:37:54.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2022-01-23 17:38:58.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"76f90bcf38c286f1fcdc908f9351ed80485882bc","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-01-23 14:39:04.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"729275c7cf0a1a1c6aa88e41eceb4be1dc264b35","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-01-23 15:36:47.000000000","message":"Uploaded patch set 2: New patch set was added with same tree, parent, and commit message as Patch Set 1.","accounts_in_message":[],"_revision_number":2},{"id":"c7cb8b4a01a106613d7319a4a1ab813351cb8309","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-01-23 15:37:54.000000000","message":"Patch Set 1:\n\nNo Builds Executed","accounts_in_message":[],"_revision_number":1},{"id":"101eae78e0de5acad69935a997277181b838da35","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-01-23 17:38:58.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15785/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14997/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"32ae00a5fedb40b720a542aff1f7e5b40a03fe82","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-01-29 19:13:38.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"3fc29d35feffe39279bff0264d3be6e9f6b1e652","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-04-28 21:04:18.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"a23dd33e75421e54a97445fb44729cfb19005cb9","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-05-14 08:51:07.000000000","message":"Change has been successfully cherry-picked as 209cb38aa155825175e2806d6093cecb5d77edc1","accounts_in_message":[],"_revision_number":3}],"current_revision":"209cb38aa155825175e2806d6093cecb5d77edc1","revisions":{"583ba5b63f690c4f61364145c4690ce740f4232e":{"kind":"REWORK","_number":1,"created":"2022-01-23 14:39:04.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/16/6816/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/16/6816/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/16/6816/1 \u0026\u0026 git checkout -b change-6816 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/16/6816/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/16/6816/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/16/6816/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/16/6816/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/16/6816/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"265cec5444b99f1f3866b33280d8736711eb9c09","subject":"arm_adi_v5: rework dap_read_part_id()"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-01-14 12:52:01.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-01-23 13:46:52.000000000","tz":60},"subject":"arm_adi_v5: split ROM table loop from generic coresight","message":"arm_adi_v5: split ROM table loop from generic coresight\n\nDuring ROM table parsing, each ROM table entry points to a\nCoreSight component that can, in turn, be another ROM table.\n\nSplit the specific code for ROM table handling from the generic\nCoreSight code.\nLog an error if a ROM table entry cannot be read.\n\nChange-Id: I5ad106a99b9c21ddb48b5b162ae87101e4f49878\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"19f6caa045665f7da7eaeeebeedc617d16c52aaf":{"kind":"NO_CHANGE","_number":2,"created":"2022-01-23 15:36:47.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/16/6816/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/16/6816/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/16/6816/2 \u0026\u0026 git checkout -b change-6816 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/16/6816/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/16/6816/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/16/6816/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/16/6816/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/16/6816/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"300efdbb3c8d6ca7e1716ee852630d9f1ef8d3a7","subject":"arm_adi_v5: rework dap_read_part_id()"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-01-14 12:52:01.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-01-23 15:36:02.000000000","tz":60},"subject":"arm_adi_v5: split ROM table loop from generic coresight","message":"arm_adi_v5: split ROM table loop from generic coresight\n\nDuring ROM table parsing, each ROM table entry points to a\nCoreSight component that can, in turn, be another ROM table.\n\nSplit the specific code for ROM table handling from the generic\nCoreSight code.\nLog an error if a ROM table entry cannot be read.\n\nChange-Id: I5ad106a99b9c21ddb48b5b162ae87101e4f49878\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"209cb38aa155825175e2806d6093cecb5d77edc1":{"kind":"REWORK","_number":3,"created":"2022-05-14 08:51:07.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/16/6816/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/16/6816/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/16/6816/3 \u0026\u0026 git checkout -b change-6816 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/16/6816/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/16/6816/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/16/6816/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/16/6816/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/16/6816/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c3f6e21d5ccc165493b23677b6d63c24f5c183c3","subject":"arm_adi_v5: rework dap_read_part_id()"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-01-14 12:52:01.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-05-14 08:51:07.000000000","tz":0},"subject":"arm_adi_v5: split ROM table loop from generic coresight","message":"arm_adi_v5: split ROM table loop from generic coresight\n\nDuring ROM table parsing, each ROM table entry points to a\nCoreSight component that can, in turn, be another ROM table.\n\nSplit the specific code for ROM table handling from the generic\nCoreSight code.\nLog an error if a ROM table entry cannot be read.\n\nChange-Id: I5ad106a99b9c21ddb48b5b162ae87101e4f49878\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6816\nTested-by: jenkins\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}