)]}'
{"id":"openocd~master~Ic85d1ea068ed706ceedfd65076ff4c96d04e9792","project":"openocd","branch":"master","topic":"romtable","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2022-04-28 21:04:27.000000000","reason":"Antonio Borneo replied on the change"}},"hashtags":[],"change_id":"Ic85d1ea068ed706ceedfd65076ff4c96d04e9792","subject":"arm_adi_v5: report sysmem on class 0x9 ROM tables","status":"MERGED","created":"2022-01-23 14:39:04.000000000","updated":"2022-05-14 08:52:30.000000000","submitted":"2022-05-14 08:52:30.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6817-romtable","meta_rev_id":"c297cb935c20ff6760e646fb141483388487c1c1","_number":6817,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-05-14 08:52:30.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"value":0,"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-05-14 08:52:30.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-05-14 08:52:30.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-01-23 15:37:59.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2022-01-23 18:25:20.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-01-30 00:10:00.000000000","updated_by":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"reviewer":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"state":"REVIEWER"}],"messages":[{"id":"e8ffe67fc36e002fdbb1e6663d89fad2454ea9e0","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-01-23 14:39:04.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f2f665790dbffefd00a57ade55c27d8a12c21e23","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-01-23 15:36:47.000000000","message":"Uploaded patch set 2: New patch set was added with same tree, parent, and commit message as Patch Set 1.","accounts_in_message":[],"_revision_number":2},{"id":"4698865b43484f4652312a37d5e1b6b08d976645","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-01-23 15:37:59.000000000","message":"Patch Set 1:\n\nNo Builds Executed","accounts_in_message":[],"_revision_number":1},{"id":"4cbfe06f2714fb6db0841abd05d9a78cbefd8ca3","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-01-23 18:25:20.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15786/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/15000/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"ae14975aa2e577654d26f7965c0f54a69ab969cc","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-01-29 19:13:47.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"c437fd50d01b0677ce1bef6e70f91b9f415ce5f9","author":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"real_author":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"date":"2022-01-30 00:10:00.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"5460abd309dfdd530ff92ceaa10e5909974fee5b","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-04-28 21:04:27.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"c297cb935c20ff6760e646fb141483388487c1c1","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-05-14 08:52:30.000000000","message":"Change has been successfully cherry-picked as d4335071b8460b227889a3a2072df424eebb4e5e","accounts_in_message":[],"_revision_number":3}],"current_revision":"d4335071b8460b227889a3a2072df424eebb4e5e","revisions":{"3ee4ebb934a5d4b65cfb0168926dad350cf63ccb":{"kind":"REWORK","_number":1,"created":"2022-01-23 14:39:04.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/17/6817/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/17/6817/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/17/6817/1 \u0026\u0026 git checkout -b change-6817 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/17/6817/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/17/6817/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/17/6817/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/17/6817/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/17/6817/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"583ba5b63f690c4f61364145c4690ce740f4232e","subject":"arm_adi_v5: split ROM table loop from generic coresight"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-01-15 14:44:20.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-01-23 13:46:52.000000000","tz":60},"subject":"arm_adi_v5: report sysmem on class 0x9 ROM tables","message":"arm_adi_v5: report sysmem on class 0x9 ROM tables\n\nAs Class 0x1 ROM table, also Class 0x9 ROM tables encodes a flag\nfor system memory access.\n\nDetect the flag in rtp_cs_component() and dump the same message\nfor both type of ROM tables.\nExtend rtp_read_cs_regs() to read ARM_CS_C9_DEVID.\n\nChange-Id: Ic85d1ea068ed706ceedfd65076ff4c96d04e9792\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"8e2dbfa9e32866e2a6f54f5a608a814963928aed":{"kind":"NO_CHANGE","_number":2,"created":"2022-01-23 15:36:47.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/17/6817/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/17/6817/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/17/6817/2 \u0026\u0026 git checkout -b change-6817 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/17/6817/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/17/6817/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/17/6817/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/17/6817/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/17/6817/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"19f6caa045665f7da7eaeeebeedc617d16c52aaf","subject":"arm_adi_v5: split ROM table loop from generic coresight"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-01-15 14:44:20.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-01-23 15:36:02.000000000","tz":60},"subject":"arm_adi_v5: report sysmem on class 0x9 ROM tables","message":"arm_adi_v5: report sysmem on class 0x9 ROM tables\n\nAs Class 0x1 ROM table, also Class 0x9 ROM tables encodes a flag\nfor system memory access.\n\nDetect the flag in rtp_cs_component() and dump the same message\nfor both type of ROM tables.\nExtend rtp_read_cs_regs() to read ARM_CS_C9_DEVID.\n\nChange-Id: Ic85d1ea068ed706ceedfd65076ff4c96d04e9792\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"d4335071b8460b227889a3a2072df424eebb4e5e":{"kind":"REWORK","_number":3,"created":"2022-05-14 08:52:30.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/17/6817/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/17/6817/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/17/6817/3 \u0026\u0026 git checkout -b change-6817 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/17/6817/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/17/6817/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/17/6817/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/17/6817/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/17/6817/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"209cb38aa155825175e2806d6093cecb5d77edc1","subject":"arm_adi_v5: split ROM table loop from generic coresight"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-01-15 14:44:20.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-05-14 08:52:30.000000000","tz":0},"subject":"arm_adi_v5: report sysmem on class 0x9 ROM tables","message":"arm_adi_v5: report sysmem on class 0x9 ROM tables\n\nAs Class 0x1 ROM table, also Class 0x9 ROM tables encodes a flag\nfor system memory access.\n\nDetect the flag in rtp_cs_component() and dump the same message\nfor both type of ROM tables.\nExtend rtp_read_cs_regs() to read ARM_CS_C9_DEVID.\n\nChange-Id: Ic85d1ea068ed706ceedfd65076ff4c96d04e9792\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6817\nTested-by: jenkins\nReviewed-by: Daniel Goehring \u003cdgoehrin@os.amperecomputing.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}