)]}'
{"id":"openocd~master~I94fdb5b175bfb07dde378149421582b7e7cd5b09","project":"openocd","branch":"master","topic":"romtable","attention_set":{},"removed_from_attention_set":{"1000021":{"account":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"last_update":"2022-04-28 21:04:33.000000000","reason":"Antonio Borneo replied on the change"}},"hashtags":[],"change_id":"I94fdb5b175bfb07dde378149421582b7e7cd5b09","subject":"arm_adi_v5: handle faulting entry in ROM table","status":"MERGED","created":"2022-01-23 14:39:04.000000000","updated":"2022-05-14 08:53:35.000000000","submitted":"2022-05-14 08:53:35.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6818-romtable","meta_rev_id":"6837172e206aab034695f88654c009f58e1fa818","_number":6818,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-05-14 08:53:35.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"value":0,"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-05-14 08:53:35.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-05-14 08:53:35.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-01-23 15:37:58.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2022-01-23 18:12:03.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-01-30 00:16:02.000000000","updated_by":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"reviewer":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"state":"REVIEWER"}],"messages":[{"id":"3f7b71e769b164106f373e047a446210cdfc4858","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-01-23 14:39:04.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b24075b143649f599c5a81e9d7be4697a5469e34","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-01-23 15:36:47.000000000","message":"Uploaded patch set 2: New patch set was added with same tree, parent, and commit message as Patch Set 1.","accounts_in_message":[],"_revision_number":2},{"id":"6559abfbda457ff8cc9e21a42b941facfec9952c","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-01-23 15:37:58.000000000","message":"Patch Set 1:\n\nNo Builds Executed","accounts_in_message":[],"_revision_number":1},{"id":"79b3f4aa6c29c714ec5b959318aba9abce91a216","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-01-23 18:12:03.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15787/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14999/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"85a94042fab746d217b1be322cfe17131657cc22","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-01-29 19:13:55.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"3b9391ec2310c70fd58d36713f38ce5f9fd3c184","author":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"real_author":{"_account_id":1001661,"name":"Daniel Goehring","email":"dgoehrin@os.amperecomputing.com","username":"dgoehrin"},"date":"2022-01-30 00:16:02.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"46beb93b8079ad687d2aae38c298bb5d43cd2e70","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-04-28 21:04:33.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"6837172e206aab034695f88654c009f58e1fa818","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-05-14 08:53:35.000000000","message":"Change has been successfully cherry-picked as a73adb52410acb4b4b92f281920d14bd5c490fe4","accounts_in_message":[],"_revision_number":3}],"current_revision":"a73adb52410acb4b4b92f281920d14bd5c490fe4","revisions":{"1e85463d2c6f1feb6bf2cc8078bea0a76c3328e6":{"kind":"REWORK","_number":1,"created":"2022-01-23 14:39:04.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/18/6818/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/18/6818/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/18/6818/1 \u0026\u0026 git checkout -b change-6818 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/18/6818/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/18/6818/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/18/6818/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/18/6818/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/18/6818/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3ee4ebb934a5d4b65cfb0168926dad350cf63ccb","subject":"arm_adi_v5: report sysmem on class 0x9 ROM tables"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-01-14 14:15:30.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-01-23 13:46:52.000000000","tz":60},"subject":"arm_adi_v5: handle faulting entry in ROM table","message":"arm_adi_v5: handle faulting entry in ROM table\n\nARM IHI0031F \"Arm Debug Interface Architecture Specification\"\nchapter C2.6.1 \"BASE, Debug Base Address register\" reports:\n\tA debugger must handle the following situations as\n\tnon-fatal errors:\n\t- ...\n\t- An entry in the ROM Table points to a faulting location.\n\t- ...\n\tTypically, a debugger issues a warning if it encounters\n\tone of these situations. However, Arm recommends that it\n\tcontinues operating. An example of an implementation that\n\tmight cause errors of this type is a system with static\n\tbase address or ROM Table entries that enable entire\n\tsubsystems to be disabled, for example by a tie-off input,\n\tpackaging choice, fuse, or similar.\n\nDon\u0027t halt ROM table parsing if one entry causes an error; log the\nerror condition and continue to next entry.\nNot sure if we have to send an ABORT before continuing.\n\nChange-Id: I94fdb5b175bfb07dde378149421582b7e7cd5b09\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"89cf237e7e22a2139197fc996cafa1698246b230":{"kind":"NO_CHANGE","_number":2,"created":"2022-01-23 15:36:47.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/18/6818/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/18/6818/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/18/6818/2 \u0026\u0026 git checkout -b change-6818 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/18/6818/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/18/6818/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/18/6818/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/18/6818/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/18/6818/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"8e2dbfa9e32866e2a6f54f5a608a814963928aed","subject":"arm_adi_v5: report sysmem on class 0x9 ROM tables"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-01-14 14:15:30.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-01-23 15:36:02.000000000","tz":60},"subject":"arm_adi_v5: handle faulting entry in ROM table","message":"arm_adi_v5: handle faulting entry in ROM table\n\nARM IHI0031F \"Arm Debug Interface Architecture Specification\"\nchapter C2.6.1 \"BASE, Debug Base Address register\" reports:\n\tA debugger must handle the following situations as\n\tnon-fatal errors:\n\t- ...\n\t- An entry in the ROM Table points to a faulting location.\n\t- ...\n\tTypically, a debugger issues a warning if it encounters\n\tone of these situations. However, Arm recommends that it\n\tcontinues operating. An example of an implementation that\n\tmight cause errors of this type is a system with static\n\tbase address or ROM Table entries that enable entire\n\tsubsystems to be disabled, for example by a tie-off input,\n\tpackaging choice, fuse, or similar.\n\nDon\u0027t halt ROM table parsing if one entry causes an error; log the\nerror condition and continue to next entry.\nNot sure if we have to send an ABORT before continuing.\n\nChange-Id: I94fdb5b175bfb07dde378149421582b7e7cd5b09\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"a73adb52410acb4b4b92f281920d14bd5c490fe4":{"kind":"REWORK","_number":3,"created":"2022-05-14 08:53:35.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/18/6818/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/18/6818/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/18/6818/3 \u0026\u0026 git checkout -b change-6818 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/18/6818/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/18/6818/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/18/6818/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/18/6818/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/18/6818/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d4335071b8460b227889a3a2072df424eebb4e5e","subject":"arm_adi_v5: report sysmem on class 0x9 ROM tables"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-01-14 14:15:30.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-05-14 08:53:35.000000000","tz":0},"subject":"arm_adi_v5: handle faulting entry in ROM table","message":"arm_adi_v5: handle faulting entry in ROM table\n\nARM IHI0031F \"Arm Debug Interface Architecture Specification\"\nchapter C2.6.1 \"BASE, Debug Base Address register\" reports:\n\tA debugger must handle the following situations as\n\tnon-fatal errors:\n\t- ...\n\t- An entry in the ROM Table points to a faulting location.\n\t- ...\n\tTypically, a debugger issues a warning if it encounters\n\tone of these situations. However, Arm recommends that it\n\tcontinues operating. An example of an implementation that\n\tmight cause errors of this type is a system with static\n\tbase address or ROM Table entries that enable entire\n\tsubsystems to be disabled, for example by a tie-off input,\n\tpackaging choice, fuse, or similar.\n\nDon\u0027t halt ROM table parsing if one entry causes an error; log the\nerror condition and continue to next entry.\nNot sure if we have to send an ABORT before continuing.\n\nChange-Id: I94fdb5b175bfb07dde378149421582b7e7cd5b09\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6818\nTested-by: jenkins\nReviewed-by: Daniel Goehring \u003cdgoehrin@os.amperecomputing.com\u003e\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}