)]}'
{"id":"openocd~master~I112f637edfdb8688afb4e631297f6536da9604f1","project":"openocd","branch":"master","topic":"romtable","hashtags":[],"change_id":"I112f637edfdb8688afb4e631297f6536da9604f1","subject":"arm_adi_v5: separate ROM table parsing from command output [1/3]","status":"MERGED","created":"2022-01-23 14:39:04.000000000","updated":"2022-05-14 08:54:02.000000000","submitted":"2022-05-14 08:54:02.000000000","submitter":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"6819-romtable","meta_rev_id":"4bfab88e4c6678e1f458b587b88dd31af3c5769d","_number":6819,"owner":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2022-05-14 08:54:02.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2022-05-14 08:54:02.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},{"value":0,"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-01-23 15:37:57.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2022-01-23 17:53:41.000000000","updated_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"4e5adf28a57e4c9376401d5f0fd9619d22fa50cd","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-01-23 14:39:04.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ded80d76f738caa0677034571d2902f610a7d1ff","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-01-23 15:36:47.000000000","message":"Uploaded patch set 2: New patch set was added with same tree, parent, and commit message as Patch Set 1.","accounts_in_message":[],"_revision_number":2},{"id":"d747422ade586fb3f30274b38a831d6264a08c3d","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-01-23 15:37:57.000000000","message":"Patch Set 1:\n\nNo Builds Executed","accounts_in_message":[],"_revision_number":1},{"id":"8b7b7a6d83c5cd593606d69dcef84ea144d48594","author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"real_author":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]},"date":"2022-01-23 17:53:41.000000000","message":"Patch Set 2: Verified+1\n\nBuild Successful \n\nhttps://build.openocd.org/job/openocd-gerrit/15788/ : SUCCESS\n\nhttps://build.openocd.org/job/openocd-gerrit-build/14998/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"579d7972b9dc03ec1b21cb8a21d7febe23d9e986","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-01-29 19:14:04.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"8e64f37876893cef831f6670d1fbd2ed1464454d","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-04-28 21:04:40.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"4bfab88e4c6678e1f458b587b88dd31af3c5769d","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"real_author":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"date":"2022-05-14 08:54:02.000000000","message":"Change has been successfully cherry-picked as 21f7885d1c2aa8a8f3d6967d8ee2910570e5cc11","accounts_in_message":[],"_revision_number":3}],"current_revision":"21f7885d1c2aa8a8f3d6967d8ee2910570e5cc11","revisions":{"12beaaca721f180d82f9096ea090eeea170d6c4d":{"kind":"REWORK","_number":1,"created":"2022-01-23 14:39:04.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/19/6819/1","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/19/6819/1","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/19/6819/1 \u0026\u0026 git checkout -b change-6819 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/19/6819/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/19/6819/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/19/6819/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/19/6819/1","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/19/6819/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1e85463d2c6f1feb6bf2cc8078bea0a76c3328e6","subject":"arm_adi_v5: handle faulting entry in ROM table"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-01-14 17:20:09.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-01-23 13:46:52.000000000","tz":60},"subject":"arm_adi_v5: separate ROM table parsing from command output [1/3]","message":"arm_adi_v5: separate ROM table parsing from command output [1/3]\n\nIn OpenOCD arm_adi_v5 we have already two implementations of code\nfor parsing the ADIv5 ROM table:\n- in the commands \"dap info\" and \"$dap_name info\";\n- in the function dap_lookup_cs_component().\nAdding support for ADIv6 requires extending both implementations.\n\nMoreover, current code does not handle few aspects of the ROM\nparsing, e.g. the \"Power Domain IDs\".\nTo add such extensions both implementations should be touched.\n\nI plan to add a command to parses (again) the ROM table and dump a\nsimple prototype of a configuration script for the target, useful\nwhile analysing a new target.\n\nKeeping aligned all these implementation would be too complex.\n\nWith focus to \"dap info\" command, decouple the part of code to\nwalk-through the ROM table from the code that creates the command\noutput.\nThe idea is to keep a single implementation for the walk-through\ncode, while parametrizing the output code to handle the generation\nof a configuration script or the result of the function\ndap_lookup_cs_component().\n\nThis change only targets the output of MEM-AP header\nFurther changes will target other parts of the code.\n\nWhile there, add a message if MEM-AP is not accessible.\n\nChange-Id: I112f637edfdb8688afb4e631297f6536da9604f1\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"2ba46ee0d87251e411a2b2f596451b6d8dd3e7be":{"kind":"NO_CHANGE","_number":2,"created":"2022-01-23 15:36:47.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/19/6819/2","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/19/6819/2","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/19/6819/2 \u0026\u0026 git checkout -b change-6819 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/19/6819/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/19/6819/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/19/6819/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/19/6819/2","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/19/6819/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"89cf237e7e22a2139197fc996cafa1698246b230","subject":"arm_adi_v5: handle faulting entry in ROM table"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-01-14 17:20:09.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-01-23 15:36:02.000000000","tz":60},"subject":"arm_adi_v5: separate ROM table parsing from command output [1/3]","message":"arm_adi_v5: separate ROM table parsing from command output [1/3]\n\nIn OpenOCD arm_adi_v5 we have already two implementations of code\nfor parsing the ADIv5 ROM table:\n- in the commands \"dap info\" and \"$dap_name info\";\n- in the function dap_lookup_cs_component().\nAdding support for ADIv6 requires extending both implementations.\n\nMoreover, current code does not handle few aspects of the ROM\nparsing, e.g. the \"Power Domain IDs\".\nTo add such extensions both implementations should be touched.\n\nI plan to add a command to parses (again) the ROM table and dump a\nsimple prototype of a configuration script for the target, useful\nwhile analysing a new target.\n\nKeeping aligned all these implementation would be too complex.\n\nWith focus to \"dap info\" command, decouple the part of code to\nwalk-through the ROM table from the code that creates the command\noutput.\nThe idea is to keep a single implementation for the walk-through\ncode, while parametrizing the output code to handle the generation\nof a configuration script or the result of the function\ndap_lookup_cs_component().\n\nThis change only targets the output of MEM-AP header\nFurther changes will target other parts of the code.\n\nWhile there, add a message if MEM-AP is not accessible.\n\nChange-Id: I112f637edfdb8688afb4e631297f6536da9604f1\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\n"}},"21f7885d1c2aa8a8f3d6967d8ee2910570e5cc11":{"kind":"REWORK","_number":3,"created":"2022-05-14 08:54:02.000000000","uploader":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"},"ref":"refs/changes/19/6819/3","fetch":{"anonymous http":{"url":"https://review.openocd.org/openocd","ref":"refs/changes/19/6819/3","commands":{"Branch":"git fetch https://review.openocd.org/openocd refs/changes/19/6819/3 \u0026\u0026 git checkout -b change-6819 FETCH_HEAD","Checkout":"git fetch https://review.openocd.org/openocd refs/changes/19/6819/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.openocd.org/openocd refs/changes/19/6819/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.openocd.org/openocd refs/changes/19/6819/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.openocd.org/openocd refs/changes/19/6819/3","Reset To":"git fetch https://review.openocd.org/openocd refs/changes/19/6819/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a73adb52410acb4b4b92f281920d14bd5c490fe4","subject":"arm_adi_v5: handle faulting entry in ROM table"}],"author":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-01-14 17:20:09.000000000","tz":60},"committer":{"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","date":"2022-05-14 08:54:02.000000000","tz":0},"subject":"arm_adi_v5: separate ROM table parsing from command output [1/3]","message":"arm_adi_v5: separate ROM table parsing from command output [1/3]\n\nIn OpenOCD arm_adi_v5 we have already two implementations of code\nfor parsing the ADIv5 ROM table:\n- in the commands \"dap info\" and \"$dap_name info\";\n- in the function dap_lookup_cs_component().\nAdding support for ADIv6 requires extending both implementations.\n\nMoreover, current code does not handle few aspects of the ROM\nparsing, e.g. the \"Power Domain IDs\".\nTo add such extensions both implementations should be touched.\n\nI plan to add a command to parses (again) the ROM table and dump a\nsimple prototype of a configuration script for the target, useful\nwhile analysing a new target.\n\nKeeping aligned all these implementation would be too complex.\n\nWith focus to \"dap info\" command, decouple the part of code to\nwalk-through the ROM table from the code that creates the command\noutput.\nThe idea is to keep a single implementation for the walk-through\ncode, while parametrizing the output code to handle the generation\nof a configuration script or the result of the function\ndap_lookup_cs_component().\n\nThis change only targets the output of MEM-AP header\nFurther changes will target other parts of the code.\n\nWhile there, add a message if MEM-AP is not accessible.\n\nChange-Id: I112f637edfdb8688afb4e631297f6536da9604f1\nSigned-off-by: Antonio Borneo \u003cborneo.antonio@gmail.com\u003e\nReviewed-on: https://review.openocd.org/c/openocd/+/6819\nTested-by: jenkins\n"}}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"jenkins","username":"jenkins","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000021,"name":"Antonio Borneo","email":"borneo.antonio@gmail.com","username":"borneoa"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}}]}